The Inbox: System-dtl.1164.mcz

On Wed, Jun 10, 2020 at 05:07:53PM -0700, Eliot Miranda wrote:
I didn't read Chris' question as a veto, just a bit of possibly justified
skepticism. But all four of these proposed options should be quite easy to
implement, so there's no reason not to try them :-)

Dave

Note to self: The #rawArguments method should be private, follow up
in a future update.

If anyone is getting ready to push something for System to the trunk,
can you please also move SmalltalkImage>>rawArguments to method
category 'private'?

Thanks,
Dave

On Wed, Jun 10, 2020 at 11:58:03AM -0400, David T. Lewis wrote:

Hi Tim,

On Tue, Jun 09, 2020 at 12:06:00PM -0700, tim Rowledge wrote: Attached is a quick and dirty implementation than handles -filein, -doit, and -evaluate.

Dave
 

It works pretty well actually:

$ time run squeak -- -evaluate "(3 + 4 + Float pi cubed) asScaledDecimal: 20"
38.00627668029981975905s20

real 0m0.134s
user 0m0.054s
sys 0m0.088s



On Fri, Jun 12, 2020 at 03:41:34PM -0400, David T. Lewis wrote:
> 'From Squeak6.0alpha of 8 June 2020 [latest update: #19714] on 12 June 2020 at 3:38:05 pm'! "Change Set: DoItFirst-dtl Date: 12 June 2020 Author: David T Lewis Be the first thing in the system startup list, and do things that should be done prior to any additional image initialization. If the first image argument is a recognized option, evalutate it. Image arguments are typically preceeded by a '--' token on the command line. Possible command options:   -filein {some file names}   -doit {some strings}   -evaluate {a single string & write result to stdout & quit"! !DoItFirst commentStamp: 'dtl 6/12/2020 15:34' prior: 0! Be the first thing in the system startup list, and do things that should be done prior to any additional image initialization. If the first image argument is a recognized option, evalutate it. Image arguments are typically preceeded by a '--' token on the command line. Possible command options:   -filein {some file names}   -doit {some strings}   -evaluate {a single string & write result to stdout & quit ! !DoItFirst class methodsFor: 'class initialization' stamp: 'dtl 6/11/2020 18:42'! initialize "DoItFirst initialize" Smalltalk addToStartUpList: self before: SmallInteger.! ! !DoItFirst class methodsFor: 'actions' stamp: 'dtl 6/12/2020 14:41'! doIt: arguments "Evaluate arguments and print the result on stdout, or error message on stderr. Exit the image after any error." FileStream startUp: true. arguments do: [ :arg | [FileStream stdout nextPutAll: (Compiler evaluate: arg) asString; lf; flush] on: Error do: [ :ex | FileStream stderr nextPutAll: ex asString; lf; flush. Smalltalk quitPrimitive ]]! ! !DoItFirst class methodsFor: 'actions' stamp: 'dtl 6/12/2020 14:35'! evaluate: arg "Evaluate arg and print the result on stdout, or error message on stderr. Exit immediately without saving the image." FileStream startUp: true. [FileStream stdout nextPutAll: (Compiler evaluate: arg) asString; lf; flush] on: Error do: [ :ex | FileStream stderr nextPutAll: ex asString; lf; flush ]. Smalltalk quitPrimitive! ! !DoItFirst class methodsFor: 'actions' stamp: 'dtl 6/12/2020 15:28'! fileIn: fileNames "File in each named file. On error, print a message to stderr and exit the image." FileStream startUp: true. fileNames do: [ :arg | [ | fs | fs := FileStream oldFileNamed: arg. FileStream stdout nextPutAll: 'fiie in ', fs asString; lf; flush. fs fileIn ] on: Error do: [ :ex | FileStream stderr nextPutAll: ex asString; lf; flush. Smalltalk quitPrimitive ]]! ! !DoItFirst class methodsFor: 'system startup' stamp: 'dtl 6/12/2020 14:47'! startUp: resuming resuming ifTrue: [ | args | args := Smalltalk arguments. args size > 1 ifTrue: [ args first caseOf: { [ '-doit' ] -> [ self doIt: args allButFirst ] . [ '--doit' ] -> [ self doIt: args allButFirst ] . [ '-evaluate' ] -> [ self evaluate: args second ] . [ '--evaluate' ] -> [ self evaluate: args second ] . [ '-filein' ] -> [ self fileIn: args allButFirst ] . [ '--filein' ] -> [ self fileIn: args allButFirst ] } otherwise: []]] ! ! DoItFirst initialize!
>

Erk - the changeset you posted doesn't include the class definition and so fails to load. Which makes it really hard to try out...

> On 2020-06-12, at 2:04 PM, David T. Lewis <[hidden email]> wrote:
>
> It works pretty well actually:


tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Strange OpCodes: HCF: Halt and Catch Fire

That's odd. I filed the class in to a new change set, and end up
with no class definition in the change set, that can't be right.

Updated change set attached.

Dave


On Fri, Jun 12, 2020 at 02:09:52PM -0700, tim Rowledge wrote:

OK, the DoItFirst-dtl.2.cs filed in ok. It did however make the image save suddenly take a very long time  - but after save/quit and restartin the save no longer takes ages. Weird.

I had to execute -

 time  /home/pi/Documents/Squeak/sqcogspurlinuxhtRPi/squeak /home/pi/Documents/Squeak/CmdLineTests-TPR-Squeak5.3-19682-32bit.image  -- -evaluate "(3 + 4 + Float pi cubed) asScaledDecimal: 20"
38.00627668029981975905s20

real 0m0.393s
user 0m0.086s
sys 0m0.283s

a) no idea what the 'run' command might be and it is not on Raspbian
b) I'm guessing your 'squeak' script was finding the default named image?
c) that time was for a Pi 4, which took about 3x as long as what I image is probably a reasonably modern x64 box? The registered user time was less than double though. Not bad for $35.

I must be doing something wrong when I tried the -doit option though; it faults in CodeLoader>>installSourceFile: Apparently sometihng has lead it to see an HTTPDownloadRequest ... ok, so the ProjectLauncher>>startUpAfterLogin sees that Preferences readDocumentAtStartup is true and that makes the unwarranted assumption that self getSystemAttribute: 2 will provide the document path. Oops.


tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
If you think nobody cares about you, try missing a couple of payments.

Oh, sorry, the "run" command is my /usr/local/bin/run script that picks
a suitable VM. The effect is the same as running the VM executable directly,
so run the VM in whatever manner you like. I am in the habit of installing
my user executables (the VM run scripts in this case) in /usr/local/bin/ so
that they will be in my $PATH.

Here is what a -doit looks like on my PC. It evaluates the doIt argument,
and once the image opens you can see the #FOO has been added to the system
dictionary.

$ run squeak -- -doit "Smalltalk at: #FOO put: #BAR"
BAR

Note the ' -- ' before the '-doit'. However you might decide to invoke
the command line, you can put ' -- ' before the arguments and they
should get get passed along to the image.

Note that this hack is doing the evaluations as the very first thing
in the startUp sequence, so if you evaluate something that (for example)
opens an inspector, that inspector is not necessarily going to place
itself properly in the Morphic world. But it does seem to work, and
being able to do something like this before anything else gets screwed
up in the startUp processing might be a handy thing to be able to do.

Dave


On Fri, Jun 12, 2020 at 03:07:43PM -0700, tim Rowledge wrote:

Am I remembering right that you mentioned sometihng about disabling the readDocuments stuff?


tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Overdue for deincarnation.

On Fri, Jun 12, 2020 at 04:37:59PM -0700, tim Rowledge wrote:
> Am I remembering right that you mentioned sometihng about disabling the readDocuments stuff?
>

I had been thinking that it might be possible to do that, but I was
mistaken. The readDocumentAtStartup preference is still in place.

Unfortunately, what I *did* do is introduce a bug in #arguments when the
preference is disabled. It should be fixed now in System-dtl.1165.

If you have the preference disabled, you should now be able to do something
like this:

$ squeak squeak.image -evaluate '3 + 4'
7


Dave

Taking a quick look at the usages of getSystemAttribute: shows that we need some cleanup there, which ought to help make this doit etc work better.

There is a ridiculous assumption that the name of the document to load must be item 2, and that item 3 must be to do with Russian/Japanese language environment handling. Quite what one is supposed to do if no initial document is needed but Japanese is required...

If we could extend the parsing in DoItFIrst a little we ought to be able to work out whether there is a string intended as the name of a document and store it suitable. Modifying the SmalltalkImage>documentPath method suitably shouldn't be beyond our skills.

An interesting question is what to do about mixing these options. Obviously an `evaluate` will stop things at its end but  would it make any sense to allow

squeak vmOpt vmOp2 imagename -doit "Filename setWorkingDirectory:'/foo/bar'" documentToReadPathRelativeToCWD

with the expectation that it would start, set the cwd, then read the doc based on a path relative to the newly set cwd ?

Or even
{as above} -doit "do sometihng to the loaded document like maybe save under a new name"

And really, does anyone know what the expectation for those Russian/Japanese language environments are?
See JapaneseEnvironment class>>#inputInterpreterClass & RussianEnvironment class>>#inputInterpreterClass

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
My Go this  amn keyboar  oesn't have any  's.