Smalltalk › Squeak › Squeak - Dev

The Inbox: System-monty.907.mcz

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 6 messages Options
commits-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

The Inbox: System-monty.907.mcz

commits-2
A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-monty.907.mcz

==================== Summary ====================

Name: System-monty.907
Author: monty
Time: 22 January 2017, 10:54:27.872661 am
UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
Ancestors: System-mt.906

Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based) and breaks installation of the newer SqueakMap XMLParser. If MOFile really needs this, the applyLanguageInfomation: (sic) extension methods on String and ByteString should be moved out of the old XMLParser package and into those classes.

=============== Diff against System-mt.906 ===============

Item was changed:
  ----- Method: MOFile>>loadStrings:pointers:encoding:languageEnvironment: (in category 'private') -----
  loadStrings: strm pointers: tupple encoding: encodingName languageEnvironment: env
  | strings rawStr str offsetTable lenTable |
  offsetTable :=  tupple first.
  lenTable := tupple second.
  strings := Array new: nStrings.
  1 to: nStrings do: [:index |
  rawStr := self loadString: strm
  pointer:  (offsetTable at: index)
  length: (lenTable at: index).
  str := encodingName isNil ifTrue: [rawStr]
  ifFalse: [ encodingName = 'utf8'
+ ifTrue: [rawStr utf8ToSqueak]
- ifTrue: [rawStr utf8ToSqueak applyLanguageInfomation: env]
  ifFalse: [self error: 'this encoding isn''t supported']
  ].
  strings at: index put: str.
  ].
  ^strings.!

Item was changed:
  ----- Method: MOFile>>translatedString: (in category 'private') -----
  translatedString: index
  "KNOWN PROBLEM: conversion is executed everytimes this method called"
  | str |
  str := translatedStrings at: index.
 
+ ^str utf8ToSqueak.
- ^str utf8ToSqueak applyLanguageInfomation: (Locale localeID: localeID) languageEnvironment.
  !


Bert Freudenberg
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Inbox: System-monty.907.mcz

Bert Freudenberg
On Sun, Jan 22, 2017 at 4:55 PM, <[hidden email]> wrote:

Name: System-monty.907
Author: monty
Time: 22 January 2017, 10:54:27.872661 am
UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
Ancestors: System-mt.906

Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based)

Did we replace the leadingChar mechanism with something else?

- Bert - 
Tobias Pape
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Inbox: System-monty.907.mcz

Tobias Pape

On 24.01.2017, at 14:16, Bert Freudenberg <[hidden email]> wrote:

> On Sun, Jan 22, 2017 at 4:55 PM, <[hidden email]> wrote:
>
> Name: System-monty.907
> Author: monty
> Time: 22 January 2017, 10:54:27.872661 am
> UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
> Ancestors: System-mt.906
>
> Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based)
>
> Did we replace the leadingChar mechanism with something else?

not that I know.
Monty?

>
> - Bert -
>
>


monty-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Inbox: System-monty.907.mcz

monty-3
In reply to this post by commits-2
I remembered Andreas posting something here saying it was no longer needed. But what if I just upload packages that (1) add copies of these methods with the name spelled correctly to String and ByteString, (2) change the senders in MOFile and (old) XMLParser to use the new correctly spelled messages, (3) change the incorrectly spelled (old) XMLParser extension methods to just send the new, correctly spelled messages?

> Sent: Tuesday, January 24, 2017 at 9:32 AM
> From: "Tobias Pape" <[hidden email]>
> To: "The general-purpose Squeak developers list" <[hidden email]>, monty <[hidden email]>
> Subject: Re: [squeak-dev] The Inbox: System-monty.907.mcz
>
>
> On 24.01.2017, at 14:16, Bert Freudenberg <[hidden email]> wrote:
>
> > On Sun, Jan 22, 2017 at 4:55 PM, <[hidden email]> wrote:
> >
> > Name: System-monty.907
> > Author: monty
> > Time: 22 January 2017, 10:54:27.872661 am
> > UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
> > Ancestors: System-mt.906
> >
> > Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based)
> >
> > Did we replace the leadingChar mechanism with something else?
>
> not that I know.
> Monty?
>
> >
> > - Bert -
> >
> >
>
>

cbc
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Inbox: System-monty.907.mcz

cbc
So, back in 2009, Andreas proposed:

---------------------------
What I would propose to do here is to define that "leadingChar = 0" which currently means "Latin1 encoding, language neutral" is being redefined to "Unicode encoding, language neutral". What this does is that "Character value: 353" and "Unicode value: 353" become the same, if the environment is considered language neutral which by default it would be.
---------------------

In 2010, he pushed this into Squeak Trunk.

Then, in 2011, there was a conversation where Andreas stated:

-------------------
On 1/8/2011 2:16 AM, Sean P. DeNigris wrote:
#leadingChar
"In Squeak Character encoding, bits above 16r3FFFFF don't encode the
character, but hold information about the language environment and the
encoding which should be used to interpret the charCode. The background of

How's that as a method comment?  Is it really "In Squeak... encoding..." or
does this apply to unicode in general?

It is Squeak specific. Unicode does not have a leading char.

Cheers,
  - Andreas
---------------------

Maybe this later email was the one that you were interested in?

I can't find any mention in the commit list or other discussions where the leadingChar was dropped, but I'm not an expert in this space (just interested).

Thanks,
cbc


On Thu, Jan 26, 2017 at 10:02 AM, monty <[hidden email]> wrote:
I remembered Andreas posting something here saying it was no longer needed. But what if I just upload packages that (1) add copies of these methods with the name spelled correctly to String and ByteString, (2) change the senders in MOFile and (old) XMLParser to use the new correctly spelled messages, (3) change the incorrectly spelled (old) XMLParser extension methods to just send the new, correctly spelled messages?

> Sent: Tuesday, January 24, 2017 at 9:32 AM
> From: "Tobias Pape" <[hidden email]>
> To: "The general-purpose Squeak developers list" <[hidden email]>, monty <[hidden email]>
> Subject: Re: [squeak-dev] The Inbox: System-monty.907.mcz
>
>
> On 24.01.2017, at 14:16, Bert Freudenberg <[hidden email]> wrote:
>
> > On Sun, Jan 22, 2017 at 4:55 PM, <[hidden email]> wrote:
> >
> > Name: System-monty.907
> > Author: monty
> > Time: 22 January 2017, 10:54:27.872661 am
> > UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
> > Ancestors: System-mt.906
> >
> > Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based)
> >
> > Did we replace the leadingChar mechanism with something else?
>
> not that I know.
> Monty?
>
> >
> > - Bert -
> >
> >
>
>
monty-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Inbox: System-monty.907.mcz

monty-3
The '09 mail is the one I remembered. I thought Unicode supported obsoleted this, but apparently not.

> Sent: Thursday, January 26, 2017 at 5:36 PM
> From: "Chris Cunningham" <[hidden email]>
> To: "The general-purpose Squeak developers list" <[hidden email]>
> Subject: Re: [squeak-dev] The Inbox: System-monty.907.mcz
>
> So, back in 2009, Andreas proposed:
>  
> ---------------------------
> What I would propose to do here is to define that "leadingChar = 0" which currently means "Latin1 encoding, language neutral" is being redefined to "Unicode encoding, language neutral". What this does is that "Character value: 353" and "Unicode value: 353" become the same, if the environment is considered language neutral which by default it would be.
> ---------------------
>  
> In 2010, he pushed this into Squeak Trunk.
>  
> Then, in 2011, there was a conversation where Andreas stated:
>  
>
> -------------------
> On 1/8/2011 2:16 AM, Sean P. DeNigris wrote:
> #leadingChar
> "In Squeak Character encoding, bits above 16r3FFFFF don't encode the
> character, but hold information about the language environment and the
> encoding which should be used to interpret the charCode. The background of
> which is Han unification (http://en.wikipedia.org/wiki/Han_unification)."
>  
> How's that as a method comment?  Is it really "In Squeak... encoding..." or
> does this apply to unicode in general?
>  
> It is Squeak specific. Unicode does not have a leading char.
>  
> Cheers,
>   - Andreas
> ---------------------
>  
> Maybe this later email was the one that you were interested in?
>  
> I can't find any mention in the commit list or other discussions where the leadingChar was dropped, but I'm not an expert in this space (just interested).
>  
> Thanks,
> cbc
>  
>  
> On Thu, Jan 26, 2017 at 10:02 AM, monty <[hidden email][mailto:[hidden email]]> wrote:I remembered Andreas posting something here saying it was no longer needed. But what if I just upload packages that (1) add copies of these methods with the name spelled correctly to String and ByteString, (2) change the senders in MOFile and (old) XMLParser to use the new correctly spelled messages, (3) change the incorrectly spelled (old) XMLParser extension methods to just send the new, correctly spelled messages?
>
> > Sent: Tuesday, January 24, 2017 at 9:32 AM
> > From: "Tobias Pape" <[hidden email][mailto:[hidden email]]>
> > To: "The general-purpose Squeak developers list" <[hidden email][mailto:[hidden email]]>, monty <[hidden email][mailto:[hidden email]]>
> > Subject: Re: [squeak-dev] The Inbox: System-monty.907.mcz
>
> >
> >
> > On 24.01.2017, at 14:16, Bert Freudenberg <[hidden email][mailto:[hidden email]]> wrote:
> >
> > > On Sun, Jan 22, 2017 at 4:55 PM, <[hidden email][mailto:[hidden email]]> wrote:
> > >
> > > Name: System-monty.907
> > > Author: monty
> > > Time: 22 January 2017, 10:54:27.872661 am
> > > UUID: 96a2d0cb-8ed1-467d-9e62-24b719b285cc
> > > Ancestors: System-mt.906
> > >
> > > Removed sends of the old XMLParser's applyLanguageInfomation: (sic) from MOFile that I don't believe is still needed (it's leadingChar-based)
> > >
> > > Did we replace the leadingChar mechanism with something else?
> >
> > not that I know.
> > Monty?
> >
> > >
> > > - Bert -
> > >
> > >
> >
> >

Free forum by Nabble Edit this page