A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-tonyg.933.mcz ==================== Summary ==================== Name: System-tonyg.933 Author: tonyg Time: 16 March 2017, 12:26:12.343192 am UUID: 41dc870b-854c-4cab-8ba0-0a2368ead5d1 Ancestors: System-ul.932 Refactor SolarizedTheme to include darkSelectionColor and darkSelectionTextColor, and to call them as appropriate. =============== Diff against System-ul.932 =============== Item was changed: ----- Method: SolarizedTheme class>>addDarkMenusAndDockingBars: (in category 'instance creation') ----- addDarkMenusAndDockingBars: theme "self createDark apply." theme set: #borderWidth for: #MenuMorph to: 1; set: #borderColor for: #MenuMorph to: self darkBackgroundHighlights; set: #color for: #MenuMorph to: self darkBackground; set: #titleTextColor for: #MenuMorph to: self darkContentEmphasizedMore; set: #lineColor for: #MenuMorph to: self darkBackgroundHighlights; set: #lineStyle for: #MenuMorph to: BorderStyle default; set: #lineWidth for: #MenuMorph to: 1. theme set: #textColor for: #MenuItemMorph to: self darkContentEmphasized; set: #disabledTextColor for: #MenuItemMorph to: self darkContentSecondary; + set: #selectionColor for: #MenuItemMorph to: self darkSelectionColor; + set: #selectionTextColor for: #MenuItemMorph to: self darkSelectionTextColor. - set: #selectionColor for: #MenuItemMorph to: self darkBackgroundHighlights; - set: #selectionTextColor for: #MenuItemMorph to: self darkContentEmphasizedMore. "set: #subMenuMarker for: #MenuItemMorph to: nil." "Use hard-coded default. See MenuItemMorph." "The world main docking bar." theme set: #color for: #DockingBarMorph to: self darkBackgroundHighlights; set: #selectionColor for: #DockingBarItemMorph to: self darkContentSecondary; set: #logoColor for: #TheWorldMainDockingBar to: self darkContentEmphasized; set: #selectionLogoColor for: #TheWorldMainDockingBar to: self darkContentEmphasizedMore.! Item was changed: ----- Method: SolarizedTheme class>>addDarkScrollables: (in category 'instance creation') ----- addDarkScrollables: theme "self createDark apply." "Scroll bars" theme set: #thumbColor for: #ScrollBar to: self darkBackground; set: #thumbBorderColor for: #ScrollBar to: self darkBackground; set: #thumbBorderWidth for: #ScrollBar to: 1; set: #thumbColorModifier for: #ScrollBar to: [ [:c | c adjustBrightness: -0.1] ]; set: #pagingAreaColorModifier for: #ScrollBar to: [ [:c | Color transparent ] ]; set: #borderColorModifier for: #ScrollBar to: [ [:c | c adjustBrightness: -0.1] ]. "Scroll panes (includes generic stuff for list widgets, tree widgets, and text widgets." theme set: #borderWidth for: #ScrollPane to: 0; " set: #borderColor for: #ScrollPane to: Color transparent;" set: #color for: #ScrollPane to: self darkBackground. "List widgets" theme set: #textColor for: #PluggableListMorph to: self darkContentEmphasized; + set: #selectionColor for: #PluggableListMorph to: self darkSelectionColor; + set: #selectionTextColor for: #PluggableListMorph to: self darkSelectionTextColor; - set: #selectionColor for: #PluggableListMorph to: self darkBackgroundHighlights; - set: #selectionTextColor for: #PluggableListMorph to: self darkContentEmphasizedMore; set: #filterColor for: #PluggableListMorph to: self yellow; set: #filterTextColor for: #PluggableListMorph to: self base03; set: #preSelectionModifier for: #PluggableListMorph to: [ [:c | c lighter alpha: 0.5 ] ]; set: #hoverSelectionModifier for: #PluggableListMorph to: [ [:c | c lighter alpha: 0.5 ] ]. "Tree widgets" theme set: #highlightTextColor for: #SimpleHierarchicalListMorph to: self yellow lighter lighter; set: #lineColor for: #SimpleHierarchicalListMorph to: self darkContentSecondary. "Text widgets" theme set: #textColor for: #PluggableTextMorph to: self darkContentPrimary; set: #caretColor for: #PluggableTextMorph to: self darkContentEmphasizedMore; + set: #selectionColor for: #PluggableTextMorph to: self darkSelectionColor; - set: #selectionColor for: #PluggableTextMorph to: self darkBackgroundHighlights; set: #unfocusedSelectionModifier for: #PluggableTextMorph to: [ [:c | (Color r: 0.027 g: 0.211 b: 0.258) "dark background highlights"] ]; set: #adornmentReadOnly for: #PluggableTextMorph to: self magenta; set: #adornmentRefuse for: #PluggableTextMorph to: self cyan; set: #adornmentConflict for: #PluggableTextMorph to: self red; set: #adornmentDiff for: #PluggableTextMorph to: self green; set: #adornmentNormalEdit for: #PluggableTextMorph to: self orange; set: #adornmentDiffEdit for: #PluggableTextMorph to: self yellow. theme set: #balloonTextColor for: #PluggableTextMorphPlus to: self darkContentSecondary.! Item was added: + ----- Method: SolarizedTheme class>>darkSelectionColor (in category 'as yet unclassified') ----- + darkSelectionColor + ^ self base01! Item was added: + ----- Method: SolarizedTheme class>>darkSelectionTextColor (in category 'as yet unclassified') ----- + darkSelectionTextColor + ^ self base2! |
Selection is now clearly visible.
Could somebody please merge this? --Hannes On Thu, 16 Mar 2017 04:26:47 0000, [hidden email] <[hidden email]> wrote: > A new version of System was added to project The Inbox: > http://source.squeak.org/inbox/System-tonyg.933.mcz > > ==================== Summary ==================== > > Name: System-tonyg.933 > Author: tonyg > Time: 16 March 2017, 12:26:12.343192 am > UUID: 41dc870b-854c-4cab-8ba0-0a2368ead5d1 > Ancestors: System-ul.932 > > Refactor SolarizedTheme to include darkSelectionColor and > darkSelectionTextColor, and to call them as appropriate. > > =============== Diff against System-ul.932 =============== > > Item was changed: > ----- Method: SolarizedTheme class>>addDarkMenusAndDockingBars: (in > category 'instance creation') ----- > addDarkMenusAndDockingBars: theme > "self createDark apply." > theme > set: #borderWidth for: #MenuMorph to: 1; > set: #borderColor for: #MenuMorph to: self darkBackgroundHighlights; > set: #color for: #MenuMorph to: self darkBackground; > set: #titleTextColor for: #MenuMorph to: self darkContentEmphasizedMore; > set: #lineColor for: #MenuMorph to: self darkBackgroundHighlights; > set: #lineStyle for: #MenuMorph to: BorderStyle default; > set: #lineWidth for: #MenuMorph to: 1. > > theme > set: #textColor for: #MenuItemMorph to: self darkContentEmphasized; > set: #disabledTextColor for: #MenuItemMorph to: self > darkContentSecondary; > + set: #selectionColor for: #MenuItemMorph to: self darkSelectionColor; > + set: #selectionTextColor for: #MenuItemMorph to: self > darkSelectionTextColor. > - set: #selectionColor for: #MenuItemMorph to: self > darkBackgroundHighlights; > - set: #selectionTextColor for: #MenuItemMorph to: self > darkContentEmphasizedMore. > "set: #subMenuMarker for: #MenuItemMorph to: nil." "Use hard-coded > default. See MenuItemMorph." > > "The world main docking bar." > theme > set: #color for: #DockingBarMorph to: self darkBackgroundHighlights; > set: #selectionColor for: #DockingBarItemMorph to: self > darkContentSecondary; > set: #logoColor for: #TheWorldMainDockingBar to: self > darkContentEmphasized; > set: #selectionLogoColor for: #TheWorldMainDockingBar to: self > darkContentEmphasizedMore.! > > Item was changed: > ----- Method: SolarizedTheme class>>addDarkScrollables: (in category > 'instance creation') ----- > addDarkScrollables: theme > "self createDark apply." > > "Scroll bars" > theme > set: #thumbColor for: #ScrollBar to: self darkBackground; > set: #thumbBorderColor for: #ScrollBar to: self darkBackground; > set: #thumbBorderWidth for: #ScrollBar to: 1; > set: #thumbColorModifier for: #ScrollBar to: [ [:c | c adjustBrightness: > -0.1] ]; > set: #pagingAreaColorModifier for: #ScrollBar to: [ [:c | Color > transparent ] ]; > set: #borderColorModifier for: #ScrollBar to: [ [:c | c > adjustBrightness: -0.1] ]. > > "Scroll panes (includes generic stuff for list widgets, tree widgets, and > text widgets." > theme > set: #borderWidth for: #ScrollPane to: 0; > " set: #borderColor for: #ScrollPane to: Color transparent;" > set: #color for: #ScrollPane to: self darkBackground. > > "List widgets" > theme > set: #textColor for: #PluggableListMorph to: self darkContentEmphasized; > + set: #selectionColor for: #PluggableListMorph to: self > darkSelectionColor; > + set: #selectionTextColor for: #PluggableListMorph to: self > darkSelectionTextColor; > - set: #selectionColor for: #PluggableListMorph to: self > darkBackgroundHighlights; > - set: #selectionTextColor for: #PluggableListMorph to: self > darkContentEmphasizedMore; > set: #filterColor for: #PluggableListMorph to: self yellow; > set: #filterTextColor for: #PluggableListMorph to: self base03; > set: #preSelectionModifier for: #PluggableListMorph to: [ [:c | c > lighter alpha: 0.5 ] ]; > set: #hoverSelectionModifier for: #PluggableListMorph to: [ [:c | c > lighter alpha: 0.5 ] ]. > > "Tree widgets" > theme > set: #highlightTextColor for: #SimpleHierarchicalListMorph to: self > yellow lighter lighter; > set: #lineColor for: #SimpleHierarchicalListMorph to: self > darkContentSecondary. > > "Text widgets" > theme > set: #textColor for: #PluggableTextMorph to: self darkContentPrimary; > set: #caretColor for: #PluggableTextMorph to: self > darkContentEmphasizedMore; > + set: #selectionColor for: #PluggableTextMorph to: self > darkSelectionColor; > - set: #selectionColor for: #PluggableTextMorph to: self > darkBackgroundHighlights; > set: #unfocusedSelectionModifier for: #PluggableTextMorph to: [ [:c | > (Color r: 0.027 g: 0.211 b: 0.258) "dark background highlights"] ]; > set: #adornmentReadOnly for: #PluggableTextMorph to: self magenta; > set: #adornmentRefuse for: #PluggableTextMorph to: self cyan; > set: #adornmentConflict for: #PluggableTextMorph to: self red; > set: #adornmentDiff for: #PluggableTextMorph to: self green; > set: #adornmentNormalEdit for: #PluggableTextMorph to: self orange; > set: #adornmentDiffEdit for: #PluggableTextMorph to: self yellow. > theme > set: #balloonTextColor for: #PluggableTextMorphPlus to: self > darkContentSecondary.! > > Item was added: > + ----- Method: SolarizedTheme class>>darkSelectionColor (in category 'as > yet unclassified') ----- > + darkSelectionColor > + ^ self base01! > > Item was added: > + ----- Method: SolarizedTheme class>>darkSelectionTextColor (in category > 'as yet unclassified') ----- > + darkSelectionTextColor > + ^ self base2! > > > SolarizedTheme_change_tonyg.933_2017-03-16.png (333K) Download Attachment |
On Thu, Mar 16, 2017 at 11:48 AM, H. Hirzel <[hidden email]> wrote: Selection is now clearly visible. I definitely like the list selection color (highlight/text color) - definitely readable and clear. Worth merging. Now if you could just do the same magic with text select in text panes - still not able to tell what is highlighted. ("Hey" is highlighted in this example) -cbc |
On 03/16/2017 05:23 PM, Chris Cunningham wrote:
> Now if you could just do the same magic with text select in text panes - > still not able to tell what is highlighted. > > Inline image 1 > ("Hey" is highlighted in this example) Oops! Missed the unfocussed-window case. System-tonyg.935 takes care of it. Thanks for the feedback, Chris. Tony |
Free forum by Nabble | Edit this page |