The Inbox: Tests-ct.426.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tests-ct.426.mcz

commits-2
Christoph Thiede uploaded a new version of Tests to project The Inbox:
http://source.squeak.org/inbox/Tests-ct.426.mcz

==================== Summary ====================

Name: Tests-ct.426
Author: ct
Time: 6 February 2020, 6:58:06.300648 pm
UUID: 2a0d3e63-9e48-5040-a1af-145fa43c9695
Ancestors: Tests-mt.424

Tests load and unload order of MCScriptDefinitions

This is currently not working properly, see http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-late-tp5108401.html. Fix is coming very soon!

=============== Diff against Tests-mt.424 ===============

Item was changed:
  SystemOrganization addCategory: #'Tests-Bugs'!
  SystemOrganization addCategory: #'Tests-Compiler'!
  SystemOrganization addCategory: #'Tests-Dependencies'!
  SystemOrganization addCategory: #'Tests-Digital Signatures'!
  SystemOrganization addCategory: #'Tests-Environments'!
  SystemOrganization addCategory: #'Tests-Exceptions'!
  SystemOrganization addCategory: #'Tests-FilePackage'!
  SystemOrganization addCategory: #'Tests-Files'!
  SystemOrganization addCategory: #'Tests-Finalization'!
  SystemOrganization addCategory: #'Tests-Hex'!
  SystemOrganization addCategory: #'Tests-Installer-Core'!
  SystemOrganization addCategory: #'Tests-Localization'!
  SystemOrganization addCategory: #'Tests-Monticello'!
  SystemOrganization addCategory: #'Tests-Monticello-Mocks'!
  SystemOrganization addCategory: #'Tests-Monticello-Utils'!
  SystemOrganization addCategory: #'Tests-Object Events'!
  SystemOrganization addCategory: #'Tests-ObjectsAsMethods'!
  SystemOrganization addCategory: #'Tests-PrimCallController'!
  SystemOrganization addCategory: #'Tests-Release'!
  SystemOrganization addCategory: #'Tests-System-Applications'!
  SystemOrganization addCategory: #'Tests-System-Digital Signatures'!
  SystemOrganization addCategory: #'Tests-System-Object Storage'!
  SystemOrganization addCategory: #'Tests-System-Preferences'!
  SystemOrganization addCategory: #'Tests-System-Support'!
  SystemOrganization addCategory: #'Tests-Utilities'!
  SystemOrganization addCategory: #'Tests-VM'!
+ SystemOrganization addCategory: #'Tests-MonticelloMocks'!

Item was added:
+ ----- Method: MCPackageTest>>testLoadOrder (in category 'tests') -----
+ testLoadOrder
+
+ | snapshot loader additions |
+ snapshot := MCMockPackageInfo new mcPackage snapshot.
+ loader := MCPackageLoader new.
+ loader installSnapshot: snapshot.
+ loader analyze.
+ additions := loader instVarNamed: #additions.
+ self assert: [(additions findLast: [:ea | ea isKindOf: MCPreambleDefinition])
+ < (additions findFirst: [:ea | ea isClassDefinition])].
+ self assert: [(additions findFirst: [:ea | ea isKindOf: MCPostscriptDefinition])
+ > (additions findLast: [:ea | ea isClassDefinition])].!

Item was added:
+ ----- Method: MCPackageTest>>testUnloadOrder (in category 'tests') -----
+ testUnloadOrder
+
+ | package loader removals |
+ package := MCMockPackageInfo new mcPackage.
+ loader := MCPackageLoader new.
+ loader unloadPackage: package.
+ loader analyze.
+ removals := loader instVarNamed: #removals.
+ self assert: [(removals findLast: [:ea | ea isKindOf: MCRemovalPreambleDefinition])
+ < (removals findFirst: [:ea | ea isClassDefinition])].
+ self assert: [(removals findFirst: [:ea | ea isKindOf: MCRemovalPostscriptDefinition])
+ > (removals findLast: [:ea | ea isClassDefinition])].!

Item was changed:
  ----- Method: MCWorkingCopyRenameTest>>mockPackage (in category 'running') -----
  mockPackage
 
+ ^MCPackage named: self mockCategoryName!
- ^MCPackage new name: self mockCategoryName!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tests-ct.426.mcz

Christoph Thiede

Oops, the system organization should not have been changed. Some of the tests might have failed to tear something down?


Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 6. Februar 2020 18:58:09
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Tests-ct.426.mcz
 
Christoph Thiede uploaded a new version of Tests to project The Inbox:
http://source.squeak.org/inbox/Tests-ct.426.mcz

==================== Summary ====================

Name: Tests-ct.426
Author: ct
Time: 6 February 2020, 6:58:06.300648 pm
UUID: 2a0d3e63-9e48-5040-a1af-145fa43c9695
Ancestors: Tests-mt.424

Tests load and unload order of MCScriptDefinitions

This is currently not working properly, see http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-late-tp5108401.html. Fix is coming very soon!

=============== Diff against Tests-mt.424 ===============

Item was changed:
  SystemOrganization addCategory: #'Tests-Bugs'!
  SystemOrganization addCategory: #'Tests-Compiler'!
  SystemOrganization addCategory: #'Tests-Dependencies'!
  SystemOrganization addCategory: #'Tests-Digital Signatures'!
  SystemOrganization addCategory: #'Tests-Environments'!
  SystemOrganization addCategory: #'Tests-Exceptions'!
  SystemOrganization addCategory: #'Tests-FilePackage'!
  SystemOrganization addCategory: #'Tests-Files'!
  SystemOrganization addCategory: #'Tests-Finalization'!
  SystemOrganization addCategory: #'Tests-Hex'!
  SystemOrganization addCategory: #'Tests-Installer-Core'!
  SystemOrganization addCategory: #'Tests-Localization'!
  SystemOrganization addCategory: #'Tests-Monticello'!
  SystemOrganization addCategory: #'Tests-Monticello-Mocks'!
  SystemOrganization addCategory: #'Tests-Monticello-Utils'!
  SystemOrganization addCategory: #'Tests-Object Events'!
  SystemOrganization addCategory: #'Tests-ObjectsAsMethods'!
  SystemOrganization addCategory: #'Tests-PrimCallController'!
  SystemOrganization addCategory: #'Tests-Release'!
  SystemOrganization addCategory: #'Tests-System-Applications'!
  SystemOrganization addCategory: #'Tests-System-Digital Signatures'!
  SystemOrganization addCategory: #'Tests-System-Object Storage'!
  SystemOrganization addCategory: #'Tests-System-Preferences'!
  SystemOrganization addCategory: #'Tests-System-Support'!
  SystemOrganization addCategory: #'Tests-Utilities'!
  SystemOrganization addCategory: #'Tests-VM'!
+ SystemOrganization addCategory: #'Tests-MonticelloMocks'!

Item was added:
+ ----- Method: MCPackageTest>>testLoadOrder (in category 'tests') -----
+ testLoadOrder
+
+        | snapshot loader additions |
+        snapshot := MCMockPackageInfo new mcPackage snapshot.
+        loader := MCPackageLoader new.
+        loader installSnapshot: snapshot.
+        loader analyze.
+        additions := loader instVarNamed: #additions.
+        self assert: [(additions findLast: [:ea | ea isKindOf: MCPreambleDefinition])
+                < (additions findFirst: [:ea | ea isClassDefinition])].
+        self assert: [(additions findFirst: [:ea | ea isKindOf: MCPostscriptDefinition])
+                > (additions findLast: [:ea | ea isClassDefinition])].!

Item was added:
+ ----- Method: MCPackageTest>>testUnloadOrder (in category 'tests') -----
+ testUnloadOrder
+
+        | package loader removals |
+        package := MCMockPackageInfo new mcPackage.
+        loader := MCPackageLoader new.
+        loader unloadPackage: package.
+        loader analyze.
+        removals := loader instVarNamed: #removals.
+        self assert: [(removals findLast: [:ea | ea isKindOf: MCRemovalPreambleDefinition])
+                < (removals findFirst: [:ea | ea isClassDefinition])].
+        self assert: [(removals findFirst: [:ea | ea isKindOf: MCRemovalPostscriptDefinition])
+                > (removals findLast: [:ea | ea isClassDefinition])].!

Item was changed:
  ----- Method: MCWorkingCopyRenameTest>>mockPackage (in category 'running') -----
  mockPackage
 
+        ^MCPackage named: self mockCategoryName!
-        ^MCPackage new name: self mockCategoryName!




Carpe Squeak!