The Inbox: Tests-ul.164.mcz

A new version of Tests was added to project The Inbox:
http://source.squeak.org/inbox/Tests-ul.164.mcz

==================== Summary ====================

Name: Tests-ul.164
Author: ul
Time: 14 September 2012, 2:20:59.642 pm
UUID: 9431f253-54c9-8144-9de4-17230f13fc9f
Ancestors: Tests-ul.163

Fixing Monticello tests:
- restore #packageName for MCMockPackageInfo, MCEmptyPackageInfo, MCDirtyPackageInfo
- re-register these PackageInfos in postscript
- renamed the virtual #systemCategory of MCMockPackageInfo to Tests-MonticelloMocks, so the extension method MCSnapshotTest >> #mockClassExtension can be in the Tests package instead of Monticello

MCMethodDefinitionTest enhancements:
- updated #ownPackage, because it's Tests now
- save and restore the timestamp of #override
- remove the empty system category and the workingCopy of the mock package after the tests

These changes break MCWorkingCopyTest's #testRenamePrefix and #testRenameSuffix and some of  tests in MCSnapshotBrowserTest.

=============== Diff against Tests-ul.163 ===============

Item was removed:
- ----- Method: MCDirtyPackageInfo class>>packageName (in category 'as yet unclassified') -----
- packageName
- ^ 'MCDirtyPackage'!

Item was added:
+ ----- Method: MCDirtyPackageInfo>>packageName (in category 'as yet unclassified') -----
+ packageName
+ ^ 'MCDirtyPackage'!

Item was removed:
- ----- Method: MCEmptyPackageInfo class>>packageName (in category 'as yet unclassified') -----
- packageName
- ^ 'MCEmptyPackage'!

Item was added:
+ ----- Method: MCEmptyPackageInfo>>packageName (in category 'as yet unclassified') -----
+ packageName
+ ^ 'MCEmptyPackage'!

Item was changed:
  MCTestCase subclass: #MCMethodDefinitionTest
+ instanceVariableNames: 'navigation isModified overrideTimestamp'
- instanceVariableNames: 'navigation isModified'
  classVariableNames: ''
  poolDictionaries: ''
  category: 'Tests-Monticello'!

Item was changed:
  ----- Method: MCMethodDefinitionTest>>ownPackage (in category 'running') -----
  ownPackage
+ ^ MCWorkingCopy forPackage: (MCPackage named: 'Tests')!
- ^ MCWorkingCopy forPackage: (MCPackage named: 'Monticello')!

Item was changed:
  ----- Method: MCMethodDefinitionTest>>setUp (in category 'running') -----
  setUp
+
  navigation := (Smalltalk hasClassNamed: #SystemNavigation)
  ifTrue: [(Smalltalk at: #SystemNavigation) new]
  ifFalse: [Smalltalk].
+ isModified := self ownPackage modified.
+ overrideTimestamp := (self class >> #override) timeStamp!
- isModified := self ownPackage modified.!

Item was changed:
  ----- Method: MCMethodDefinitionTest>>tearDown (in category 'running') -----
  tearDown
 
- super tearDown.
  self restoreMocks.
  (MCWorkingCopy forPackage: (MCPackage named: 'FooBarBaz')) unregister.
+ MCMockPackageInfo new mcPackage workingCopy unregister.
+ self class
+ compile: 'override ^ 1'
+ classified: 'mocks'
+ withStamp: overrideTimestamp
+ notifying: nil.
+ SystemOrganizer default removeEmptyCategories.
- self class compile: 'override ^ 1' classified: 'mocks'.
  self ownPackage modified: isModified.
+ super tearDown
  !

Item was removed:
- ----- Method: MCMockPackageInfo class>>packageName (in category 'as yet unclassified') -----
- packageName
- ^ 'MonticelloMocks'!

Item was added:
+ ----- Method: MCMockPackageInfo>>packageName (in category 'as yet unclassified') -----
+ packageName
+ ^ 'MonticelloMocks'!

Item was changed:
  ----- Method: MCMockPackageInfo>>systemCategories (in category 'as yet unclassified') -----
  systemCategories
+ ^ Array with: 'Tests-MonticelloMocks'!
- ^ Array with: 'Monticello-Mocks'!

Item was changed:
+ ----- Method: MCSnapshotTest>>mockClassExtension (in category '*Tests-MonticelloMocks') -----
- ----- Method: MCSnapshotTest>>mockClassExtension (in category '*Tests-Monticello-Mocks') -----
  mockClassExtension!

Item was changed:
  ----- Method: MCStWriterTest>>expectedOrganizationDefinition (in category 'data') -----
  expectedOrganizationDefinition
+ ^ 'SystemOrganization addCategory: ''Tests-MonticelloMocks''!!
- ^ 'SystemOrganization addCategory: ''Monticello-Mocks''!!
  '!

Item was added:
+ ----- Method: MCStWriterTest>>tearDown (in category 'testing') -----
+ tearDown
+
+ SystemOrganizer default removeEmptyCategories.
+ super tearDown !

Item was added:
+ (PackageInfo named: 'Tests') postscript: 'PackageOrganizer default unregisterPackageNamed: ''Test-Monticello-Mocks''.
+ { MCMockPackageInfo. MCEmptyPackageInfo. MCDirtyPackageInfo } do: [ :each |
+ each initialize ]
+ '!