The Inbox: ToolBuilder-Kernel-nice.142.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: ToolBuilder-Kernel-nice.142.mcz

commits-2
Nicolas Cellier uploaded a new version of ToolBuilder-Kernel to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Kernel-nice.142.mcz

==================== Summary ====================

Name: ToolBuilder-Kernel-nice.142
Author: nice
Time: 23 April 2021, 11:06:34.400228 am
UUID: 93216f25-69b2-43c3-b355-36a28cfd3588
Ancestors: ToolBuilder-Kernel-nice.141

Attempt to allow nested sendNotificationsTo: handling.
Requires Kernel-nice.1391.

The idea is that the handler shall not be active during the handlerAction. But still, we want he inner handlers to be active as was the case with former exception handling.

Please write TestCase documenting expectations and review if this can possibly fit.

=============== Diff against ToolBuilder-Kernel-nice.141 ===============

Item was changed:
  ----- Method: ProgressInitiationException>>sendNotificationsTo: (in category 'initialize-release') -----
  sendNotificationsTo: aNewBlock
+ | val |
+ "Reactivate inner handlers so as to let them handle other exceptions"
+ self
+ reactivateHandlersWhich: [:aHandlerContext | (aHandlerContext willHandleSignal: self) not]
+ upTo: handlerContext.
+ val := workBlock value: [ :barVal |
-
- self reactivateHandlers; resumeUnchecked: (
- workBlock value: [ :barVal |
  aNewBlock value: minVal value: maxVal value: barVal
+ ].
+ handlerContext ifNotNil: [handlerContext reactivateHandler].
+ self resumeUnchecked: val
- ]
- )
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: ToolBuilder-Kernel-nice.142.mcz

Jakob Reschke
Hi Nicolas,

I got a MessageNotUnderstood with this one. Replaced the first self
with thisContext nextHandlerContext to get around it.

See ToolBuilder-Tests-jr.6 for a test case of what I would expect. It
fails with and without this version ToolBuilder-Kernel-nice.142.

Kind regards,
Jakob

Am Fr., 23. Apr. 2021 um 11:06 Uhr schrieb <[hidden email]>:

>
> Nicolas Cellier uploaded a new version of ToolBuilder-Kernel to project The Inbox:
> http://source.squeak.org/inbox/ToolBuilder-Kernel-nice.142.mcz
>
> ==================== Summary ====================
>
> Name: ToolBuilder-Kernel-nice.142
> Author: nice
> Time: 23 April 2021, 11:06:34.400228 am
> UUID: 93216f25-69b2-43c3-b355-36a28cfd3588
> Ancestors: ToolBuilder-Kernel-nice.141
>
> Attempt to allow nested sendNotificationsTo: handling.
> Requires Kernel-nice.1391.
>
> The idea is that the handler shall not be active during the handlerAction. But still, we want he inner handlers to be active as was the case with former exception handling.
>
> Please write TestCase documenting expectations and review if this can possibly fit.
>
> =============== Diff against ToolBuilder-Kernel-nice.141 ===============
>
> Item was changed:
>   ----- Method: ProgressInitiationException>>sendNotificationsTo: (in category 'initialize-release') -----
>   sendNotificationsTo: aNewBlock
> +       | val |
> +       "Reactivate inner handlers so as to let them handle other exceptions"
> +       self
> +               reactivateHandlersWhich: [:aHandlerContext | (aHandlerContext willHandleSignal: self) not]
> +               upTo: handlerContext.
> +       val := workBlock value: [ :barVal |
> -
> -       self reactivateHandlers; resumeUnchecked: (
> -               workBlock value: [ :barVal |
>                         aNewBlock value: minVal value: maxVal value: barVal
> +               ].
> +       handlerContext ifNotNil: [handlerContext reactivateHandler].
> +       self resumeUnchecked: val
> -               ]
> -       )
>   !
>
>