Smalltalk › Squeak › Squeak - Dev

The Inbox: ToolBuilder-Kernel-tpr.135.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: ToolBuilder-Kernel-tpr.135.mcz

A new version of ToolBuilder-Kernel was added to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Kernel-tpr.135.mcz

==================== Summary ====================

Name: ToolBuilder-Kernel-tpr.135
Author: tpr
Time: 31 December 2019, 1:38:05.296265 pm
UUID: 85fb4bde-73a1-4dde-b7c2-bec1821f90eb
Ancestors: ToolBuilder-Kernel-mt.134

change the default position for progress bars to slightly below the center of the screen. This should at least help with cases where a notifier/conformer/informer pops up during a large package load and gets hidden behind the progress bar morph.
The Rectangle method should probably be moved back to Graphics-Primitives but by including it here we can avoid the potential for a dNU whilst loading this.

=============== Diff against ToolBuilder-Kernel-mt.134 ===============

Item was changed:
----- Method: ProgressInitiationException class>>preferredProgressBarPosition (in category 'accessing') -----
preferredProgressBarPosition
+ ^ PreferredProgressBarPosition ifNil: [ #belowCenter ]!
- ^ PreferredProgressBarPosition ifNil: [ #center ]!

Item was added:
+ ----- Method: Rectangle>>belowCenter (in category '*ToolBuilder-Kernel-accessing') -----
+ belowCenter
+ "Answer the point slightly below the center of the receiver. This is a good candidate spot for progress morphs to default to since it leaves room to see any other dialogues that default to screen center"
+
+ ^self topLeft + self bottomRight // (2@1.7)!

marcel.taeumel

Re: The Inbox: ToolBuilder-Kernel-tpr.135.mcz

Uh ... not sure about this one. You try to manage two (or more) elements on a screen here. Sounds like a job for a (mediating) owner's layout policy. This proposal sounds rather brittle for the intended effect.

We should tackle this issue of overlapping pop-up stuff after the 5.3 release.

Best,

Marcel

Am 31.12.2019 22:38:14 schrieb [hidden email] <[hidden email]>:
A new version of ToolBuilder-Kernel was added to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Kernel-tpr.135.mcz

==================== Summary ====================

Name: ToolBuilder-Kernel-tpr.135
Author: tpr
Time: 31 December 2019, 1:38:05.296265 pm
UUID: 85fb4bde-73a1-4dde-b7c2-bec1821f90eb
Ancestors: ToolBuilder-Kernel-mt.134

change the default position for progress bars to slightly below the center of the screen. This should at least help with cases where a notifier/conformer/informer pops up during a large package load and gets hidden behind the progress bar morph.
The Rectangle method should probably be moved back to Graphics-Primitives but by including it here we can avoid the potential for a dNU whilst loading this.

=============== Diff against ToolBuilder-Kernel-mt.134 ===============

Item was changed:
----- Method: ProgressInitiationException class>>preferredProgressBarPosition (in category 'accessing') -----
preferredProgressBarPosition
+ ^ PreferredProgressBarPosition ifNil: [ #belowCenter ]!
- ^ PreferredProgressBarPosition ifNil: [ #center ]!

Item was added:
+ ----- Method: Rectangle>>belowCenter (in category '*ToolBuilder-Kernel-accessing') -----
+ belowCenter
+ "Answer the point slightly below the center of the receiver. This is a good candidate spot for progress morphs to default to since it leaves room to see any other dialogues that default to screen center"
+
+ ^self topLeft + self bottomRight // (2@1.7)!