Smalltalk › Squeak › Squeak - Dev

The Inbox: ToolBuilder-Morphic-ct.253.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: ToolBuilder-Morphic-ct.253.mcz

Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.253.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.253
Author: ct
Time: 24 January 2020, 9:27:31.738262 pm
UUID: e0810ef0-e633-2047-bdda-a69a7c14f9a9
Ancestors: ToolBuilder-Morphic-mt.251

Fix a regression in ListMultipleChooser that led to missing invalidations of the PluggableListMorphOfMany. Probably introduced by the recent refactoring of list morphs.

To reproduce, run the following snippet and select multiple items (but don't move the cursor after clicking):

Project uiManager chooseMultipleFrom: #(foo bar)

Only the first selection event triggered a #change before.

=============== Diff against ToolBuilder-Morphic-mt.251 ===============

Item was changed:
----- Method: ListMultipleChooser>>selectionAt:put: (in category 'accessing') -----
selectionAt: index put: boolean

self selection at: index put: boolean.
+ self changed: #selectionAt:!
- self changed: #selectedIndex!

Christoph Thiede

[5.3?] The Inbox: ToolBuilder-Morphic-ct.253.mcz

This one is really simple and fixes an annoying regression. Good enough for 5.3? :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Freitag, 24. Januar 2020 21:27 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: ToolBuilder-Morphic-ct.253.mcz

Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.253.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.253
Author: ct
Time: 24 January 2020, 9:27:31.738262 pm
UUID: e0810ef0-e633-2047-bdda-a69a7c14f9a9
Ancestors: ToolBuilder-Morphic-mt.251

Fix a regression in ListMultipleChooser that led to missing invalidations of the PluggableListMorphOfMany. Probably introduced by the recent refactoring of list morphs.

To reproduce, run the following snippet and select multiple items (but don't move the cursor after clicking):

        Project uiManager chooseMultipleFrom: #(foo bar)

Only the first selection event triggered a #change before.

=============== Diff against ToolBuilder-Morphic-mt.251 ===============

Item was changed:
----- Method: ListMultipleChooser>>selectionAt:put: (in category 'accessing') -----
selectionAt: index put: boolean

         self selection at: index put: boolean.
+        self changed: #selectionAt:!
-        self changed: #selectedIndex!

Carpe Squeak!