The Inbox: Tools-cmm.928.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-cmm.928.mcz

commits-2
Chris Muller uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-cmm.928.mcz

==================== Summary ====================

Name: Tools-cmm.928
Author: cmm
Time: 20 December 2019, 10:06:10.77308 pm
UUID: e1a28262-590a-443a-83d8-6e994b0f676b
Ancestors: Tools-mt.925

Fix DictionaryInspector to allow debugging of Dictionary initialization, and render the entries in order for OrderedDictionary's.

=============== Diff against Tools-mt.925 ===============

Item was changed:
  ----- Method: DictionaryInspector>>calculateKeyArray (in category 'selecting') -----
  calculateKeyArray
+ "Recalculate the KeyArray from the object being inspected."
+ keyArray := [ object keysInOrder ] ifError:
+ [ "Can occur when debugging Dictionary new"
+ Array empty ].
+ selectionIndex := 0!
- "Recalculate the KeyArray from the object being inspected"
-
- keyArray := object keysSortedSafely asArray.
- selectionIndex := 0.
- !


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-cmm.928.mcz

Chris Muller-3
Thanks for the idea.  Even though #isInitialized was in Tools, we always have Tools loaded, so it would still have been occupying the methods list.  The tools should bend over backward to let the class library be as clean as it can be.

I liked the idea to put an error message in there, but was not quite right for this case, though.  If you try it, you'll see why Array empty is the right choice.   :)

 - Chris

On Fri, Dec 20, 2019 at 10:06 PM <[hidden email]> wrote:
Chris Muller uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-cmm.928.mcz

==================== Summary ====================

Name: Tools-cmm.928
Author: cmm
Time: 20 December 2019, 10:06:10.77308 pm
UUID: e1a28262-590a-443a-83d8-6e994b0f676b
Ancestors: Tools-mt.925

Fix DictionaryInspector to allow debugging of Dictionary initialization, and render the entries in order for OrderedDictionary's.

=============== Diff against Tools-mt.925 ===============

Item was changed:
  ----- Method: DictionaryInspector>>calculateKeyArray (in category 'selecting') -----
  calculateKeyArray
+       "Recalculate the KeyArray from the object being inspected."
+       keyArray := [ object keysInOrder ] ifError:
+               [ "Can occur when debugging Dictionary new"
+               Array empty ].
+       selectionIndex := 0!
-       "Recalculate the KeyArray from the object being inspected"
-
-       keyArray := object keysSortedSafely asArray.
-       selectionIndex := 0.
- !




Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-cmm.928.mcz

marcel.taeumel
+1 :-)

Best,
Marcel

Am 21.12.2019 05:13:06 schrieb Chris Muller <[hidden email]>:

Thanks for the idea.  Even though #isInitialized was in Tools, we always have Tools loaded, so it would still have been occupying the methods list.  The tools should bend over backward to let the class library be as clean as it can be.

I liked the idea to put an error message in there, but was not quite right for this case, though.  If you try it, you'll see why Array empty is the right choice.   :)

 - Chris

On Fri, Dec 20, 2019 at 10:06 PM <[hidden email]> wrote:
Chris Muller uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-cmm.928.mcz

==================== Summary ====================

Name: Tools-cmm.928
Author: cmm
Time: 20 December 2019, 10:06:10.77308 pm
UUID: e1a28262-590a-443a-83d8-6e994b0f676b
Ancestors: Tools-mt.925

Fix DictionaryInspector to allow debugging of Dictionary initialization, and render the entries in order for OrderedDictionary's.

=============== Diff against Tools-mt.925 ===============

Item was changed:
  ----- Method: DictionaryInspector>>calculateKeyArray (in category 'selecting') -----
  calculateKeyArray
+       "Recalculate the KeyArray from the object being inspected."
+       keyArray := [ object keysInOrder ] ifError:
+               [ "Can occur when debugging Dictionary new"
+               Array empty ].
+       selectionIndex := 0!
-       "Recalculate the KeyArray from the object being inspected"
-
-       keyArray := object keysSortedSafely asArray.
-       selectionIndex := 0.
- !