Smalltalk › Squeak › Squeak - Dev

The Inbox: Tools-ct.878.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: Tools-ct.878.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.878.mcz

==================== Summary ====================

Name: Tools-ct.878
Author: ct
Time: 14 August 2019, 11:23:27.6824 pm
UUID: 2f78c021-5d26-6c44-a909-617d47a1f602
Ancestors: Tools-mt.877

Respect styling in #spawn:

Depends on ToolBuilder-Kernel-ct.130 & ToolBuilder-Morphic-ct.237

=============== Diff against Tools-mt.877 ===============

Item was changed:
----- Method: SearchBar>>spawn: (in category '*Tools') -----
spawn: contentsString

+ UIManager default edit: contentsString label: nil shouldStyle: true!
- UIManager default edit: contentsString label: 'Workspace'!

Item was changed:
----- Method: StringHolder>>spawn: (in category '*Tools') -----
spawn: contentsString

+ UIManager default edit: contentsString label: 'Workspace' shouldStyle: self shouldStyle
- UIManager default edit: contentsString label: 'Workspace'
!

marcel.taeumel

Re: The Inbox: Tools-ct.878.mcz

Hi, Christoph.

-1 :-)

There is the preference "Workspace shouldStyle" which might better fit the default implementation in StringHolder. Only Workspace implements #shouldStyle. This preference is also better than forcing to style out of a SearchBar.

Best,

Marcel

Am 14.08.2019 23:23:38 schrieb [hidden email] <[hidden email]>:
A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.878.mcz

==================== Summary ====================

Name: Tools-ct.878
Author: ct
Time: 14 August 2019, 11:23:27.6824 pm
UUID: 2f78c021-5d26-6c44-a909-617d47a1f602
Ancestors: Tools-mt.877

Respect styling in #spawn:

Depends on ToolBuilder-Kernel-ct.130 & ToolBuilder-Morphic-ct.237

=============== Diff against Tools-mt.877 ===============

Item was changed:
----- Method: SearchBar>>spawn: (in category '*Tools') -----
spawn: contentsString

+ UIManager default edit: contentsString label: nil shouldStyle: true!
- UIManager default edit: contentsString label: 'Workspace'!

Item was changed:
----- Method: StringHolder>>spawn: (in category '*Tools') -----
spawn: contentsString

+ UIManager default edit: contentsString label: 'Workspace' shouldStyle: self shouldStyle
- UIManager default edit: contentsString label: 'Workspace'
!