Smalltalk › Squeak › Squeak - Dev

The Inbox: Tools-ct.916.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: Tools-ct.916.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.916.mcz

==================== Summary ====================

Name: Tools-ct.916
Author: ct
Time: 15 November 2019, 7:00:12.771005 pm
UUID: 05c08fc9-78c5-ea45-842e-dfc847d32551
Ancestors: Tools-mt.914

VersionsBrowser>>#selectMethod:: Compare not only timeStamp, but also source, as timeStamp is only minute-precise.

=============== Diff against Tools-mt.914 ===============

Item was changed:
----- Method: VersionsBrowser>>selectMethod: (in category 'menu') -----
selectMethod: aCompiledMethod

self toggleListIndex: (self changeList indexOf: (
+ self changeList detect: [:change |
+ change stamp = aCompiledMethod timeStamp and: [
+ change string = aCompiledMethod getSource asString]]))!
- self changeList detect: [:change | change stamp = aCompiledMethod timeStamp]))!

Christoph Thiede

Re: The Inbox: Tools-ct.916.mcz

By the way: I find it kind of weird that timestamps still are only available as a string, afaik there is no interface to directly get authorInitials, a TimeStamp (magnitude!) or other information. Has this been a conscious design decision or rather evolved over time? It would also be great to store an exact timestamp, as this commit shows, we would not even need to display the full accuracy to the user ... :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Freitag, 15. November 2019 19:00:17
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Tools-ct.916.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.916.mcz

==================== Summary ====================

Name: Tools-ct.916
Author: ct
Time: 15 November 2019, 7:00:12.771005 pm
UUID: 05c08fc9-78c5-ea45-842e-dfc847d32551
Ancestors: Tools-mt.914

VersionsBrowser>>#selectMethod:: Compare not only timeStamp, but also source, as timeStamp is only minute-precise.

=============== Diff against Tools-mt.914 ===============

Item was changed:
----- Method: VersionsBrowser>>selectMethod: (in category 'menu') -----
selectMethod: aCompiledMethod

         self toggleListIndex: (self changeList indexOf: (
+                self changeList detect: [:change |
+                        change stamp = aCompiledMethod timeStamp and: [
+                                change string = aCompiledMethod getSource asString]]))!
-                self changeList detect: [:change | change stamp = aCompiledMethod timeStamp]))!

Carpe Squeak!