The Inbox: Tools-fbs.222.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-fbs.222.mcz

==================== Summary ====================

Name: Tools-fbs.222
Author: fbs
Time: 3 April 2010, 10:30:16.057 am
UUID: 371c0e05-adce-014c-a50d-ea6a7a973ca4
Ancestors: Tools-bp.220

Update Hierarchy Browser with fixed button height.

=============== Diff against Tools-bp.220 ===============

Item was changed:
  ----- Method: Browser>>switchesFrame: (in category 'initialize-release') -----
  switchesFrame: bottomFraction
+ ^self switchesFrame: bottomFraction width: 0.25.!
- ^LayoutFrame new
- leftFraction: 0.25 offset: 0;
- topFraction: bottomFraction offset: self buttonHeight negated - 4;
- rightFraction: 0.5 offset: 0;
- bottomFraction: bottomFraction offset: 0!

Item was added:
+ ----- Method: Browser>>classListFrame:fromLeft:width: (in category 'initialize-release') -----
+ classListFrame: bottomFraction fromLeft: leftFraction width: rightFraction
+ ^LayoutFrame new
+ leftFraction: leftFraction offset: 0;
+ topFraction: 0 offset: 0;
+ rightFraction: (leftFraction + rightFraction) offset: 0;
+ bottomFraction: bottomFraction offset: self buttonHeight negated - 3!

Item was changed:
  ----- Method: Browser>>classListFrame: (in category 'initialize-release') -----
  classListFrame: bottomFraction
+ ^self classListFrame: bottomFraction fromLeft: 0.25 width: 0.25.!
- ^LayoutFrame new
- leftFraction: 0.25 offset: 0;
- topFraction: 0 offset: 0;
- rightFraction: 0.5 offset: 0;
- bottomFraction: bottomFraction offset: self buttonHeight negated - 3!

Item was changed:
  ----- Method: Browser>>openSystemCatEditString: (in category 'initialize-release') -----
  openSystemCatEditString: aString
  "Create a pluggable version of all the views for a Browser, including views and controllers.  The top list view is of the currently selected system class category--a single item list."
  "Example:
  Browser new browseAllClasses.
  "
  | builder max |
  builder := ToolBuilder default.
  max := self wantsOptionalButtons ifTrue:[0.32] ifFalse:[0.4].
  ^self buildWindowWith: builder specs: {
  (0@0 corner: 1.0@0.08) -> [self buildSystemCatListSingletonWith: builder].
+ (self classListFrame: max fromLeft: 0 width: 0.333) -> [self buildClassListWith: builder].
+ (self switchesFrame: max fromLeft: 0 width: 0.333) -> [self buildSwitchesWith: builder].
- (0.0@0.08 corner: 0.333@(max-0.1)) -> [self buildClassListWith: builder].
- (0.0@(max-0.1) corner: 0.333@max) -> [self buildSwitchesWith: builder].
  (0.333@0.08 corner: 0.666@max) -> [self buildMessageCategoryListWith: builder].
  (0.666@0.08 corner: 1@max) -> [self buildMessageListWith: builder].
  (0@max corner: 1@1) -> [self buildCodePaneWith: builder].
  }!

Item was added:
+ ----- Method: Browser>>switchesFrame:fromLeft:width: (in category 'initialize-release') -----
+ switchesFrame: bottomFraction fromLeft: leftFraction width: rightFraction
+ ^LayoutFrame new
+ leftFraction: leftFraction offset: 0;
+ topFraction: bottomFraction offset: self buttonHeight negated - 4;
+ rightFraction: (leftFraction + rightFraction) offset: 0;
+ bottomFraction: bottomFraction offset: 0!

On 4/3/2010 8:30 AM, [hidden email] wrote:
This doesn't work. Browser>>switchesFrame: calls
Browser>>switchesFrame:width: which is not implemented anywhere.

Cheers,
   - Andreas

Andreas Raab wrote:
Gosh that was silly of me. It's a simple thing to fix, and I'll upload a
new version ASAP.

frank

Frank Shearar wrote:
I uploaded a Tools-fbs.223 a while ago. I've not seen a commit message
pop up here yet.

I copied the version across to the inbox from my local repository -
would that still cause a commit mail?

frank

Frank Shearar wrote:
Ah. Yes, it would. Thunderbird thinks these mails come from two hours in
my past or something, so I just didn't notice the mail.

frank