The Inbox: Tools-fbs.411.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-fbs.411.mcz

commits-2
A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-fbs.411.mcz

==================== Summary ====================

Name: Tools-fbs.411
Author: fbs
Time: 7 June 2012, 9:21:33.746 pm
UUID: 07755363-c2f3-40be-891c-c3dbd6e36f15
Ancestors: Tools-fbs.410

#showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods).

=============== Diff against Tools-fbs.410 ===============

Item was changed:
  ----- Method: CodeHolder>>selectedMessage (in category 'message list') -----
  selectedMessage
  "Answer a copy of the source code for the selected message.  This generic version is probably actually never reached, since every subclass probably reimplements and does not send to super.  In time, ideally, most, or all, reimplementors would vanish and all would defer instead to a universal version right here.  Everything in good time."
 
  | class selector method |
  contents ifNotNil: [^ contents copy].
 
  self showingDecompile ifTrue:[^ self decompiledSourceIntoContents].
 
  class := self selectedClassOrMetaClass.
  (class isNil or: [(selector := self selectedMessageName) isNil]) ifTrue: [^ ''].
  method := class compiledMethodAt: selector ifAbsent: [^ '']. "method deleted while in another project"
  currentCompiledMethod := method.
 
+ ^ contents := (self showingDocumentation
- ^ contents := (self showComment
  ifFalse: [self sourceStringPrettifiedAndDiffed]
  ifTrue: [ self commentContents])
  copy asText makeSelectorBoldIn: class!

Item was removed:
- ----- Method: CodeHolder>>showComment (in category 'what to show') -----
- showComment
- "Answer whether the receiver should show documentation rather than, say, source code"
-
- ^ self contentsSymbol == #documentation
- !


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-fbs.411.mcz

Nicolas Cellier
+1 we should create a bounty for released selectors ;)

Nicolas

2012/6/7  <[hidden email]>:

> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-fbs.411.mcz
>
> ==================== Summary ====================
>
> Name: Tools-fbs.411
> Author: fbs
> Time: 7 June 2012, 9:21:33.746 pm
> UUID: 07755363-c2f3-40be-891c-c3dbd6e36f15
> Ancestors: Tools-fbs.410
>
> #showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods).
>
> =============== Diff against Tools-fbs.410 ===============
>
> Item was changed:
>  ----- Method: CodeHolder>>selectedMessage (in category 'message list') -----
>  selectedMessage
>        "Answer a copy of the source code for the selected message.  This generic version is probably actually never reached, since every subclass probably reimplements and does not send to super.  In time, ideally, most, or all, reimplementors would vanish and all would defer instead to a universal version right here.  Everything in good time."
>
>        | class selector method |
>        contents ifNotNil: [^ contents copy].
>
>        self showingDecompile ifTrue:[^ self decompiledSourceIntoContents].
>
>        class := self selectedClassOrMetaClass.
>        (class isNil or: [(selector := self selectedMessageName) isNil]) ifTrue: [^ ''].
>        method := class compiledMethodAt: selector ifAbsent: [^ ''].    "method deleted while in another project"
>        currentCompiledMethod := method.
>
> +       ^ contents := (self showingDocumentation
> -       ^ contents := (self showComment
>                ifFalse: [self sourceStringPrettifiedAndDiffed]
>                ifTrue: [ self commentContents])
>                        copy asText makeSelectorBoldIn: class!
>
> Item was removed:
> - ----- Method: CodeHolder>>showComment (in category 'what to show') -----
> - showComment
> -       "Answer whether the receiver should show documentation rather than, say, source code"
> -
> -       ^ self contentsSymbol == #documentation
> - !
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-fbs.411.mcz

Bert Freudenberg
In reply to this post by commits-2

On 2012-06-07, at 20:21, [hidden email] wrote:

> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-fbs.411.mcz
>
> ==================== Summary ====================
>
> Name: Tools-fbs.411
> Author: fbs
> Time: 7 June 2012, 9:21:33.746 pm
> UUID: 07755363-c2f3-40be-891c-c3dbd6e36f15
> Ancestors: Tools-fbs.410
>
> #showComment is identical to #showingDocumentation, and only has 1 sender, compared to #showingDocumentation's 9 senders. Both these messages belong to CodeHolder's internal protocols (so only it and its descendants use these methods).



This is not merged into the latest version, Tools-eem.412.

- Bert -