Smalltalk › Squeak › Squeak - Dev

The Inbox: Tools-jr.929.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

commits-2

The Inbox: Tools-jr.929.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-jr.929.mcz

==================== Summary ====================

Name: Tools-jr.929
Author: jr
Time: 30 December 2019, 3:20:08.513977 pm
UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
Ancestors: Tools-cmm.928

Show browsed environment in Browser title if it is not the default environment.

=============== Diff against Tools-cmm.928 ===============

Item was changed:
----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
defaultBrowserTitle
+ | title |
+ title := 'System Browser'.
+ ^ environment = self class environment
+ ifTrue: [title]
+ ifFalse: [title, ' on environment ', environment asString]!
- ^ 'System Browser'!

Christoph Thiede

Re: The Inbox: Tools-jr.929.mcz

Good idea! Maybe add some #translated stuff?

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Montag, 30. Dezember 2019 15:20:09
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Tools-jr.929.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-jr.929.mcz

==================== Summary ====================

Name: Tools-jr.929
Author: jr
Time: 30 December 2019, 3:20:08.513977 pm
UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
Ancestors: Tools-cmm.928

Show browsed environment in Browser title if it is not the default environment.

=============== Diff against Tools-cmm.928 ===============

Item was changed:
----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
defaultBrowserTitle
+        | title |
+        title := 'System Browser'.
+        ^ environment = self class environment
+                ifTrue: [title]
+                ifFalse: [title, ' on environment ', environment asString]!
-        ^ 'System Browser'!

Carpe Squeak!

Jakob Reschke

Re: The Inbox: Tools-jr.929.mcz

Not until the general idea meets approval ;-) after that, sure why not.

Am Mo., 30. Dez. 2019 um 15:25 Uhr schrieb Thiede, Christoph <[hidden email]>:

Good idea! Maybe add some #translated stuff?

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Montag, 30. Dezember 2019 15:20:09
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Tools-jr.929.mcz

A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-jr.929.mcz

==================== Summary ====================

Name: Tools-jr.929
Author: jr
Time: 30 December 2019, 3:20:08.513977 pm
UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
Ancestors: Tools-cmm.928

Show browsed environment in Browser title if it is not the default environment.

=============== Diff against Tools-cmm.928 ===============

Item was changed:
----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
defaultBrowserTitle
+        | title |
+        title := 'System Browser'.
+        ^ environment = self class environment
+                ifTrue: [title]
+                ifFalse: [title, ' on environment ', environment asString]!
-        ^ 'System Browser'!

Tobias Pape

Re: The Inbox: Tools-jr.929.mcz

In reply to this post by commits-2

> On 30.12.2019, at 15:20, [hidden email] wrote:
>
> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-jr.929.mcz
>
> ==================== Summary ====================
>
> Name: Tools-jr.929
> Author: jr
> Time: 30 December 2019, 3:20:08.513977 pm
> UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
> Ancestors: Tools-cmm.928
>
> Show browsed environment in Browser title if it is not the default environment.
>
> =============== Diff against Tools-cmm.928 ===============
>
> Item was changed:
> ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
> defaultBrowserTitle
> + | title |
> + title := 'System Browser'.
> + ^ environment = self class environment
> + ifTrue: [title]
> + ifFalse: [title, ' on environment ', environment asString]!
> - ^ 'System Browser'!
>
>

David T. Lewis

Re: The Inbox: Tools-jr.929.mcz

+1
Dave

On Wed, Jan 01, 2020 at 09:35:34PM +0100, Tobias Pape wrote:

> +1
> > On 30.12.2019, at 15:20, [hidden email] wrote:
> >
> > A new version of Tools was added to project The Inbox:
> > http://source.squeak.org/inbox/Tools-jr.929.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Tools-jr.929
> > Author: jr
> > Time: 30 December 2019, 3:20:08.513977 pm
> > UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
> > Ancestors: Tools-cmm.928
> >
> > Show browsed environment in Browser title if it is not the default environment.
> >
> > =============== Diff against Tools-cmm.928 ===============
> >
> > Item was changed:
> > ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
> > defaultBrowserTitle
> > + | title |
> > + title := 'System Browser'.
> > + ^ environment = self class environment
> > + ifTrue: [title]
> > + ifFalse: [title, ' on environment ', environment asString]!
> > - ^ 'System Browser'!
> >
> >
>
>
>

David T. Lewis

Re: The Inbox: Tools-jr.929.mcz

I also tried it like this:

Browser>>defaultBrowserTitle
^ 'System Browser on environment ', self class environment asString

And it seems quite acceptable to me. It serves as a reminder that
environments exist :-)

I'm not proposing that as a change, just making note of it.

Dave

On Thu, Jan 02, 2020 at 11:32:08AM -0500, David T. Lewis wrote:

> +1
> Dave
>
>
> On Wed, Jan 01, 2020 at 09:35:34PM +0100, Tobias Pape wrote:
> > +1
> > > On 30.12.2019, at 15:20, [hidden email] wrote:
> > >
> > > A new version of Tools was added to project The Inbox:
> > > http://source.squeak.org/inbox/Tools-jr.929.mcz
> > >
> > > ==================== Summary ====================
> > >
> > > Name: Tools-jr.929
> > > Author: jr
> > > Time: 30 December 2019, 3:20:08.513977 pm
> > > UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466
> > > Ancestors: Tools-cmm.928
> > >
> > > Show browsed environment in Browser title if it is not the default environment.
> > >
> > > =============== Diff against Tools-cmm.928 ===============
> > >
> > > Item was changed:
> > > ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') -----
> > > defaultBrowserTitle
> > > + | title |
> > > + title := 'System Browser'.
> > > + ^ environment = self class environment
> > > + ifTrue: [title]
> > > + ifFalse: [title, ' on environment ', environment asString]!
> > > - ^ 'System Browser'!
> > >
> > >
> >
> >
> >
>

Jakob Reschke

Re: The Inbox: Tools-jr.929.mcz

Am Do., 2. Jan. 2020 um 17:45 Uhr schrieb David T. Lewis <[hidden email]>:

I also tried it like this:

Browser>>defaultBrowserTitle
^ 'System Browser on environment ', self class environment asString

And it seems quite acceptable to me. It serves as a reminder that
environments exist :-)

I'm not proposing that as a change, just making note of it.

Please note the difference between self class environment and self environment here:

self class environment is the environment in which the class "Browser" was defined.

self environment is the environment that "a Browser" browses.

David T. Lewis

Re: The Inbox: Tools-jr.929.mcz

On Thu, Jan 02, 2020 at 10:14:56PM +0100, Jakob Reschke wrote:

> Am Do., 2. Jan. 2020 um 17:45 Uhr schrieb David T. Lewis <
> [hidden email]>:
>
> > I also tried it like this:
> >
> > Browser>>defaultBrowserTitle
> > ^ 'System Browser on environment ', self class environment asString
> >
> > And it seems quite acceptable to me. It serves as a reminder that
> > environments exist :-)
> >
> > I'm not proposing that as a change, just making note of it.
> >
>
> Please note the difference between self class environment and self environment here:
> self class environment is the environment in which the class "Browser" was defined.
> self environment is the environment that "a Browser" browses.

Yes, so it should be this instead:

Browser>>defaultBrowserTitle
^ 'System Browser on environment ', self environment asString

Or perhaps to save some space on the window label:

Browser>>defaultBrowserTitle
^ 'System Browser on ', self environment asString

Dave

System Browser on Smalltalk: OrderedCollection.png (69K) Download Attachment