The Inbox: Tools-nice.731.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-nice.731.mcz

commits-2
Nicolas Cellier uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-nice.731.mcz

==================== Summary ====================

Name: Tools-nice.731
Author: nice
Time: 27 October 2016, 10:23:11.706603 pm
UUID: 31a047c7-9937-46f9-8710-1c38882f2a77
Ancestors: Tools-eem.730

Fix the field menu of Set inspector.

It's sent to a MenuMorph which DNU labels:.
Anyway, implementors of labels: do not expect alternate (selector action selector acton ...)

=============== Diff against Tools-eem.730 ===============

Item was changed:
  ----- Method: SetInspector>>mainFieldListMenu: (in category 'menu') -----
  mainFieldListMenu: aMenu
 
+ ^ aMenu addList: #(
- ^ aMenu labels: #(
  ('inspect' inspectSelection)
  ('copy name' copyName)
  ('objects pointing to this value' objectReferencesToSelection)
  ('refresh view' update)
  ('remove' removeSelection)
  -
  ('basic inspect' inspectBasic));
  yourself
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-nice.731.mcz

Nicolas Cellier
Hi Tobias, Marcel
Does it sound OK?

2016-10-27 22:23 GMT+02:00 <[hidden email]>:
Nicolas Cellier uploaded a new version of Tools to project The Inbox:
http://source.squeak.org/inbox/Tools-nice.731.mcz

==================== Summary ====================

Name: Tools-nice.731
Author: nice
Time: 27 October 2016, 10:23:11.706603 pm
UUID: 31a047c7-9937-46f9-8710-1c38882f2a77
Ancestors: Tools-eem.730

Fix the field menu of Set inspector.

It's sent to a MenuMorph which DNU labels:.
Anyway, implementors of labels: do not expect alternate (selector action selector acton ...)

=============== Diff against Tools-eem.730 ===============

Item was changed:
  ----- Method: SetInspector>>mainFieldListMenu: (in category 'menu') -----
  mainFieldListMenu: aMenu

+       ^ aMenu addList: #(
-       ^ aMenu labels: #(
                        ('inspect'                                                      inspectSelection)
                        ('copy name'                                            copyName)
                        ('objects pointing to this value'               objectReferencesToSelection)
                        ('refresh view'                                         update)
                        ('remove'                                                       removeSelection)
                        -
                        ('basic inspect'                                                inspectBasic));
                yourself
  !





Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-nice.731.mcz

Tobias Pape
Hi,

On 27.10.2016, at 22:28, Nicolas Cellier <[hidden email]> wrote:

> Hi Tobias, Marcel
> Does it sound OK?

yes, good catch. #addList: (or #addTranslatedList: for that matter) is IMHO the way to go.

Best regards
        -Tobias

>
> 2016-10-27 22:23 GMT+02:00 <[hidden email]>:
> Nicolas Cellier uploaded a new version of Tools to project The Inbox:
> http://source.squeak.org/inbox/Tools-nice.731.mcz
>
> ==================== Summary ====================
>
> Name: Tools-nice.731
> Author: nice
> Time: 27 October 2016, 10:23:11.706603 pm
> UUID: 31a047c7-9937-46f9-8710-1c38882f2a77
> Ancestors: Tools-eem.730
>
> Fix the field menu of Set inspector.
>
> It's sent to a MenuMorph which DNU labels:.
> Anyway, implementors of labels: do not expect alternate (selector action selector acton ...)
>
> =============== Diff against Tools-eem.730 ===============
>
> Item was changed:
>   ----- Method: SetInspector>>mainFieldListMenu: (in category 'menu') -----
>   mainFieldListMenu: aMenu
>
> +       ^ aMenu addList: #(
> -       ^ aMenu labels: #(
>                         ('inspect'                                                      inspectSelection)
>                         ('copy name'                                            copyName)
>                         ('objects pointing to this value'               objectReferencesToSelection)
>                         ('refresh view'                                         update)
>                         ('remove'                                                       removeSelection)
>                         -
>                         ('basic inspect'                                                inspectBasic));
>                 yourself
>   !
>
>
>
>