The Inbox: Tools-tcj.827.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Tools-tcj.827.mcz

commits-2
A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-tcj.827.mcz

==================== Summary ====================

Name: Tools-tcj.827
Author: tcj
Time: 3 July 2018, 1:26:17.691671 pm
UUID: 1faf6a9f-6246-4b95-a3aa-13b113afd08b
Ancestors: Tools-cmm.826

Revert the change to File Contents Browser introduced in Tools-eem.660 which broke version browsing in the File Contents Browser.  "Browse versions" now works again to browse versions of a given selector while browsing through a changeset.

=============== Diff against Tools-cmm.826 ===============

Item was changed:
  ----- Method: FileContentsBrowser>>browseVersions (in category 'other') -----
  browseVersions
+ "Create and schedule a message set browser on all versions of the
+ currently selected message selector."
+ | class selector |
+ (selector := self selectedMessageName) ifNotNil:
+ [class := self selectedClassOrMetaClass.
+ (class exists and: [class realClass includesSelector: selector]) ifTrue:
+ [VersionsBrowser
+ browseVersionsOf: (class realClass compiledMethodAt: selector)
+ class: class realClass theNonMetaClass
+ meta: class realClass isMeta
+ category: self selectedMessageCategoryName
+ selector: selector]]!
- "Create and schedule a message set browser on all versions of the currently selected message selector."
- (ToolSet
- browseVersionsOf: self selectedClassOrMetaClass
- selector: self selectedMessageName) ifNil: [self changed: #flash]!

Item was changed:
  ----- Method: PasteUpMorph>>defaultDesktopCommandKeyTriplets (in category '*Tools') -----
  defaultDesktopCommandKeyTriplets
  "Answer a list of triplets of the form
  <key> <receiver> <selector>   [+ optional fourth element, a <description> for use in desktop-command-key-help]
+ that will provide the default desktop command key handlers.  If the selector takes an argument, that argument will be the command-key event"
- that will provide the default desktop command key handlers.  If the selector takes an argument, that argument will be the command-key event"
 
  | noviceKeys expertKeys |
 
  noviceKeys := {
  { $o. ActiveWorld. #activateObjectsTool. 'Activate the "Objects Tool"'}.
  { $r. ActiveWorld. #restoreMorphicDisplay. 'Redraw the screen'}.
  { $z. self. #undoOrRedoCommand. 'Undo or redo the last undoable command'}.
  { $F. Project current. #toggleFlapsSuppressed. 'Toggle the display of flaps'}.
  { $N. self. #toggleClassicNavigatorIfAppropriate. 'Show/Hide the classic Navigator, if appropriate'}.
  { $M. self. #toggleShowWorldMainDockingBar. 'Show/Hide the Main Docking Bar'}.
  { $]. Smalltalk. #saveSession. 'Save the image.'}.
  }.
 
+ Preferences noviceMode ifTrue:[^ noviceKeys].
- Preferences noviceMode
- ifTrue:[^ noviceKeys].
 
  expertKeys := {
  { $b. SystemBrowser. #defaultOpenBrowser. 'Open a new System Browser'}.
  { $k. StringHolder. #open. 'Open a new, blank Workspace'}.
  { $m. self. #putUpNewMorphMenu. 'Put up the "New Morph" menu'}.
  { $O. self. #findAMonticelloBrowser. 'Bring a Monticello window into focus.'}.
  { $t. self. #findATranscript:. 'Make a System Transcript visible'}.
  { $w. SystemWindow. #closeTopWindow. 'Close the topmost window'}.
  { Character escape. SystemWindow. #closeTopWindow. 'Close the topmost window'}.
 
  { $C. self. #findAChangeSorter:. 'Make a Change Sorter visible'}.
 
  { $L. self. #findAFileList:. 'Make a File List visible'}.
  { $P. self. #findAPreferencesPanel:. 'Activate the Preferences tool'}.
  { $R. Utilities. #browseRecentSubmissions. 'Make a Recent Submissions browser visible'}.
 
  { $W. self. #findAMessageNamesWindow:. 'Make a MessageNames tool visible'}.
  { $Z. ChangeList. #browseRecentLog. 'Browse recently-logged changes'}.
 
  { $\. SystemWindow. #sendTopWindowToBack. 'Send the top window to the back'}.
  { $_. Smalltalk. #quitPrimitive. 'Quit the image immediately.'}.
 
+ { $-. Preferences. #decreaseFontSize. 'Decrease all font sizes'}.
+ { $+. Preferences. #increaseFontSize. 'Increase all font sizes'}.
- { $-. Preferences. #decreaseFontSize. 'Increase all font sizes'}.
- { $+. Preferences. #increaseFontSize. 'Decrease all font sizes'}.
  }.
 
  ^ noviceKeys, expertKeys
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Tools-tcj.827.mcz

Tim Johnson-2
Whoops, sorry.  Looks like my change captured some of the difference
between Tools in trunk and Tools in inbox.  May have to scrap this one
until I can figure out why that happened...?

My change only reverts FileContentsBrowser>>#browseVersions to the
version from dew 9/20/2001.

On 2018-07-03 20:26, [hidden email] wrote:

> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-tcj.827.mcz
>
> ==================== Summary ====================
>
> Name: Tools-tcj.827
> Author: tcj
> Time: 3 July 2018, 1:26:17.691671 pm
> UUID: 1faf6a9f-6246-4b95-a3aa-13b113afd08b
> Ancestors: Tools-cmm.826
>
> Revert the change to File Contents Browser introduced in Tools-eem.660
> which broke version browsing in the File Contents Browser.  "Browse
> versions" now works again to browse versions of a given selector while
> browsing through a changeset.
>
> =============== Diff against Tools-cmm.826 ===============
>
> Item was changed:
>   ----- Method: FileContentsBrowser>>browseVersions (in category
> 'other') -----
>   browseVersions
> + "Create and schedule a message set browser on all versions of the
> + currently selected message selector."
> + | class selector |
> + (selector := self selectedMessageName) ifNotNil:
> + [class := self selectedClassOrMetaClass.
> + (class exists and: [class realClass includesSelector: selector])
> ifTrue:
> + [VersionsBrowser
> + browseVersionsOf: (class realClass compiledMethodAt: selector)
> + class: class realClass theNonMetaClass
> + meta: class realClass isMeta
> + category: self selectedMessageCategoryName
> + selector: selector]]!
> - "Create and schedule a message set browser on all versions of the
> currently selected message selector."
> - (ToolSet
> - browseVersionsOf: self selectedClassOrMetaClass
> - selector: self selectedMessageName) ifNil: [self changed: #flash]!
>
> Item was changed:
>   ----- Method: PasteUpMorph>>defaultDesktopCommandKeyTriplets (in
> category '*Tools') -----
>   defaultDesktopCommandKeyTriplets
>   "Answer a list of triplets of the form
>   <key> <receiver> <selector>   [+ optional fourth element, a
> <description> for use in desktop-command-key-help]
> + that will provide the default desktop command key handlers.  If the
> selector takes an argument, that argument will be the command-key
> event"
> - that will provide the default desktop command key handlers.  If the
> selector takes an argument, that argument will be the command-key
> event"
>
>   | noviceKeys expertKeys |
>
>   noviceKeys := {
>   { $o. ActiveWorld. #activateObjectsTool. 'Activate the
> "Objects Tool"'}.
>   { $r. ActiveWorld. #restoreMorphicDisplay. 'Redraw the
> screen'}.
>   { $z. self. #undoOrRedoCommand. 'Undo or redo the last
> undoable command'}.
>   { $F. Project current. #toggleFlapsSuppressed. 'Toggle the
> display of flaps'}.
>   {
> $N. self. #toggleClassicNavigatorIfAppropriate. 'Show/Hide the
> classic Navigator, if appropriate'}.
>   { $M. self. #toggleShowWorldMainDockingBar. 'Show/Hide the
> Main Docking Bar'}.
>   { $]. Smalltalk. #saveSession. 'Save the image.'}.
>   }.
>
> + Preferences noviceMode ifTrue:[^ noviceKeys].
> - Preferences noviceMode
> - ifTrue:[^ noviceKeys].
>
>   expertKeys := {
>   { $b. SystemBrowser. #defaultOpenBrowser. 'Open a new
> System Browser'}.
>   { $k. StringHolder. #open. 'Open a new, blank
> Workspace'}.
>   { $m. self. #putUpNewMorphMenu. 'Put up the "New Morph"
> menu'}.
>   { $O. self. #findAMonticelloBrowser. 'Bring a
> Monticello window into focus.'}.
>   { $t. self. #findATranscript:. 'Make a System
> Transcript visible'}.
>   { $w. SystemWindow. #closeTopWindow. 'Close the topmost
> window'}.
>   { Character escape. SystemWindow. #closeTopWindow. 'Close
> the topmost window'}.
>
>   { $C. self. #findAChangeSorter:. 'Make a Change Sorter
> visible'}.
>
>   { $L. self. #findAFileList:. 'Make a File List
> visible'}.
>   { $P. self. #findAPreferencesPanel:. 'Activate the
> Preferences tool'}.
>   { $R. Utilities. #browseRecentSubmissions. 'Make a Recent
> Submissions browser visible'}.
>
>   { $W. self. #findAMessageNamesWindow:. 'Make a
> MessageNames tool visible'}.
>   { $Z. ChangeList. #browseRecentLog. 'Browse
> recently-logged changes'}.
>
>   { $\. SystemWindow. #sendTopWindowToBack. 'Send the top
> window to the back'}.
>   { $_. Smalltalk. #quitPrimitive. 'Quit the image
> immediately.'}.
>
> + { $-. Preferences. #decreaseFontSize. 'Decrease all font
> sizes'}.
> + { $+. Preferences. #increaseFontSize. 'Increase all font
> sizes'}.
> - { $-. Preferences. #decreaseFontSize. 'Increase all font
> sizes'}.
> - { $+. Preferences. #increaseFontSize. 'Decrease all font
> sizes'}.
>   }.
>
>   ^ noviceKeys, expertKeys
>   !