The Trunk: 51Deprecated-mt.10.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: 51Deprecated-mt.10.mcz

commits-2
Marcel Taeumel uploaded a new version of 51Deprecated to project The Trunk:
http://source.squeak.org/trunk/51Deprecated-mt.10.mcz

==================== Summary ====================

Name: 51Deprecated-mt.10
Author: mt
Time: 6 November 2015, 12:11:35.883 pm
UUID: 92916d21-c539-45f6-8766-ad9ace8cbae9
Ancestors: 51Deprecated-mt.9

Makes the preference #balloonHelpInMessageLists functional again.

Applies the preferences "Show message icons" and #balloonHelpInMessageLists also to senders, implementors, message traces, debuggers, etc.

=============== Diff against 51Deprecated-mt.9 ===============

Item was added:
+ ----- Method: StringMorph>>balloonTextForClassAndMethodString (in category '*51Deprecated-Tools') -----
+ balloonTextForClassAndMethodString
+ "Answer suitable balloon text for the receiver thought of as an encoding of the form
+ <className>  [ class ] <selector>"
+
+ | aComment |
+ Preferences balloonHelpInMessageLists
+ ifFalse: [^ nil].
+ MessageSet parse: self contents asString toClassAndSelector:
+ [:aClass :aSelector |
+ (aClass notNil and: [aSelector notNil]) ifTrue:
+ [aComment := aClass precodeCommentOrInheritedCommentFor: aSelector]].
+ ^ aComment
+ !

Item was added:
+ ----- Method: StringMorph>>balloonTextForLexiconString (in category '*51Deprecated-Tools') -----
+ balloonTextForLexiconString
+ "Answer suitable balloon text for the receiver thought of as an encoding (used in Lexicons) of the form
+ <selector> <spaces> (<className>>)"
+
+ | aComment contentsString aSelector aClassName |
+ Preferences balloonHelpInMessageLists
+ ifFalse: [^ nil].
+ contentsString := self contents asString.
+ aSelector := contentsString upTo: $ .
+ aClassName := contentsString copyFrom: ((contentsString indexOf: $() + 1) to: ((contentsString indexOf: $)) - 1).
+ MessageSet parse: (aClassName, ' dummy') toClassAndSelector:
+ [:cl :sel | cl ifNotNil:
+ [aComment := cl precodeCommentOrInheritedCommentFor: aSelector]].
+ ^ aComment
+ !

Item was added:
+ ----- Method: StringMorph>>balloonTextForMethodString (in category '*51Deprecated-Tools') -----
+ balloonTextForMethodString
+ "Answer suitable balloon text for the receiver thought of as a method belonging to the currently-selected class of a browser tool."
+
+ | aWindow aCodeHolder aClass |
+ Preferences balloonHelpInMessageLists
+ ifFalse: [^ nil].
+ aWindow := self ownerThatIsA: SystemWindow.
+ (aWindow isNil or: [((aCodeHolder := aWindow model) isKindOf: CodeHolder) not])
+ ifTrue: [^ nil].
+ ((aClass := aCodeHolder selectedClassOrMetaClass) isNil or:
+ [(aClass includesSelector: contents asSymbol) not])
+ ifTrue: [^ nil].
+ ^ aClass precodeCommentOrInheritedCommentFor: contents asSymbol
+ !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: 51Deprecated-mt.10.mcz

Tobias Pape
Hey Marcel,

On 06.11.2015, at 11:11, [hidden email] wrote:

> Marcel Taeumel uploaded a new version of 51Deprecated to project The Trunk:
> http://source.squeak.org/trunk/51Deprecated-mt.10.mcz
>
> ==================== Summary ====================
>
> Name: 51Deprecated-mt.10
> Author: mt
> Time: 6 November 2015, 12:11:35.883 pm
> UUID: 92916d21-c539-45f6-8766-ad9ace8cbae9
> Ancestors: 51Deprecated-mt.9
>
> Makes the preference #balloonHelpInMessageLists functional again.
>
> Applies the preferences "Show message icons" and #balloonHelpInMessageLists also to senders, implementors, message traces, debuggers, etc.
>
> =============== Diff against 51Deprecated-mt.9 ===============
>
> Item was added:


If you deprecate these methods, maybe add a deprecation notice to it, like it
is already done with

String>>includesSubString: subString

        self deprecated: 'Use #includesSubstring: instead.'.
        ^self includesSubstring: subString

Best regards
        -Tobias