The Trunk: 60Deprecated-mt.16.mcz

Yeah, I think that we are all in a learning process figuring out what the most robust solution looks like. Eventually, we will get there. Or close to it.

One big insight of this incident is that we might want to disable deprecation warnings during "code update" and (re-)enable them for the test runs. :-) So, we did learn something.

Best,

Marcel

Am 17.04.2018 16:30:55 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,

On Apr 17, 2018, at 7:18 AM, Marcel Taeumel <[hidden email]> wrote:

Hi Eliot,

sure, it is:

Deprecation showDeprecationWarnings: false.

Doh.. of course; excuse me.  Perhaps we should apply this preference when running any script.  The rationale being that the system may change, breaking existing scripts, and going back and editing all scripts is expensive.  Whereas arranging to show no deprecation warnings (or merely report them to the transcript?) is cheap.

At the moment, it is just a timing issue. Fabio has to update several scripts to disable the deprecation warnings. I think that he will do that soon, and then we can revert this change again.

And that seems to me the wrong response.  Scripts should keep working for as long as possible given that we're using them more and more.  Do you agree?

Best,

Marcel

Am 17.04.2018 15:59:51 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,

can't we have a preference which silences deprecation warnings? Lots of scripts could use something like this. We shouldn't have to hack valid depreciations to get around the reporting of those depreciations.

_,,,^..^,,,_ (phone)

> On Apr 17, 2018, at 5:51 AM, [hidden email] wrote:
>
> Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
> http://source.squeak.org/trunk/60Deprecated-mt.16.mcz
>
> ==================== Summary ====================
>
> Name: 60Deprecated-mt.16
> Author: mt
> Time: 17 April 2018, 3:51:45.699445 pm
> UUID: e6549fe4-aa5a-284e-83bb-c7d065f867f0
> Ancestors: 60Deprecated-mt.15
>
> Avoid explicit deprecation warning to keep smalltalkCI working.
>
> See: https://github.com/hpi-swa/smalltalkCI/issues/368
>
> =============== Diff against 60Deprecated-mt.15 ===============
>
> Item was changed:
> ----- Method: Utilities class>>setAuthorInitials: (in category '*60Deprecated-identification') -----
> setAuthorInitials: aString
>
> + "mt: Not now (17/04/2018) for SmalltalkCI. See: https://github.com/hpi-swa/smalltalkCI/issues/368
> + self deprecated: 'Use #authorInitials:.'."
> +
> - self deprecated: 'Use #authorInitials:.'.
> self authorInitials: aString.!
>
>

Hi Marcel,

On Tue, Apr 17, 2018 at 8:07 AM, Marcel Taeumel <[hidden email]> wrote:

Yeah, I think that we are all in a learning process figuring out what the most robust solution looks like. Eventually, we will get there. Or close to it.

One big insight of this incident is that we might want to disable deprecation warnings during "code update" and (re-)enable them for the test runs. :-) So, we did learn something.

I think this is urgent.

  I just got bit:

    0x7fff5c563dc8 I UnhandledWarning class(UnhandledError class)>signalForException: 0x10b5bcd18: a(n) UnhandledWarning class

    0x7fff5c563e00 M Deprecation(Warning)>defaultAction 0x10a489df0: a(n) Deprecation

    0x7fff5c563e38 M UndefinedObject>handleSignal: 0x10abe48e0: a(n) UndefinedObject

    0x7fff5c55e788 M Context>handleSignal: 0x10e4b2720: a(n) Context

    0x7fff5c55e7d0 M Context>handleSignal: 0x10f675ab8: a(n) Context

    0x7fff5c55e818 M Context>handleSignal: 0x10f675848: a(n) Context

    0x7fff5c55e860 M Context>handleSignal: 0x10f6430d0: a(n) Context

    0x7fff5c55e898 M Deprecation(Exception)>signal 0x10a489df0: a(n) Deprecation

    0x7fff5c55e8c8 M Deprecation(Exception)>signal: 0x10a489df0: a(n) Deprecation

    0x7fff5c55e910 I Deprecation class(Exception class)>signal: 0x10afc39d0: a(n) Deprecation class

    0x7fff5c55e960 I Deprecation class>maybeSignalDeprecationFor:message:explanation: 0x10afc39d0: a(n) Deprecation class

    0x7fff5c55e9b8 I PluggableSystemWindow(Object)>deprecated: 0x10a48a470: a(n) PluggableSystemWindow

    0x7fff5c55ea00 I PluggableSystemWindow(SystemWindow)>anyOpenWindowLikeMe 0x10a48a470: a(n) PluggableSystemWindow

    0x7fff5c55ea40 I PluggableSystemWindow(SystemWindow)>openInWorld:extent: 0x10a48a470: a(n) PluggableSystemWindow

    0x7fff5c55ea90 I PluggableSystemWindow(SystemWindow)>openInWorldExtent: 0x10a48a470: a(n) PluggableSystemWindow

    0x7fff5c55ead8 I MCMergeBrowser(MCTool)>showModally 0x10a48a7c8: a(n) MCMergeBrowser

    0x7fff5c55eb08 M MCMergeResolutionRequest>defaultAction 0x10a48a8e8: a(n) MCMergeResolutionRequest

    0x7fff5c55eb40 M UndefinedObject>handleSignal: 0x10abe48e0: a(n) UndefinedObject

    0x7fff5c55eb88 M Context>handleSignal: 0x10e4b2720: a(n) Context

    0x7fff5c55ebd0 I MCMergeResolutionRequest(Exception)>pass 0x10a48a8e8: a(n) MCMergeResolutionRequest

    0x7fff5c55ec00 M [] in MCConfiguration>upgrade 0x10ec82e80: a(n) MCConfiguration

    0x7fff5c55ec38 M BlockClosure>cull: 0x10f675d10: a(n) BlockClosure

    0x7fff5c55ec78 M [] in Context>handleSignal: 0x10f675ab8: a(n) Context

    0x7fff5c55ecb8 M BlockClosure>ensure: 0x10a48ae28: a(n) BlockClosure

    0x7fff5c55ed00 M Context>handleSignal: 0x10f675ab8: a(n) Context

    0x7fff5c55ed48 M Context>handleSignal: 0x10f675848: a(n) Context

    0x7fff5c55ed90 M Context>handleSignal: 0x10f6430d0: a(n) Context

    0x7fff5c55edc8 M MCMergeResolutionRequest(Exception)>signal 0x10a48a8e8: a(n) MCMergeResolutionRequest

    0x7fff5c55edf8 M MCMergeResolutionRequest(Exception)>signal: 0x10a48a8e8: a(n) MCMergeResolutionRequest

    0x7fff5c55ee40 I MCVersionMerger>resolveConflicts 0x10f68f718: a(n) MCVersionMerger

       0x10f68f780 s MCVersionMerger>mergeWithNameLike:

       0x10f699890 s MCVersionMerger class>mergeVersion:

       0x10f635278 s [] in MCVersion>merge

       0x10f6430d0 s BlockClosure>on:do:

       0x10f659248 s Environment>beCurrentDuring:

       0x10f6756d8 s MCWorkingCopy>withEnvironmentActiveDo:

       0x10f659320 s MCVersion>merge

Of course now I now to turn off the warning while I update, but for a newbie this could be painful.

 

Best,

Marcel

Am 17.04.2018 16:30:55 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,

On Apr 17, 2018, at 7:18 AM, Marcel Taeumel <[hidden email]> wrote:

Hi Eliot,

sure, it is:

Deprecation showDeprecationWarnings: false.

Doh.. of course; excuse me.  Perhaps we should apply this preference when running any script.  The rationale being that the system may change, breaking existing scripts, and going back and editing all scripts is expensive.  Whereas arranging to show no deprecation warnings (or merely report them to the transcript?) is cheap.

At the moment, it is just a timing issue. Fabio has to update several scripts to disable the deprecation warnings. I think that he will do that soon, and then we can revert this change again.

And that seems to me the wrong response.  Scripts should keep working for as long as possible given that we're using them more and more.  Do you agree?

Best,

Marcel

Am 17.04.2018 15:59:51 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,

can't we have a preference which silences deprecation warnings? Lots of scripts could use something like this. We shouldn't have to hack valid depreciations to get around the reporting of those depreciations.

_,,,^..^,,,_ (phone)

> On Apr 17, 2018, at 5:51 AM, [hidden email] wrote:
>
> Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk:
> http://source.squeak.org/trunk/60Deprecated-mt.16.mcz
>
> ==================== Summary ====================
>
> Name: 60Deprecated-mt.16
> Author: mt
> Time: 17 April 2018, 3:51:45.699445 pm
> UUID: e6549fe4-aa5a-284e-83bb-c7d065f867f0
> Ancestors: 60Deprecated-mt.15
>
> Avoid explicit deprecation warning to keep smalltalkCI working.
>
> See: https://github.com/hpi-swa/smalltalkCI/issues/368
>
> =============== Diff against 60Deprecated-mt.15 ===============
>
> Item was changed:
> ----- Method: Utilities class>>setAuthorInitials: (in category '*60Deprecated-identification') -----
> setAuthorInitials: aString
>
> + "mt: Not now (17/04/2018) for SmalltalkCI. See: https://github.com/hpi-swa/smalltalkCI/issues/368
> + self deprecated: 'Use #authorInitials:.'."
> +
> - self deprecated: 'Use #authorInitials:.'.
> self authorInitials: aString.!
>
>

--

_,,,^..^,,,_

best, Eliot