Smalltalk › Squeak › Squeak - Dev

The Trunk: Collections-fbs.513.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Trunk: Collections-fbs.513.mcz

Frank Shearar uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-fbs.513.mcz

==================== Summary ====================

Name: Collections-fbs.513
Author: fbs
Time: 26 April 2013, 11:13:00.656 am
UUID: dba4f808-6844-414c-a5bf-5cda0cf4e342
Ancestors: Collections-bf.512

This fixes the recent report of an Ubuntu 13.04 machine not being able to save a class comment.

https://bugzilla.redhat.com/show_bug.cgi?id=956376

=============== Diff against Collections-bf.512 ===============

Item was changed:
----- Method: WriteStream>>nextChunkPut: (in category 'fileIn/Out') -----
nextChunkPut: aString
"Append the argument, aString, to the receiver, doubling embedded terminators."

| i remainder terminator |
terminator := $!!.
remainder := aString.
[(i := remainder indexOf: terminator) = 0] whileFalse:
[self nextPutAll: (remainder copyFrom: 1 to: i).
self nextPut: terminator. "double imbedded terminators"
remainder := remainder copyFrom: i+1 to: remainder size].
self nextPutAll: remainder.
aString includesUnifiedCharacter ifTrue: [
self nextPut: terminator.
self nextPutAll: ']lang['.
aString writeLeadingCharRunsOn: self.
].
self nextPut: terminator.
+ self flush.
!

Bert Freudenberg

Re: The Trunk: Collections-fbs.513.mcz

On 2013-04-26, at 14:05, [hidden email] wrote:

> Frank Shearar uploaded a new version of Collections to project The Trunk:
> http://source.squeak.org/trunk/Collections-fbs.513.mcz
>
> ==================== Summary ====================
>
> Name: Collections-fbs.513
> Author: fbs
> Time: 26 April 2013, 11:13:00.656 am
> UUID: dba4f808-6844-414c-a5bf-5cda0cf4e342
> Ancestors: Collections-bf.512
>
> This fixes the recent report of an Ubuntu 13.04 machine not being able to save a class comment.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=956376
>
> =============== Diff against Collections-bf.512 ===============
>
> Item was changed:
> ----- Method: WriteStream>>nextChunkPut: (in category 'fileIn/Out') -----
> nextChunkPut: aString
> "Append the argument, aString, to the receiver, doubling embedded terminators."
>
> | i remainder terminator |
> terminator := $!!.
> remainder := aString.
> [(i := remainder indexOf: terminator) = 0] whileFalse:
> [self nextPutAll: (remainder copyFrom: 1 to: i).
> self nextPut: terminator. "double imbedded terminators"
> remainder := remainder copyFrom: i+1 to: remainder size].
> self nextPutAll: remainder.
> aString includesUnifiedCharacter ifTrue: [
> self nextPut: terminator.
> self nextPutAll: ']lang['.
> aString writeLeadingCharRunsOn: self.
> ].
> self nextPut: terminator.
> + self flush.
> !

This just papers over the problem, does not fix it.

We need to figure out what the problem is on the VM side.

IMHO this should not be in trunk.

- Bert -

Chris Muller-3

Re: The Trunk: Collections-fbs.513.mcz

I'm glad this method isn't called as part of regular binary writes to
a WriteStream (if it were I'd be jumping up and down), but I still
agree with Bert. This is not the right method to be #flush'ing from.
It should be fixed in the VM or flush from a higher level.

On Fri, Apr 26, 2013 at 9:41 AM, Bert Freudenberg <[hidden email]> wrote:

>
> On 2013-04-26, at 14:05, [hidden email] wrote:
>
>> Frank Shearar uploaded a new version of Collections to project The Trunk:
>> http://source.squeak.org/trunk/Collections-fbs.513.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-fbs.513
>> Author: fbs
>> Time: 26 April 2013, 11:13:00.656 am
>> UUID: dba4f808-6844-414c-a5bf-5cda0cf4e342
>> Ancestors: Collections-bf.512
>>
>> This fixes the recent report of an Ubuntu 13.04 machine not being able to save a class comment.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=956376
>>
>> =============== Diff against Collections-bf.512 ===============
>>
>> Item was changed:
>> ----- Method: WriteStream>>nextChunkPut: (in category 'fileIn/Out') -----
>> nextChunkPut: aString
>> "Append the argument, aString, to the receiver, doubling embedded terminators."
>>
>> | i remainder terminator |
>> terminator := $!!.
>> remainder := aString.
>> [(i := remainder indexOf: terminator) = 0] whileFalse:
>> [self nextPutAll: (remainder copyFrom: 1 to: i).
>> self nextPut: terminator. "double imbedded terminators"
>> remainder := remainder copyFrom: i+1 to: remainder size].
>> self nextPutAll: remainder.
>> aString includesUnifiedCharacter ifTrue: [
>> self nextPut: terminator.
>> self nextPutAll: ']lang['.
>> aString writeLeadingCharRunsOn: self.
>> ].
>> self nextPut: terminator.
>> + self flush.
>> !
>
>
> This just papers over the problem, does not fix it.
>
> We need to figure out what the problem is on the VM side.
>
> IMHO this should not be in trunk.
>
> - Bert -
>
>
>

Frank Shearar-3

Re: The Trunk: Collections-fbs.513.mcz

In reply to this post by Bert Freudenberg

On 26 April 2013 15:41, Bert Freudenberg <[hidden email]> wrote:

I don't think it's confirmed that it's a VM problem.

> IMHO this should not be in trunk.

Since there are now two -1s, what's the best way to fix this? Apply a
reversion mcz?

frank

> - Bert -
>
>
>