Smalltalk › Squeak › Squeak - Dev

The Trunk: Collections-mt.945.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Trunk: Collections-mt.945.mcz

Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-mt.945.mcz

==================== Summary ====================

Name: Collections-mt.945
Author: mt
Time: 18 June 2021, 8:02:50.788904 am
UUID: d551c74f-90b4-400a-8952-d9d4ff31e3bb
Ancestors: Collections-eem.944

Extends constant character names to support #return.

Fixes constant character names to work with all current constants, which, e.g., includes #arrowUp etc.

Drop #newPage in favor of #pageDown (and #pageUp). Note that #newPage still works as a constant. It will just not show up when you print a non-printable character.

=============== Diff against Collections-eem.944 ===============

Item was changed:
----- Method: Character class>>constantNames (in category 'private') -----
constantNames
+ ^ #( backspace delete return lf enter delete escape null space tab arrowDown arrowUp arrowLeft arrowRight end home pageDown pageUp euro insert )!
- ^ #( backspace cr delete escape lf null newPage space tab ).!

Item was added:
+ ----- Method: Character class>>return (in category 'accessing untypeable characters') -----
+ return
+ "Answer the Character representing a carriage return."
+
+ ^self value: 13!

marcel.taeumel

Re: The Trunk: Collections-mt.945.mcz

One more thing: Also changes the printString of ASCII-13 to #return because it seems more readable than #cr.

Note that I pushed readability more into the direction of recognizing physical keys, not standard ASCII labels. I hope that's fine... In that sense, the printString for #lf might be also changed to #linefeed, which is already there.

But is there a keyboard with a line-feed key? I know that the "Enter" key on the num pad does not arrive as ASCII-3 (ETX, end-of-text) on all systems, right?

Best,

Marcel

Am 18.06.2021 08:03:02 schrieb [hidden email] <[hidden email]>:
Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-mt.945.mcz

==================== Summary ====================

Name: Collections-mt.945
Author: mt
Time: 18 June 2021, 8:02:50.788904 am
UUID: d551c74f-90b4-400a-8952-d9d4ff31e3bb
Ancestors: Collections-eem.944

Extends constant character names to support #return.

Fixes constant character names to work with all current constants, which, e.g., includes #arrowUp etc.

Drop #newPage in favor of #pageDown (and #pageUp). Note that #newPage still works as a constant. It will just not show up when you print a non-printable character.

=============== Diff against Collections-eem.944 ===============

Item was changed:
----- Method: Character class>>constantNames (in category 'private') -----
constantNames
+ ^ #( backspace delete return lf enter delete escape null space tab arrowDown arrowUp arrowLeft arrowRight end home pageDown pageUp euro insert )!
- ^ #( backspace cr delete escape lf null newPage space tab ).!

Item was added:
+ ----- Method: Character class>>return (in category 'accessing untypeable characters') -----
+ return
+ "Answer the Character representing a carriage return."
+
+ ^self value: 13!