The Trunk: Collections-nice.386.mcz

Nicolas Cellier uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-nice.386.mcz

==================== Summary ====================

Name: Collections-nice.386
Author: nice
Time: 1 October 2010, 10:37:30.237 pm
UUID: 14bfeb25-a255-4838-87d4-4c4dccac4b2d
Ancestors: Collections-nice.385

Remove #hashMappedBy: and #identityHashMappedBy:

=============== Diff against Collections-nice.385 ===============

Item was removed:
- ----- Method: Array>>hashMappedBy: (in category 'comparing') -----
- hashMappedBy: map
- "Answer what my hash would be if oops changed according to map."
-
- self size = 0 ifTrue: [^self hash].
- ^(self first hashMappedBy: map) + (self last hashMappedBy: map)!

Item was removed:
- ----- Method: Interval>>hashMappedBy: (in category 'comparing') -----
- hashMappedBy: map
- "My hash is independent of my oop."
-
- ^self hash!

Item was removed:
- ----- Method: LookupKey>>hashMappedBy: (in category 'comparing') -----
- hashMappedBy: map
- "Answer what my hash would be if oops changed according to map."
-
- ^key hashMappedBy: map!

Item was removed:
- ----- Method: LookupKey>>identityHashMappedBy: (in category 'comparing') -----
- identityHashMappedBy: map
- "Answer what my hash would be if oops changed according to map."
-
- ^ key identityHashMappedBy: map!

Item was removed:
- ----- Method: String>>hashMappedBy: (in category 'comparing') -----
- hashMappedBy: map
- "My hash is independent of my oop."
-
- ^self hash!

Item was removed:
- ----- Method: WeakKeyAssociation>>hashMappedBy: (in category 'comparing') -----
- hashMappedBy: map
- "Answer what my hash would be if oops changed according to map."
-
- ^self key hashMappedBy: map!

Item was removed:
- ----- Method: WeakKeyAssociation>>identityHashMappedBy: (in category 'comparing') -----
- identityHashMappedBy: map
- "Answer what my hash would be if oops changed according to map."
-
- ^ self key identityHashMappedBy: map!

On Fri, 1 Oct 2010, [hidden email] wrote:

I was thinking about this too, but if I'm not mistaken SystemTracer uses
these methods. If so, then these methods should be added to that package.
I'll check it later.


Levente

2010/10/1 Levente Uzonyi <[hidden email]>:
Check whether #newHash: is defined too.

On Fri, 1 Oct 2010, Nicolas Cellier wrote:
Both #hashMappedBy: and #identityHashMappedBy: is used by the
SystemTracer. #newHash: is defined by the SystemTracer. I'll move
#hashMappedBy: and #identityHashMappedBy: there.


Levente

On Fri, 1 Oct 2010, Levente Uzonyi wrote:

> On Fri, 1 Oct 2010, Nicolas Cellier wrote:

snip

>>
>> Check whether #newHash: is defined too.
>
> Both #hashMappedBy: and #identityHashMappedBy: is used by the SystemTracer.
> #newHash: is defined by the SystemTracer. I'll move #hashMappedBy: and

Note that the method is actually called #newHashFor:, not #newHash:.

> #identityHashMappedBy: there.

I moved #hashMappedBy: and #identityHashMappedBy: to SystemTracer
(SystemTracer-ul.18 on SqueakSource). While I was testing the changes I
found that SystemTracer is broken again. The tracing finishes, but the
resulting image doesn't work. I tried it with a Squeak 4.1 image too and
found that it's broken as well. Something changed between January and
April which broke SystemTracer. I someone would like to test/fix it, just
evaluate [ SystemTracer2 writeImage: 'test.image' ]. Then run the VM with
the new test.image file.


Levente

>
>
> Levente
>

snip

On Sun, 3 Oct 2010, Levente Uzonyi wrote:

I found the cause: since Squeak 4.1 Smalltalk is a SmalltalkImage and not
a SystemDictionary. But the SystemTracing package didn't add #wordSize: to
SmalltalkImage. So there was a DNU in the startup process of the new
image. Fixed in SystemTracing-ul.19.


Levente