The Trunk: Collections-topa.806.mcz
Locked
 
|
Nicolas Cellier uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-topa.806.mcz ==================== Summary ==================== Name: Collections-topa.806 Author: topa Time: 12 September 2018, 3:28:40.687052 pm UUID: 46b95db5-a773-4113-92f0-5ee905404b49 Ancestors: Collections-cmm.805 Fix separators to include U+00A0 (no break space) Thanks Ron! =============== Diff against Collections-cmm.805 =============== Item was changed: ----- Method: Character class>>separators (in category 'instance creation') ----- separators + "Answer a collection of space-like separator characters. + Note that we do not consider spaces in >8bit code points yet. + " - "Answer a collection of the standard ASCII separator characters." + ^ #(9 "tab" - ^ #(32 "space" - 13 "cr" - 9 "tab" 10 "line feed" + 12 "form feed" + 13 "cr" + 32 "space" + 160 "non-breaking space, see Unicode Z general category") + collect: [:v | Character value: v] as: String + " To be considered: + 16r1680 OGHAM SPACE MARK + 16r2000 EN QUAD + 16r2001 EM QUAD + 16r2002 EN SPACE + 16r2003 EM SPACE + 16r2004 THREE-PER-EM SPACE + 16r2005 FOUR-PER-EM SPACE + 16r2006 SIX-PER-EM SPACE + 16r2007 FIGURE SPACE + 16r2008 PUNCTUATION SPACE + 16r2009 THIN SPACE + 16r200A HAIR SPACE + 16r2028 LINE SEPARATOR + 16r2029 PARAGRAPH SEPARATOR + 16r202F NARROW NO-BREAK SPACE + 16r205F MEDIUM MATHEMATICAL SPACE + 16r3000 IDEOGRAPHIC SPACE + "! - 12 "form feed") - collect: [:v | Character value: v] as: String! Item was changed: + (PackageInfo named: 'Collections') postscript: 'CharacterSet cleanUp: false.'! - (PackageInfo named: 'Collections') postscript: 'Character initializeClassificationTable'! |
Re: The Trunk: Collections-topa.806.mcz
|
|
I thought we agreed not to integrate this. See
http://forum.world.st/The-Trunk-Collections-topa-806-mcz-td5084658.html Levente On Wed, 13 Feb 2019, [hidden email] wrote: > Nicolas Cellier uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-topa.806.mcz > > ==================== Summary ==================== > > Name: Collections-topa.806 > Author: topa > Time: 12 September 2018, 3:28:40.687052 pm > UUID: 46b95db5-a773-4113-92f0-5ee905404b49 > Ancestors: Collections-cmm.805 > > Fix separators to include U+00A0 (no break space) > > Thanks Ron! > > =============== Diff against Collections-cmm.805 =============== > > Item was changed: > ----- Method: Character class>>separators (in category 'instance creation') ----- > separators > + "Answer a collection of space-like separator characters. > + Note that we do not consider spaces in >8bit code points yet. > + " > - "Answer a collection of the standard ASCII separator characters." > > + ^ #(9 "tab" > - ^ #(32 "space" > - 13 "cr" > - 9 "tab" > 10 "line feed" > + 12 "form feed" > + 13 "cr" > + 32 "space" > + 160 "non-breaking space, see Unicode Z general category") > + collect: [:v | Character value: v] as: String > + " To be considered: > + 16r1680 OGHAM SPACE MARK > + 16r2000 EN QUAD > + 16r2001 EM QUAD > + 16r2002 EN SPACE > + 16r2003 EM SPACE > + 16r2004 THREE-PER-EM SPACE > + 16r2005 FOUR-PER-EM SPACE > + 16r2006 SIX-PER-EM SPACE > + 16r2007 FIGURE SPACE > + 16r2008 PUNCTUATION SPACE > + 16r2009 THIN SPACE > + 16r200A HAIR SPACE > + 16r2028 LINE SEPARATOR > + 16r2029 PARAGRAPH SEPARATOR > + 16r202F NARROW NO-BREAK SPACE > + 16r205F MEDIUM MATHEMATICAL SPACE > + 16r3000 IDEOGRAPHIC SPACE > + "! > - 12 "form feed") > - collect: [:v | Character value: v] as: String! > > Item was changed: > + (PackageInfo named: 'Collections') postscript: 'CharacterSet cleanUp: false.'! > - (PackageInfo named: 'Collections') postscript: 'Character initializeClassificationTable'! |
Re: The Trunk: Collections-topa.806.mcz
|
|
Okay, it sneaked into the ancestry with Collections-pre.818. That's
actually bad, and should be reverted. Levente On Wed, 13 Feb 2019, Levente Uzonyi wrote: > I thought we agreed not to integrate this. See > http://forum.world.st/The-Trunk-Collections-topa-806-mcz-td5084658.html > > Levente > > On Wed, 13 Feb 2019, [hidden email] wrote: > >> Nicolas Cellier uploaded a new version of Collections to project The Trunk: >> http://source.squeak.org/trunk/Collections-topa.806.mcz >> >> ==================== Summary ==================== >> >> Name: Collections-topa.806 >> Author: topa >> Time: 12 September 2018, 3:28:40.687052 pm >> UUID: 46b95db5-a773-4113-92f0-5ee905404b49 >> Ancestors: Collections-cmm.805 >> >> Fix separators to include U+00A0 (no break space) >> >> Thanks Ron! >> >> =============== Diff against Collections-cmm.805 =============== >> >> Item was changed: >> ----- Method: Character class>>separators (in category 'instance > creation') ----- >> separators >> + "Answer a collection of space-like separator characters. >> + Note that we do not consider spaces in >8bit code points yet. >> + " >> - "Answer a collection of the standard ASCII separator characters." >> >> + ^ #(9 "tab" >> - ^ #(32 "space" >> - 13 "cr" >> - 9 "tab" >> 10 "line feed" >> + 12 "form feed" >> + 13 "cr" >> + 32 "space" >> + 160 "non-breaking space, see Unicode Z general category") >> + collect: [:v | Character value: v] as: String >> + " To be considered: >> + 16r1680 OGHAM SPACE MARK >> + 16r2000 EN QUAD >> + 16r2001 EM QUAD >> + 16r2002 EN SPACE >> + 16r2003 EM SPACE >> + 16r2004 THREE-PER-EM SPACE >> + 16r2005 FOUR-PER-EM SPACE >> + 16r2006 SIX-PER-EM SPACE >> + 16r2007 FIGURE SPACE >> + 16r2008 PUNCTUATION SPACE >> + 16r2009 THIN SPACE >> + 16r200A HAIR SPACE >> + 16r2028 LINE SEPARATOR >> + 16r2029 PARAGRAPH SEPARATOR >> + 16r202F NARROW NO-BREAK SPACE >> + 16r205F MEDIUM MATHEMATICAL SPACE >> + 16r3000 IDEOGRAPHIC SPACE >> + "! >> - 12 "form feed") >> - collect: [:v | Character value: v] as: String! >> >> Item was changed: >> + (PackageInfo named: 'Collections') postscript: 'CharacterSet cleanUp: > false.'! >> - (PackageInfo named: 'Collections') postscript: 'Character > initializeClassificationTable'! > > |
Re: The Trunk: Collections-topa.806.mcz
|
|
Yes, sorry, after seeking cbc-Interval-related-changes, I wanted to clean a bit the inbox where there is too much cruft accumulated. I remembered that this change was rejected, but since it was in history, I moved it to trunk. Currently, this method is not active despite the ancestry. It could have been rejected as a merge conflict, but there is no merge conflict! Unless the Collections-topa.806 in ancestry was a different package? The ancestor ID is the same: 46b95db5-a773-4113-92f0-5ee905404b49 So it was just manually reverted by Patrick in Collections-pre.818 which is not a simple merge, but a merge + local changes. I see no problem in having
Collections-topa.806
in the history, though it's not very usefull. Note that 'browse revisions' menu does not mention this branch because it seems that it does not explore each and every branch. About UUID, note that anyone doing this cleaning must remember that MC interface is somehow dangerous. It marks ancestors with normal font and non ancestors with bold font. But this is based on ancestor name (the information we easily get from the server). Unfortunately, there are several instances of false ancestors (same package name-author-.number with different UUID) For example, all the Installer-Core packages currently in inbox are conflicting with the ones in trunk (different UUID, different contents). Once we click on the package, we have access to its UUID (which is displayed in the UI). Maybe the UI should mark it in bold red in order to warn us that this is a false ancestor! That would be helpful. Le mer. 13 févr. 2019 à 11:40, Levente Uzonyi <[hidden email]> a écrit : Okay, it sneaked into the ancestry with Collections-pre.818. That's |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |