The Trunk: CollectionsTests-ul.235.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: CollectionsTests-ul.235.mcz

commits-2
Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk:
http://source.squeak.org/trunk/CollectionsTests-ul.235.mcz

==================== Summary ====================

Name: CollectionsTests-ul.235
Author: ul
Time: 19 January 2015, 10:51:37.525 pm
UUID: 4e40f650-e20c-4e52-88f1-6b72e04f9a3a
Ancestors: CollectionsTests-mt.234

Don't reference the lastIndex variable, because it's gone. Use exact values instead.

=============== Diff against CollectionsTests-mt.234 ===============

Item was changed:
  ----- Method: OrderedDictionaryTest>>testCompact (in category 'tests') -----
  testCompact
 
  | oldCapacity |
  1 to: 3 do: [:ea |
  sut at: ea put: nil].
+ self assert: 3 equals: sut size.
- self assert: sut size equals: (sut instVarNamed: #lastIndex).
 
  sut removeKey: 2.
+ self assert: 2 equals: sut size.
- self assert: sut size equals: (sut instVarNamed: #lastIndex) - 1.
 
  oldCapacity := sut capacity.
  4 to: 20 do: [:ea |
  sut at: ea put: nil].
  self
  assert: sut capacity > oldCapacity;
+ assert: 19 equals: sut size
- assert: sut size equals: (sut instVarNamed: #lastIndex).
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: CollectionsTests-ul.235.mcz

Levente Uzonyi-2
This is an unintended commit of an old version of this package.
I'd delete/move it, but only admins can do that. So Board members,
please delete it, or move it to the Treated Inbox.

TIA,
Levente

On Sun, 5 Apr 2015, [hidden email] wrote:

> Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk:
> http://source.squeak.org/trunk/CollectionsTests-ul.235.mcz
>
> ==================== Summary ====================
>
> Name: CollectionsTests-ul.235
> Author: ul
> Time: 19 January 2015, 10:51:37.525 pm
> UUID: 4e40f650-e20c-4e52-88f1-6b72e04f9a3a
> Ancestors: CollectionsTests-mt.234
>
> Don't reference the lastIndex variable, because it's gone. Use exact values instead.
>
> =============== Diff against CollectionsTests-mt.234 ===============
>
> Item was changed:
>  ----- Method: OrderedDictionaryTest>>testCompact (in category 'tests') -----
>  testCompact
>
>   | oldCapacity |
>   1 to: 3 do: [:ea |
>   sut at: ea put: nil].
> + self assert: 3 equals: sut size.
> - self assert: sut size equals: (sut instVarNamed: #lastIndex).
>
>   sut removeKey: 2.
> + self assert: 2 equals: sut size.
> - self assert: sut size equals: (sut instVarNamed: #lastIndex) - 1.
>
>   oldCapacity := sut capacity.
>   4 to: 20 do: [:ea |
>   sut at: ea put: nil].
>   self
>   assert: sut capacity > oldCapacity;
> + assert: 19 equals: sut size
> - assert: sut size equals: (sut instVarNamed: #lastIndex).
>   !
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: CollectionsTests-ul.235.mcz

David T. Lewis
Version CollectionsTests-ul.235.mcz is deleted from trunk.

Dave


On Sun, Apr 05, 2015 at 10:43:29PM +0200, Levente Uzonyi wrote:

> This is an unintended commit of an old version of this package.
> I'd delete/move it, but only admins can do that. So Board members,
> please delete it, or move it to the Treated Inbox.
>
> TIA,
> Levente
>
> On Sun, 5 Apr 2015, [hidden email] wrote:
>
> >Levente Uzonyi uploaded a new version of CollectionsTests to project The
> >Trunk:
> >http://source.squeak.org/trunk/CollectionsTests-ul.235.mcz
> >
> >==================== Summary ====================
> >
> >Name: CollectionsTests-ul.235
> >Author: ul
> >Time: 19 January 2015, 10:51:37.525 pm
> >UUID: 4e40f650-e20c-4e52-88f1-6b72e04f9a3a
> >Ancestors: CollectionsTests-mt.234
> >
> >Don't reference the lastIndex variable, because it's gone. Use exact
> >values instead.
> >
> >=============== Diff against CollectionsTests-mt.234 ===============
> >
> >Item was changed:
> > ----- Method: OrderedDictionaryTest>>testCompact (in category 'tests')
> > -----
> > testCompact
> >
> > | oldCapacity |
> > 1 to: 3 do: [:ea |
> > sut at: ea put: nil].
> >+ self assert: 3 equals: sut size.
> >- self assert: sut size equals: (sut instVarNamed: #lastIndex).
> >
> > sut removeKey: 2.
> >+ self assert: 2 equals: sut size.
> >- self assert: sut size equals: (sut instVarNamed: #lastIndex) - 1.
> >
> > oldCapacity := sut capacity.
> > 4 to: 20 do: [:ea |
> > sut at: ea put: nil].
> > self
> > assert: sut capacity > oldCapacity;
> >+ assert: 19 equals: sut size
> >- assert: sut size equals: (sut instVarNamed: #lastIndex).
> > !
> >
> >
> >

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: CollectionsTests-ul.235.mcz

Levente Uzonyi-2
Thanks Dave!

Levente

On Sun, 5 Apr 2015, David T. Lewis wrote:

> Version CollectionsTests-ul.235.mcz is deleted from trunk.
>
> Dave
>
>
> On Sun, Apr 05, 2015 at 10:43:29PM +0200, Levente Uzonyi wrote:
>> This is an unintended commit of an old version of this package.
>> I'd delete/move it, but only admins can do that. So Board members,
>> please delete it, or move it to the Treated Inbox.
>>
>> TIA,
>> Levente
>>
>> On Sun, 5 Apr 2015, [hidden email] wrote:
>>
>>> Levente Uzonyi uploaded a new version of CollectionsTests to project The
>>> Trunk:
>>> http://source.squeak.org/trunk/CollectionsTests-ul.235.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: CollectionsTests-ul.235
>>> Author: ul
>>> Time: 19 January 2015, 10:51:37.525 pm
>>> UUID: 4e40f650-e20c-4e52-88f1-6b72e04f9a3a
>>> Ancestors: CollectionsTests-mt.234
>>>
>>> Don't reference the lastIndex variable, because it's gone. Use exact
>>> values instead.
>>>
>>> =============== Diff against CollectionsTests-mt.234 ===============
>>>
>>> Item was changed:
>>> ----- Method: OrderedDictionaryTest>>testCompact (in category 'tests')
>>> -----
>>> testCompact
>>>
>>> | oldCapacity |
>>> 1 to: 3 do: [:ea |
>>> sut at: ea put: nil].
>>> + self assert: 3 equals: sut size.
>>> - self assert: sut size equals: (sut instVarNamed: #lastIndex).
>>>
>>> sut removeKey: 2.
>>> + self assert: 2 equals: sut size.
>>> - self assert: sut size equals: (sut instVarNamed: #lastIndex) - 1.
>>>
>>> oldCapacity := sut capacity.
>>> 4 to: 20 do: [:ea |
>>> sut at: ea put: nil].
>>> self
>>> assert: sut capacity > oldCapacity;
>>> + assert: 19 equals: sut size
>>> - assert: sut size equals: (sut instVarNamed: #lastIndex).
>>> !
>>>
>>>
>>>
>
>