The Trunk: Compiler-eem.304.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Compiler-eem.304.mcz

commits-2
Eliot Miranda uploaded a new version of Compiler to project The Trunk:
http://source.squeak.org/trunk/Compiler-eem.304.mcz

==================== Summary ====================

Name: Compiler-eem.304
Author: eem
Time: 8 July 2015, 5:15:09.812 pm
UUID: 3b07ef9d-69d2-424d-845c-affde45643b8
Ancestors: Compiler-topa.302

Fix stack depth regression from Compiler-eem.300; this time with the correct version number for the MC package.

=============== Diff against Compiler-topa.302 ===============

Item was changed:
  ----- Method: BlockNode>>emitCodeForEvaluatedClosureValue:encoder: (in category 'code generation (closures)') -----
  emitCodeForEvaluatedClosureValue: stack encoder: encoder
  | position |
  position := stack position.
+ stack position: arguments size + temporaries size + copiedValues size.
- stack position: arguments size + copiedValues size.
  encoder genPushNClosureTemps: temporaries size.
  self
  reindexingLocalsDo: [self emitCodeForEvaluatedValue: stack encoder: encoder]
  encoder: encoder.
  self returns ifFalse:
  [encoder genReturnTopToCaller.
  pc := encoder methodStreamPosition].
  stack position: position!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Compiler-eem.304.mcz

David T. Lewis
Confirming - this fixes the problem of interpreter VM crashes after a system
recompile, so this is the version that should go into the 4.6/5.0 release.

Thanks!

Dave

On Thu, Jul 09, 2015 at 12:15:16AM +0000, [hidden email] wrote:

> Eliot Miranda uploaded a new version of Compiler to project The Trunk:
> http://source.squeak.org/trunk/Compiler-eem.304.mcz
>
> ==================== Summary ====================
>
> Name: Compiler-eem.304
> Author: eem
> Time: 8 July 2015, 5:15:09.812 pm
> UUID: 3b07ef9d-69d2-424d-845c-affde45643b8
> Ancestors: Compiler-topa.302
>
> Fix stack depth regression from Compiler-eem.300; this time with the correct version number for the MC package.
>
> =============== Diff against Compiler-topa.302 ===============
>
> Item was changed:
>   ----- Method: BlockNode>>emitCodeForEvaluatedClosureValue:encoder: (in category 'code generation (closures)') -----
>   emitCodeForEvaluatedClosureValue: stack encoder: encoder
>   | position |
>   position := stack position.
> + stack position: arguments size + temporaries size + copiedValues size.
> - stack position: arguments size + copiedValues size.
>   encoder genPushNClosureTemps: temporaries size.
>   self
>   reindexingLocalsDo: [self emitCodeForEvaluatedValue: stack encoder: encoder]
>   encoder: encoder.
>   self returns ifFalse:
>   [encoder genReturnTopToCaller.
>   pc := encoder methodStreamPosition].
>   stack position: position!
>