The Trunk: Compiler-mt.324.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Compiler-mt.324.mcz

commits-2
Marcel Taeumel uploaded a new version of Compiler to project The Trunk:
http://source.squeak.org/trunk/Compiler-mt.324.mcz

==================== Summary ====================

Name: Compiler-mt.324
Author: mt
Time: 31 July 2016, 11:10:04.90449 am
UUID: f8b4e0ae-171c-8541-ae32-656183633ad6
Ancestors: Compiler-eem.323

*** Widget Refactorings and UI Themes (Part 5 of 11) ***

Some fixes and refactorings for dialogs including added support for UI theming.

=============== Diff against Compiler-eem.323 ===============

Item was changed:
  ----- Method: UndefinedVariable>>openMenuIn: (in category 'as yet unclassified') -----
  openMenuIn: aBlock
- | labels caption index |
- labels := #('yes' 'no').
- caption := name, ' appears to be
- undefined at this point.
- Proceed anyway?'.
 
+ ^ self resume: (UIManager default
+ confirm: name asText allBold, ' appears to be undefined at this point.\Proceed anyway?' withCRs
+ title: 'Undefined Variable').!
- index := aBlock value: labels value: #() value: caption.
- ^ self resume: index = 1!

Item was changed:
  ----- Method: UnknownSelector>>openMenuIn: (in category 'as yet unclassified') -----
  openMenuIn: aBlock
  | alternatives labels lines caption choice |
  alternatives := Symbol possibleSelectorsFor: name.
  labels := Array streamContents:
+ [:s | s nextPut: name; nextPutAll: alternatives].
- [:s | s nextPut: name; nextPutAll: alternatives; nextPut: 'cancel'].
  lines := {1. alternatives size + 1}.
  caption := 'Unknown selector, please\confirm, correct, or cancel' withCRs.
 
  choice := aBlock value: labels value: lines value: caption.
+
+ choice = 0 ifTrue: [^ self resume: nil].
+ choice = 1 ifTrue: [^ self resume: name asSymbol].
- choice = 0 ifTrue: [self resume: nil].
- choice = 1 ifTrue: [self resume: name asSymbol].
- choice = labels size ifTrue: [self resume: nil].
  self resume: (alternatives at: choice - 1)!

Item was changed:
  ----- Method: UnusedVariable>>openMenuIn: (in category 'as yet unclassified') -----
  openMenuIn: aBlock
+
+ self resume: (UIManager default
+ confirm: name asText allBold, ' appears to be unused in this method.\Remove it from the code?' withCRs
+ title: 'Unused Variable').!
- | index |
- index := aBlock value: #('yes' 'no')
- value: #()
- value: name, ' appears to be\unused in this method.\OK to remove it?' withCRs.
- self resume: index = 1!