The Trunk: Compiler-topa.302.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Compiler-topa.302.mcz

commits-2
Tobias Pape uploaded a new version of Compiler to project The Trunk:
http://source.squeak.org/trunk/Compiler-topa.302.mcz

==================== Summary ====================

Name: Compiler-topa.302
Author: topa
Time: 6 July 2015, 5:23:17.205 pm
UUID: 503dc5a6-5953-49d7-ba6b-5ca0d7de4e3c
Ancestors: Compiler-eem.301

Don't be too strict if BlockNode scope setting is idempotent

=============== Diff against Compiler-eem.301 ===============

Item was changed:
  ----- Method: TempVariableNode>>definingScope: (in category 'code generation (closures)') -----
  definingScope: scopeBlock "<BlockNode>"
+ definingScope = scopeBlock ifTrue: [^ self]. "No need to bail"
  definingScope ifNotNil:
  [self error: 'temp has more than one defining scope.  This is probably a parser error'].
  definingScope := scopeBlock!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Compiler-topa.302.mcz

Eliot Miranda-2
Hi Tobias,

     I'm curious.  What tickles this bug?

Eliot (phone)

On Jul 6, 2015, at 8:50 AM, [hidden email] wrote:

> Tobias Pape uploaded a new version of Compiler to project The Trunk:
> http://source.squeak.org/trunk/Compiler-topa.302.mcz
>
> ==================== Summary ====================
>
> Name: Compiler-topa.302
> Author: topa
> Time: 6 July 2015, 5:23:17.205 pm
> UUID: 503dc5a6-5953-49d7-ba6b-5ca0d7de4e3c
> Ancestors: Compiler-eem.301
>
> Don't be too strict if BlockNode scope setting is idempotent
>
> =============== Diff against Compiler-eem.301 ===============
>
> Item was changed:
>  ----- Method: TempVariableNode>>definingScope: (in category 'code generation (closures)') -----
>  definingScope: scopeBlock "<BlockNode>"
> +    definingScope = scopeBlock ifTrue: [^ self]. "No need to bail"
>      definingScope ifNotNil:
>          [self error: 'temp has more than one defining scope.  This is probably a parser error'].
>      definingScope := scopeBlock!
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Compiler-topa.302.mcz

Tobias Pape

On 06.07.2015, at 17:55, Eliot Miranda <[hidden email]> wrote:

> Hi Tobias,
>
>     I'm curious.  What tickles this bug?
>

The Prolog implementation on SqueakMap


> Eliot (phone)
>
> On Jul 6, 2015, at 8:50 AM, [hidden email] wrote:
>
>> Tobias Pape uploaded a new version of Compiler to project The Trunk:
>> http://source.squeak.org/trunk/Compiler-topa.302.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Compiler-topa.302
>> Author: topa
>> Time: 6 July 2015, 5:23:17.205 pm
>> UUID: 503dc5a6-5953-49d7-ba6b-5ca0d7de4e3c
>> Ancestors: Compiler-eem.301
>>
>> Don't be too strict if BlockNode scope setting is idempotent
>>
>> =============== Diff against Compiler-eem.301 ===============
>>
>> Item was changed:
>> ----- Method: TempVariableNode>>definingScope: (in category 'code generation (closures)') -----
>> definingScope: scopeBlock "<BlockNode>"
>> +    definingScope = scopeBlock ifTrue: [^ self]. "No need to bail"
>>     definingScope ifNotNil:
>>         [self error: 'temp has more than one defining scope.  This is probably a parser error'].
>>     definingScope := scopeBlock!