The Trunk: EToys-mt.329.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: EToys-mt.329.mcz

commits-2
Marcel Taeumel uploaded a new version of EToys to project The Trunk:
http://source.squeak.org/trunk/EToys-mt.329.mcz

==================== Summary ====================

Name: EToys-mt.329
Author: mt
Time: 24 May 2018, 12:07:52.536891 pm
UUID: 757b522b-abb0-4cf5-a965-fc6dd8271efa
Ancestors: EToys-mt.328

Workaround for the mouse-down-focus issue regarding dialog invocation.

Note that even though we have an unresolved issue in the Morphic event handling here, the rule of thumb is that you as an application developer should trigger such effects on mouse-up, not mouse-down. See buttons etc. in Windows or macOS.

=============== Diff against EToys-mt.328 ===============

Item was removed:
- ----- Method: MenuTile>>mouseDown: (in category 'event handling') -----
- mouseDown: evt
- | aPoint reply choices |
- aPoint := evt cursorPoint.
- nArrowTicks := 0.
- ((upArrow bounds containsPoint: aPoint) or: [downArrow bounds containsPoint: aPoint]) ifTrue: [^ self mouseStillDown: evt].
- choices := ((self ownerThatIsA: PhraseTileMorph) associatedPlayer costume allMenuWordings) copyWithout: ''.
- reply := UIManager default chooseFrom: choices values: choices.
- reply ifNotNil: [self literal: reply; layoutChanged]!

Item was added:
+ ----- Method: MenuTile>>mouseUp: (in category 'event handling') -----
+ mouseUp: evt
+ | aPoint reply choices |
+ aPoint := evt cursorPoint.
+ nArrowTicks := 0.
+ ((upArrow bounds containsPoint: aPoint) or: [downArrow bounds containsPoint: aPoint]) ifTrue: [^ self mouseStillDown: evt].
+ choices := ((self ownerThatIsA: PhraseTileMorph) associatedPlayer costume allMenuWordings) copyWithout: ''.
+ reply := UIManager default chooseFrom: choices values: choices.
+ reply ifNotNil: [self literal: reply; layoutChanged]!