The Trunk: EToys-nice.323.mcz

> On 06.04.2018, at 23:08, [hidden email] wrote:
>
> Nicolas Cellier uploaded a new version of EToys to project The Trunk:
> http://source.squeak.org/trunk/EToys-nice.323.mcz
>
> ==================== Summary ====================
>
> Name: EToys-nice.323
> Author: nice
> Time: 6 April 2018, 11:08:06.003784 pm
> UUID: 9cc67174-4ffd-4a87-9b85-aa82ba03b3a6
> Ancestors: EToys-tpr.322
>
> Fix the incorrect SoundService default initialization (see this package postscript for an explanation)
>
> Remove un-necessary Boolean>>xor:
>
> Sort the categories.
>
> =============== Diff against EToys-tpr.322 ===============
>
> Item was changed:
>  SystemOrganization addCategory: #'Etoys-Buttons'!
>  SystemOrganization addCategory: #'Etoys-CustomEvents'!
>  SystemOrganization addCategory: #'Etoys-Experimental'!
> + SystemOrganization addCategory: #'Etoys-OLPC-Display'!
>  SystemOrganization addCategory: #'Etoys-Outliner'!
>  SystemOrganization addCategory: #'Etoys-Protocols'!
>  SystemOrganization addCategory: #'Etoys-Protocols-Type Vocabularies'!
> + SystemOrganization addCategory: #'Etoys-ReleaseBuilder'!
>  SystemOrganization addCategory: #'Etoys-Scripting'!
>  SystemOrganization addCategory: #'Etoys-Scripting Support'!
>  SystemOrganization addCategory: #'Etoys-Scripting Tiles'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-BroomMorphs-Base'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-BroomMorphs-Connectors'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-EToys-Kedama'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Buttons'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Calendar'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Debugger'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Help'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Input'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Scripting'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Scripting Support'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Scripting Tiles'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-SpeechBubbles'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Etoys-Tile Scriptors'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Graphics-Text'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Graphics-Tools-Intersection'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Graphics-Tools-Simplification'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Graphics-Tools-Triangulation'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-AdditionalMorphs'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Charts'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Postscript Filters'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-WebCam'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Widgets'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Basic'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Books'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Components'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Demo'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Experimental'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Games'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Games-Chess'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-GeeMail'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Kernel'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Mentoring'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Navigators'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-PartsBin'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-PDA'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-PartsBin'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Support'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Widgets'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Windows'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Morphic-Worlds'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-AdditionalMorphs'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Charts'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Postscript Filters'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-WebCam'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-MorphicExtras-Widgets'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Multilingual-Languages'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Multilingual-TextConversion'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-HTML-Formatter'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-HTML-Forms'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-HTML-Parser'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-HTML-Parser Entities'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-HTML-Tokenizer'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-MIME'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-TelNet WordNet'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-UI'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Network-Url'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Protocols-Type Vocabularies'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-SISS-Serialization'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-ST80-Morphic'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-SUnit'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Sound-Interface'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Sound-Ogg'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Sound-Scores'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-ST80-Morphic'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-SUnit'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Sugar'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-Support'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-System-Clipboard-Extended'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-System-Compiler'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-System-Exceptions Kernel'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-System-Support'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Tools-Changes'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Tools-Explorer'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Tools-Process Browser'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Tweak-Kedama-ObjectVectors'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-Tweak-Kedama-ParseTreeTransformer'!
>  SystemOrganization addCategory: #'Etoys-Squeakland-Tweak-Kedama-ParseTree-AttributeDefinition'!
> + SystemOrganization addCategory: #'Etoys-Squeakland-Tweak-Kedama-ParseTreeTransformer'!
>  SystemOrganization addCategory: #'Etoys-Stacks'!
>  SystemOrganization addCategory: #'Etoys-StarSqueak'!
>  SystemOrganization addCategory: #'Etoys-Support'!
>  SystemOrganization addCategory: #'Etoys-Tests'!
>  SystemOrganization addCategory: #'Etoys-Tile Scriptors'!
> - SystemOrganization addCategory: #'Etoys-Widgets'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-Support'!
> - SystemOrganization addCategory: #'Etoys-Squeakland-SISS-Serialization'!
> - SystemOrganization addCategory: #'Etoys-OLPC-Display'!
> - SystemOrganization addCategory: #'Etoys-ReleaseBuilder'!
>  SystemOrganization addCategory: #'Etoys-UserInterfaceTheme'!
> + SystemOrganization addCategory: #'Etoys-Widgets'!
>
> Item was removed:
> - ----- Method: Boolean>>xor: (in category '*Etoys-Squeakland-logical operations') -----
> - xor: aBoolean
> - "Exclusive OR. Answer true if the receiver is not equivalent to aBoolean."
> -
> - ^(self == aBoolean) not!
>
> Item was changed:
>  ----- Method: TileMorphTest>>setUp (in category 'running') -----
>  setUp
> + soundSystemBackup := SoundService default: (self class environment at: #BaseSoundSystem ifAbsent: [nil]).!
> -
> - self soundSystemBackup: SoundService defaultOrNil.
> - SoundService default: (self class environment at: #BaseSoundSystem ifAbsent: [nil]).!
>
> Item was removed:
> - ----- Method: TileMorphTest>>soundSystemBackup (in category 'accessing') -----
> - soundSystemBackup
> -
> - ^ soundSystemBackup!
>
> Item was removed:
> - ----- Method: TileMorphTest>>soundSystemBackup: (in category 'accessing') -----
> - soundSystemBackup: anObject
> -
> - soundSystemBackup := anObject!
>
> Item was changed:
>  ----- Method: TileMorphTest>>tearDown (in category 'running') -----
>  tearDown
>
> + SoundService default: soundSystemBackup.!
> - SoundService default: self soundSystemBackup.!
>
> Item was changed:
>  (PackageInfo named: 'EToys') postscript: 'KedamaMorph allInstancesDo: [ :each |
>   (each instVarNamed: #turtlesToDisplay) ifNotNil: [ :turtlesToDisplay |
>   turtlesToDisplay class == Array ifTrue: [
> + each instVarNamed: #turtlesToDisplay put: turtlesToDisplay asSet ] ] ].
> +
> + "Fix SoundService default.
> + One must not invoke this:
> +     SoundService default: SoundService defaultOrNil.
> + because it fills the class inst var ''default'' with an instance instead of a class.
> + This script checks if that ever happened and tries to restore a healthy default."
> + (SoundService instVarNamed: #default)
> + ifNotNil: [:ss | ss isBehavior ifFalse: [SoundService unregister: ss; default: ss class]].'!
> - each instVarNamed: #turtlesToDisplay put: turtlesToDisplay asSet ] ] ]'!
>
>

> On 06.04.2018, at 23:43, Tobias Pape <[hidden email]> wrote:
>
>
>> +
>> + "Fix SoundService default.
>> + One must not invoke this:
>> +     SoundService default: SoundService defaultOrNil.
>> + because it fills the class inst var ''default'' with an instance instead of a class.
>> + This script checks if that ever happened and tries to restore a healthy default."
>> + (SoundService instVarNamed: #default)
>> + ifNotNil: [:ss | ss isBehavior ifFalse: [SoundService unregister: ss; default: ss class]].'!
>> - each instVarNamed: #turtlesToDisplay put: turtlesToDisplay asSet ] ] ]'!
>>
>>
> Hm, IIRC it was me who changed the class to an Instance. there was a reason, also…
>
> But it escaped my memory…
>