The Trunk: Environments-cwp.18.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Environments-cwp.18.mcz

commits-2
Colin Putney uploaded a new version of Environments to project The Trunk:
http://source.squeak.org/trunk/Environments-cwp.18.mcz

==================== Summary ====================

Name: Environments-cwp.18
Author: cwp
Time: 11 March 2013, 6:14:54.348 pm
UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
Ancestors: Environments-nice.17

Make Environment>>at:put: use existing bindings from Undeclared.

=============== Diff against Environments-nice.17 ===============

Item was changed:
  ----- Method: Environment>>at:put: (in category 'emulating') -----
  at: aSymbol put: anObject
  | binding |
+ (contents includesKey: aSymbol)
+ ifTrue: [contents at: aSymbol put: anObject]
+ ifFalse:
+ [(undeclared includesKey: aSymbol)
+ ifTrue:
+ [contents declare: aSymbol from: undeclared.
+ contents at: aSymbol put: anObject]
+ ifFalse:
+ [binding := anObject isBehavior
+ ifTrue: [Binding key: aSymbol value: anObject]
+ ifFalse: [Association key: aSymbol value: anObject].
+ contents add: binding.
+ exports bind: binding]].
- binding := anObject isBehavior
- ifTrue: [Binding key: aSymbol value: anObject]
- ifFalse: [Association key: aSymbol value: anObject].
- contents add: binding.
- exports bind: binding.
  ^ anObject
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Environments-cwp.18.mcz

Frank Shearar-3
On 12 March 2013 01:14,  <[hidden email]> wrote:

> Colin Putney uploaded a new version of Environments to project The Trunk:
> http://source.squeak.org/trunk/Environments-cwp.18.mcz
>
> ==================== Summary ====================
>
> Name: Environments-cwp.18
> Author: cwp
> Time: 11 March 2013, 6:14:54.348 pm
> UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
> Ancestors: Environments-nice.17
>
> Make Environment>>at:put: use existing bindings from Undeclared.
>
> =============== Diff against Environments-nice.17 ===============

OK, looks like we're back in business:
http://build.squeak.org/job/SqueakTrunk/221/

114 failing tests because of the Decompiler side of things, but that's
a lot better than hung builds.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Environments-cwp.18.mcz

Eliot Miranda-2


On Tue, Mar 12, 2013 at 6:48 AM, Frank Shearar <[hidden email]> wrote:
On 12 March 2013 01:14,  <[hidden email]> wrote:
> Colin Putney uploaded a new version of Environments to project The Trunk:
> http://source.squeak.org/trunk/Environments-cwp.18.mcz
>
> ==================== Summary ====================
>
> Name: Environments-cwp.18
> Author: cwp
> Time: 11 March 2013, 6:14:54.348 pm
> UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
> Ancestors: Environments-nice.17
>
> Make Environment>>at:put: use existing bindings from Undeclared.
>
> =============== Diff against Environments-nice.17 ===============

OK, looks like we're back in business:
http://build.squeak.org/job/SqueakTrunk/221/

114 failing tests because of the Decompiler side of things, but that's
a lot better than hung builds.

Shall I fix the decompiler? 


--
best,
Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Environments-cwp.18.mcz

Frank Shearar-3
Yes, please! I daresay I would take a mere 982374238 times longer to do it.

frank

(Sorry about the repost, Eliot: I hadn't noticed that I'd only replied to you.)

On 12 March 2013 18:08, Eliot Miranda <[hidden email]> wrote:

>
>
> On Tue, Mar 12, 2013 at 6:48 AM, Frank Shearar <[hidden email]>
> wrote:
>>
>> On 12 March 2013 01:14,  <[hidden email]> wrote:
>> > Colin Putney uploaded a new version of Environments to project The
>> > Trunk:
>> > http://source.squeak.org/trunk/Environments-cwp.18.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: Environments-cwp.18
>> > Author: cwp
>> > Time: 11 March 2013, 6:14:54.348 pm
>> > UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
>> > Ancestors: Environments-nice.17
>> >
>> > Make Environment>>at:put: use existing bindings from Undeclared.
>> >
>> > =============== Diff against Environments-nice.17 ===============
>>
>> OK, looks like we're back in business:
>> http://build.squeak.org/job/SqueakTrunk/221/
>>
>> 114 failing tests because of the Decompiler side of things, but that's
>> a lot better than hung builds.
>>
> Shall I fix the decompiler?
>
>
> --
> best,
> Eliot

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Environments-cwp.18.mcz

Eliot Miranda-2


On Tue, Mar 12, 2013 at 11:14 AM, Frank Shearar <[hidden email]> wrote:
Yes, please! I daresay I would take a mere 982374238 times longer to do it.

frank

(Sorry about the repost, Eliot: I hadn't noticed that I'd only replied to you.)

I only do that several times a week :(
 

On 12 March 2013 18:08, Eliot Miranda <[hidden email]> wrote:
>
>
> On Tue, Mar 12, 2013 at 6:48 AM, Frank Shearar <[hidden email]>
> wrote:
>>
>> On 12 March 2013 01:14,  <[hidden email]> wrote:
>> > Colin Putney uploaded a new version of Environments to project The
>> > Trunk:
>> > http://source.squeak.org/trunk/Environments-cwp.18.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: Environments-cwp.18
>> > Author: cwp
>> > Time: 11 March 2013, 6:14:54.348 pm
>> > UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
>> > Ancestors: Environments-nice.17
>> >
>> > Make Environment>>at:put: use existing bindings from Undeclared.
>> >
>> > =============== Diff against Environments-nice.17 ===============
>>
>> OK, looks like we're back in business:
>> http://build.squeak.org/job/SqueakTrunk/221/
>>
>> 114 failing tests because of the Decompiler side of things, but that's
>> a lot better than hung builds.
>>
> Shall I fix the decompiler?
>
>
> --
> best,
> Eliot



--
best,
Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Environments-cwp.18.mcz

Nicolas Cellier
2013/3/12 Eliot Miranda <[hidden email]>:

>
>
> On Tue, Mar 12, 2013 at 11:14 AM, Frank Shearar <[hidden email]>
> wrote:
>>
>> Yes, please! I daresay I would take a mere 982374238 times longer to do
>> it.
>>
>> frank
>>
>> (Sorry about the repost, Eliot: I hadn't noticed that I'd only replied to
>> you.)
>
>
> I only do that several times a week :(
>

Under that rate, it's better to not touch Decompiler code, it's too complex ;)

Nicolas

>>
>>
>> On 12 March 2013 18:08, Eliot Miranda <[hidden email]> wrote:
>> >
>> >
>> > On Tue, Mar 12, 2013 at 6:48 AM, Frank Shearar <[hidden email]>
>> > wrote:
>> >>
>> >> On 12 March 2013 01:14,  <[hidden email]> wrote:
>> >> > Colin Putney uploaded a new version of Environments to project The
>> >> > Trunk:
>> >> > http://source.squeak.org/trunk/Environments-cwp.18.mcz
>> >> >
>> >> > ==================== Summary ====================
>> >> >
>> >> > Name: Environments-cwp.18
>> >> > Author: cwp
>> >> > Time: 11 March 2013, 6:14:54.348 pm
>> >> > UUID: f39db45e-d4c9-49bb-ada1-b0120783635c
>> >> > Ancestors: Environments-nice.17
>> >> >
>> >> > Make Environment>>at:put: use existing bindings from Undeclared.
>> >> >
>> >> > =============== Diff against Environments-nice.17 ===============
>> >>
>> >> OK, looks like we're back in business:
>> >> http://build.squeak.org/job/SqueakTrunk/221/
>> >>
>> >> 114 failing tests because of the Decompiler side of things, but that's
>> >> a lot better than hung builds.
>> >>
>> > Shall I fix the decompiler?
>> >
>> >
>> > --
>> > best,
>> > Eliot
>
>
>
>
> --
> best,
> Eliot
>
>
>