The Trunk: Files-cwp.29.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Files-cwp.29.mcz

commits-2
Colin Putney uploaded a new version of Files to project The Trunk:
http://source.squeak.org/trunk/Files-cwp.29.mcz

==================== Summary ====================

Name: Files-cwp.29
Author: cwp
Time: 16 November 2009, 8:55:14 am
UUID: 611708f0-1f6e-449c-a966-1e5bf3e10a0d
Ancestors: Files-ar.28

Replaced #asLowercase with #asString in FileDirectory>>hash, because a) #= uses #asString and b) FilePath doesn't implement #asLowercase.

=============== Diff against Files-ar.28 ===============

Item was changed:
  ----- Method: FileDirectory>>hash (in category 'comparing') -----
  hash
  "Hash is reimplemented because #= is reimplemented"
+ ^pathName asString hash!
- ^pathName asLowercase hash!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Files-cwp.29.mcz

Bert Freudenberg

On 16.11.2009, at 17:55, [hidden email] wrote:

> Colin Putney uploaded a new version of Files to project The Trunk:
> http://source.squeak.org/trunk/Files-cwp.29.mcz
>
> ==================== Summary ====================
>
> Name: Files-cwp.29
> Author: cwp
> Time: 16 November 2009, 8:55:14 am
> UUID: 611708f0-1f6e-449c-a966-1e5bf3e10a0d
> Ancestors: Files-ar.28
>
> Replaced #asLowercase with #asString in FileDirectory>>hash, because a) #= uses #asString and b) FilePath doesn't implement #asLowercase.
>
> =============== Diff against Files-ar.28 ===============
>
> Item was changed:
>  ----- Method: FileDirectory>>hash (in category 'comparing') -----
>  hash
>   "Hash is reimplemented because #= is reimplemented"
> + ^pathName asString hash!
> - ^pathName asLowercase hash!

This needs to be "^pathName asString asLowercase hash" to match the behavior of #=.

- Bert -