The Trunk: Graphics-dtl.335.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Graphics-dtl.335.mcz

commits-2
Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-dtl.335.mcz

==================== Summary ====================

Name: Graphics-dtl.335
Author: dtl
Time: 11 May 2016, 11:25:12.450775 pm
UUID: df71df68-b235-49be-b4a5-bebb84cb420a
Ancestors: Graphics-mt.334

DisplayScreen class>>hostWindowExtent: uses the host window plugin to set the size of the main Squeak display window. Add the complementary #hostWindowExtent to query the plugin for display size. Requires VM support for HostWindowPlugin.

Assuming required support from VM HostWindowPlugin:
        Display width @ Display height = DisplayScreen hostWindowExtent ==> true

Recategorize methods for plugin access, and add a method comment to explain the convention of treating host window index 1 as a reference to the Squeak display window.

=============== Diff against Graphics-mt.334 ===============

Item was added:
+ ----- Method: DisplayScreen class>>hostWindowExtent (in category 'host window access') -----
+ hostWindowExtent
+
+ ^ self primitiveWindowSize: self hostWindowIndex
+ !

Item was changed:
  ----- Method: DisplayScreen class>>hostWindowIndex (in category 'host window access') -----
  hostWindowIndex
+ "By convention, the reference to the primary Squeak display window is 1.
+ The host window plugin may use different conventions for references to
+ windows. In general, the handles for references to host windows should be
+ considered as meaningful only to the VM plugin, with host window index 1
+ being a special case of a well known handle value."
 
  ^ 1!

Item was changed:
+ ----- Method: DisplayScreen class>>primitiveWindow:title: (in category 'primitives - host window access') -----
- ----- Method: DisplayScreen class>>primitiveWindow:title: (in category 'host window access') -----
  primitiveWindow: id title: titleString
 
  <primitive: 'primitiveHostWindowTitle' module: 'HostWindowPlugin'>
  ^self primitiveFailed!

Item was changed:
+ ----- Method: DisplayScreen class>>primitiveWindow:width:height: (in category 'primitives - host window access') -----
- ----- Method: DisplayScreen class>>primitiveWindow:width:height: (in category 'host window access') -----
  primitiveWindow: id width: width height: height
 
  <primitive: 'primitiveHostWindowSizeSet' module: 'HostWindowPlugin'>
  ^self primitiveFailed!

Item was added:
+ ----- Method: DisplayScreen class>>primitiveWindowSize: (in category 'primitives - host window access') -----
+ primitiveWindowSize: id
+
+ <primitive: 'primitiveHostWindowSize' module: 'HostWindowPlugin'>
+ ^self primitiveFailed!