The Trunk: Graphics-eem.198.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Graphics-eem.198.mcz

commits-2
Eliot Miranda uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-eem.198.mcz

==================== Summary ====================

Name: Graphics-eem.198
Author: eem
Time: 21 February 2013, 10:04:53.833 am
UUID: 4befb974-1a08-4b8d-8e11-779b3f71c210
Ancestors: Graphics-bf.197

Fix MNU in Smalltalk specialObjectsArray printString.
Point>>printOn: shouldn't assume its inst vars are numbers.

=============== Diff against Graphics-bf.197 ===============

Item was changed:
  ----- Method: Point>>printOn: (in category 'printing') -----
  printOn: aStream
  "The receiver prints on aStream in terms of infix notation."
 
  x printOn: aStream.
  aStream nextPut: $@.
+ (y isInteger and: [y negative]) ifTrue:
- y negative ifTrue: [
  "Avoid ambiguous @- construct"
+ [aStream space].
- aStream space].
  y printOn: aStream!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Graphics-eem.198.mcz

Stéphane Rollandin
> + (y isInteger and: [y negative]) ifTrue:

I would propose you make it #isNumber, because a Point may have
non-integer inst vars (I do use such points)

Cheers,

Stef

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Graphics-eem.198.mcz

Eliot Miranda-2
Doh!

On Thu, Feb 21, 2013 at 10:12 AM, Stéphane Rollandin
<[hidden email]> wrote:

>> +       (y isInteger and: [y negative]) ifTrue:
>
>
> I would propose you make it #isNumber, because a Point may have non-integer
> inst vars (I do use such points)
>
> Cheers,
>
> Stef
>



--
best,
Eliot