The Trunk: Graphics-mt.358.mcz

Chris Muller-3 wrote

Something with the themes is affecting the picture preview.  Try
Solarized (Dark) and then look at .jpg or .png previews in the
FileList -- they are no longer true to the original colors.

Best,
  Chris

On Wed, Aug 10, 2016 at 3:05 AM,  <[hidden email]> wrote:
> Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
> http://source.squeak.org/trunk/Graphics-mt.358.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-mt.358
> Author: mt
> Time: 10 August 2016, 10:05:35.189696 am
> UUID: fe4bd6ca-d161-bf4c-b0b9-8fd1812d38a8
> Ancestors: Graphics-mt.357
>
> Fixes regression in FileList graphics preview, which expects a certain callback in a certain file service. *sigh* I guess to also assume a certain type of result. *double-sigh*
>
> See FileList >> #isGraphicsFileSelected.
>
> =============== Diff against Graphics-mt.357 ===============
>
> Item was added:
> + ----- Method: Form class>>serviceImageImportAndShowImports (in category 'file list services') -----
> + serviceImageImportAndShowImports
> +       "Answer a service for reading a graphic into ImageImports"
> +
> +       ^       SimpleServiceEntry
> +                       provider: self
> +                       label: 'read graphic into and show ImageImports'
> +                       selector: #importImageAndShowImports:
> +                       description: 'Load a graphic, placing it in the ImageImports repository and browse that repository.'
> +                       buttonLabel: 'import'!
>
> Item was changed:
>   ----- Method: Form class>>serviceImageImports (in category 'file list services') -----
>   serviceImageImports
>         "Answer a service for reading a graphic into ImageImports"
>
>         ^       SimpleServiceEntry
>                         provider: self
>                         label: 'read graphic into ImageImports'
> +                       selector: #importImage:
> -                       selector: #importImageAndShowImports:
>                         description: 'Load a graphic, placing it in the ImageImports repository.'
>                         buttonLabel: 'import'!
>
> Item was changed:
>   ----- Method: Form class>>services (in category 'file list services') -----
>   services
>
>         ^ Array
>                 with: self serviceImageImports
> +               with: self serviceImageImportAndShowImports
>                 with: self serviceOpenImageInWindow
>                 with: self serviceImageAsBackground !
>
>

marcel.taeumel wrote

Chris Muller-3 wrote

Something with the themes is affecting the picture preview.  Try
Solarized (Dark) and then look at .jpg or .png previews in the
FileList -- they are no longer true to the original colors.

Best,
  Chris

On Wed, Aug 10, 2016 at 3:05 AM,  <[hidden email]> wrote:
> Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
> http://source.squeak.org/trunk/Graphics-mt.358.mcz
>
> ==================== Summary ====================
>
> Name: Graphics-mt.358
> Author: mt
> Time: 10 August 2016, 10:05:35.189696 am
> UUID: fe4bd6ca-d161-bf4c-b0b9-8fd1812d38a8
> Ancestors: Graphics-mt.357
>
> Fixes regression in FileList graphics preview, which expects a certain callback in a certain file service. *sigh* I guess to also assume a certain type of result. *double-sigh*
>
> See FileList >> #isGraphicsFileSelected.
>
> =============== Diff against Graphics-mt.357 ===============
>
> Item was added:
> + ----- Method: Form class>>serviceImageImportAndShowImports (in category 'file list services') -----
> + serviceImageImportAndShowImports
> +       "Answer a service for reading a graphic into ImageImports"
> +
> +       ^       SimpleServiceEntry
> +                       provider: self
> +                       label: 'read graphic into and show ImageImports'
> +                       selector: #importImageAndShowImports:
> +                       description: 'Load a graphic, placing it in the ImageImports repository and browse that repository.'
> +                       buttonLabel: 'import'!
>
> Item was changed:
>   ----- Method: Form class>>serviceImageImports (in category 'file list services') -----
>   serviceImageImports
>         "Answer a service for reading a graphic into ImageImports"
>
>         ^       SimpleServiceEntry
>                         provider: self
>                         label: 'read graphic into ImageImports'
> +                       selector: #importImage:
> -                       selector: #importImageAndShowImports:
>                         description: 'Load a graphic, placing it in the ImageImports repository.'
>                         buttonLabel: 'import'!
>
> Item was changed:
>   ----- Method: Form class>>services (in category 'file list services') -----
>   services
>
>         ^ Array
>                 with: self serviceImageImports
> +               with: self serviceImageImportAndShowImports
>                 with: self serviceOpenImageInWindow
>                 with: self serviceImageAsBackground !
>
>

Hmm... that kind of picture preview uses a FormSetFont to render a space character differently. Well, of course, fonts get (sometimes) colorized during the rendnering pass. Syntax highlighting is an example. I think we should only use "outline forms" (like the ones from fontawesome.com) in such FormSetFonts, which can easily be colorized.

Let's see if we find another way to render forms using regular TextAttributes.

Best,
Marcel