Smalltalk › Squeak › Squeak - Dev

The Trunk: Graphics-mt.426.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Trunk: Graphics-mt.426.mcz

Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mt.426.mcz

==================== Summary ====================

Name: Graphics-mt.426
Author: mt
Time: 20 February 2020, 2:23:22.016183 pm
UUID: 01c81aed-c82d-b345-a3c3-aef6b856fd67
Ancestors: Graphics-tobe.425, Graphics-jr.425

Merges printString fix for LayoutFrame.

=============== Diff against Graphics-tobe.425 ===============

Item was changed:
----- Method: LayoutFrame>>printOn: (in category 'printing') -----
printOn: aStream

super printOn: aStream.

aStream nextPutAll: '( '.

{ {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec |
aStream nextPutAll: spec first; space.

+ (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2.
- spec second printOn: aStream maxDecimalPlaces: 2.

aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']).
(spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0]
separatedBy: [aStream space].

aStream nextPutAll: ' )'.!

Nicolas Cellier

Re: The Trunk: Graphics-mt.426.mcz

Didn't we rather expunge all these ifNil as I proposed?

Le jeu. 20 févr. 2020 à 14:23, <[hidden email]> a écrit :

Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mt.426.mcz

==================== Summary ====================

Name: Graphics-mt.426
Author: mt
Time: 20 February 2020, 2:23:22.016183 pm
UUID: 01c81aed-c82d-b345-a3c3-aef6b856fd67
Ancestors: Graphics-tobe.425, Graphics-jr.425

Merges printString fix for LayoutFrame.

=============== Diff against Graphics-tobe.425 ===============

Item was changed:
----- Method: LayoutFrame>>printOn: (in category 'printing') -----
printOn: aStream

super printOn: aStream.

aStream nextPutAll: '( '.

{ {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec |
aStream nextPutAll: spec first; space.

+ (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2.
- spec second printOn: aStream maxDecimalPlaces: 2.

aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']).
(spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0]
separatedBy: [aStream space].

aStream nextPutAll: ' )'.!

Nicolas Cellier

Re: The Trunk: Graphics-mt.426.mcz

Oh, maybe after the release...

Le jeu. 20 févr. 2020 à 16:54, Nicolas Cellier <[hidden email]> a écrit :

Didn't we rather expunge all these ifNil as I proposed?

Le jeu. 20 févr. 2020 à 14:23, <[hidden email]> a écrit :
Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mt.426.mcz

==================== Summary ====================

Name: Graphics-mt.426
Author: mt
Time: 20 February 2020, 2:23:22.016183 pm
UUID: 01c81aed-c82d-b345-a3c3-aef6b856fd67
Ancestors: Graphics-tobe.425, Graphics-jr.425

Merges printString fix for LayoutFrame.

=============== Diff against Graphics-tobe.425 ===============

Item was changed:
----- Method: LayoutFrame>>printOn: (in category 'printing') -----
printOn: aStream

super printOn: aStream.

aStream nextPutAll: '( '.

{ {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec |
aStream nextPutAll: spec first; space.

+ (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2.
- spec second printOn: aStream maxDecimalPlaces: 2.

aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']).
(spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0]
separatedBy: [aStream space].

aStream nextPutAll: ' )'.!

marcel.taeumel

Re: The Trunk: Graphics-mt.426.mcz

Hi Nicolas.

> Oh, maybe after the release...

Yeah, because of the fix-up and because those LayoutFrames are all around you during code updates. And because there is code that sets the rightFraction to 1.0 #ifNil:. I have to investigate ... :-)

Best,

Marcel

Am 20.02.2020 16:56:16 schrieb Nicolas Cellier <[hidden email]>:

Oh, maybe after the release...

Le jeu. 20 févr. 2020 à 16:54, Nicolas Cellier <[hidden email]> a écrit :
Didn't we rather expunge all these ifNil as I proposed?

Le jeu. 20 févr. 2020 à 14:23, <[hidden email]> a écrit :
Marcel Taeumel uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-mt.426.mcz

==================== Summary ====================

Name: Graphics-mt.426
Author: mt
Time: 20 February 2020, 2:23:22.016183 pm
UUID: 01c81aed-c82d-b345-a3c3-aef6b856fd67
Ancestors: Graphics-tobe.425, Graphics-jr.425

Merges printString fix for LayoutFrame.

=============== Diff against Graphics-tobe.425 ===============

Item was changed:
----- Method: LayoutFrame>>printOn: (in category 'printing') -----
printOn: aStream

super printOn: aStream.

aStream nextPutAll: '( '.

{ {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec |
aStream nextPutAll: spec first; space.

+ (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2.
- spec second printOn: aStream maxDecimalPlaces: 2.

aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']).
(spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0]
separatedBy: [aStream space].

aStream nextPutAll: ' )'.!