The Trunk: Graphics-nice.443.mcz

Nicolas Cellier uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-nice.443.mcz

==================== Summary ====================

Name: Graphics-nice.443
Author: nice
Time: 27 December 2020, 10:35:06.879989 pm
UUID: f712ead7-a4fb-467d-bef1-a0962208c170
Ancestors: Graphics-mt.441, Graphics-ct.439, Graphics-ct.430, Graphics-ct.425, Graphics-ct.418

Merge Graphics-mt.441, Graphics-ct.439, Graphics-ct.430, Graphics-ct.425, Graphics-ct.418

Graphics-mt.441:
        Some clean up around DisplayTransform. Thanks to Stephan Lutz (stlu)!

Graphics-ct.439:
        Fixes transparency handling in Color >> #negated. Negating a color should not remove its alpha channel.

Graphics-ct.430:
        Miscellaneous minor refactoring

- Use #ifError: and correct deprecated [:argWithoutBar] block syntax (see Compiler-ct.417)
- Fix a documetation typo
- Simplify some conditions

Graphics-ct.425:
        [very minor] Use already defined magic number instead of hard-coded duplication

Graphics-ct.418:
        Add Color>>#veryMuchDarker

We also have #veryMuchLighter, so balance this out :)

=============== Diff against Graphics-mt.441 ===============

Item was changed:
  ----- Method: BMPReadWriter class>>readAllFrom: (in category 'testing') -----
  readAllFrom: fd
  "MessageTally spyOn:[BMPReadWriter readAllFrom: FileDirectory default]"
  fd fileNames do:[:fName|
  (fName endsWith: '.bmp') ifTrue:[
+ [Form fromBinaryStream: (fd readOnlyFileNamed: fName)] ifError: [].
- [Form fromBinaryStream: (fd readOnlyFileNamed: fName)] on: Error do:[:nix].
  ].
  ].
  fd directoryNames do:[:fdName|
  self readAllFrom: (fd directoryNamed: fdName)
  ].!

Item was changed:
  ----- Method: Color>>negated (in category 'transformations') -----
  negated
  "Return an RGB inverted color"
  ^Color
  r: 1.0 - self red
  g: 1.0 - self green
+ b: 1.0 - self blue
+ alpha: self alpha!
- b: 1.0 - self blue!

Item was added:
+ ----- Method: Color>>veryMuchDarker (in category 'transformations') -----
+ veryMuchDarker
+
+ ^ self alphaMixed: 0.25 with: Color black
+ !

Item was changed:
  ----- Method: FixedFaceFont>>passwordFont (in category 'initialize-release') -----
  passwordFont
  displaySelector := #displayPasswordOn:length:at:kern:baselineY:.
+ substitutionCharacter := self passwordCharacter!
- substitutionCharacter := $*!

Item was changed:
  StrikeFont subclass: #FormSetFont
  instanceVariableNames: 'tintable combinationRule'
  classVariableNames: ''
  poolDictionaries: ''
  category: 'Graphics-Fonts'!
 
+ !FormSetFont commentStamp: 'ct 2/14/2020 16:49' prior: 0!
+ FormSetFonts are designed to capture individual images as character forms for imbedding in normal text.  While most often used to insert an isolated glyph in some text, the code is actually designed to support an entire user-defined font.  The TextAttribute subclass TextFontReference is specifically designed for such in-line insertion of exceptional fonts in normal text.!
- !FormSetFont commentStamp: '<historical>' prior: 0!
- FormSetFonts are designed to capture individual images as character forms for imbedding in normal text.  While most often used to insert an isolated glyph in some text, the code is actually desinged to support an entire user-defined font.  The TextAttribute subclass TextFontReference is specifically designed for such in-line insertion of exceptional fonts in normal text.!

Item was changed:
  ----- Method: StrikeFont>>hasGlyphForCode: (in category 'multibyte character methods') -----
  hasGlyphForCode: aCharacterCode
 
+ (aCharacterCode between: self minAscii and: self maxAscii)
+ ifFalse: [^ false].
+ (xTable at: aCharacterCode + 1) positive
+ ifFalse: [^ false].
- ((aCharacterCode between: self minAscii and: self maxAscii) not) ifTrue: [
- ^ false.
- ].
- (xTable at: aCharacterCode + 1) < 0 ifTrue: [
- ^ false.
- ].
  ^ true.
  !