The Trunk: Graphics-ul.373.mcz

Levente Uzonyi uploaded a new version of Graphics to project The Trunk:
http://source.squeak.org/trunk/Graphics-ul.373.mcz

==================== Summary ====================

Name: Graphics-ul.373
Author: ul
Time: 24 April 2017, 1:02:39.629816 pm
UUID: db169757-0711-4bd4-8d51-74b25589668c
Ancestors: Graphics-cbc.372

- rewrote senders of #clone to use #shallowCopy
- removed some unnecessary #copy implementations

=============== Diff against Graphics-cbc.372 ===============

Item was changed:
  ----- Method: BDFFontReader class>>downloadFonts (in category 'resource download') -----
  downloadFonts  "BDFFontReader downloadFonts"
  "Download a standard set of BDF sources from x.org.  
  The combined size of these source files is around 1.2M; after conversion
  to .sf2 format they may be deleted."
 
  | heads tails filenames baseUrl basePath |
  heads := #( 'charR' 'courR' 'helvR' 'lubR' 'luRS' 'lutRS' 'ncenR' 'timR' ).
  tails := #( '08' '10' '12' '14' '18' '24').
 
  filenames := OrderedCollection new.
  heads do: [:head |
  filenames addAll: (tails collect: [:tail | head , tail , '.bdf'])
  ].
  baseUrl := 'http://cvsweb.xfree86.org/cvsweb/*checkout*/xc/fonts/bdf/75dpi/' asUrl.
  basePath := baseUrl path.
 
  filenames do: [:filename |
  | document newPath newUrl |
+ newUrl := baseUrl shallowCopy.
- newUrl := baseUrl clone.
  newPath := OrderedCollection newFrom: basePath.
 
  newPath addLast: filename.
  newUrl path: newPath.
 
  UIManager default informUser: 'Fetching ' , filename during:
  [document := newUrl retrieveContents].
 
  MultiByteFileStream newFileNamed: filename do: [ :f |
  f
  wantsLineEndConversion: true;
  nextPutAll: document content ]
  ].
  !

Item was removed:
- ----- Method: Bitmap>>copy (in category 'copying') -----
- copy
-
- ^self clone!

Item was removed:
- ----- Method: CharacterBlock>>copy (in category 'accessing') -----
- copy
- "Overridden because Rectangle does a deepCopy, which goes nuts with the text"
-
- ^ self clone!

Item was changed:
  ----- Method: DisplayHostWindow>>queueEvent: (in category 'private-events') -----
  queueEvent: evt
  "Queue the given event in the event queue (if any).
  Note that the event buffer must be copied since it
  will be reused later on."
  eventQueue ifNil: [^self]. "queue gets created by client"
+ eventQueue nextPut: evt shallowCopy.
- eventQueue nextPut: evt clone.
  !

Item was changed:
  ----- Method: TextStyle>>veryDeepCopyWith: (in category 'Disk I/O') -----
  veryDeepCopyWith: deepCopier
  "All inst vars are meant to be shared"
 
  self == #veryDeepCopyWith:. "to satisfy checkVariables"
+ ^ deepCopier references at: self ifAbsentPut: [self shallowCopy]. "remember"!
- ^ deepCopier references at: self ifAbsentPut: [self clone]. "remember"!