The Trunk: Installer-Core-cmm.383.mcz

Chris Muller uploaded a new version of Installer-Core to project The Trunk:
http://source.squeak.org/trunk/Installer-Core-cmm.383.mcz

==================== Summary ====================

Name: Installer-Core-cmm.383
Author: cmm
Time: 11 November 2013, 3:59:16.385 pm
UUID: 3844745d-bc14-44aa-adee-033cbc0ee3be
Ancestors: Installer-Core-cmm.382

Installer simplification:  remove overly complex printing.

=============== Diff against Installer-Core-cmm.382 ===============

Item was removed:
- ----- Method: Installer class>>label (in category 'accessing') -----
- label
- ^ ''!

Item was removed:
- ----- Method: Installer>>label (in category 'accessing') -----
- label
- ^ self class label!

Item was removed:
- ----- Method: Installer>>printConfigurationOn: (in category 'printing') -----
- printConfigurationOn: stream
- !

Item was removed:
- ----- Method: Installer>>printOn: (in category 'printing') -----
- printOn: s
- s
- nextPutAll: '(Installer ';
- nextPutAll: self label;
- nextPut: $).
-
- "lf project ifNotNil: [ s nextPutAll: ' project:'; nextPutAll: '''', self project, ''''.
- self package ifNotNil: [ s nextPutAll: '; '] ]."
- self package ifNotNil: [ s nextPutAll: ' package:'; nextPutAll: '''', self package asString, '''' ].
- self printConfigurationOn: s.
- s nextPut: $..!

Item was removed:
- ----- Method: InstallerCruft class>>label (in category 'accessing') -----
- label
- ^ 'cruft'!

Item was removed:
- ----- Method: InstallerFile class>>label (in category 'accessing') -----
- label
- ^ 'file'!

Item was removed:
- ----- Method: InstallerMantis class>>label (in category 'accessing') -----
- label
- ^ 'mantis'!

Item was removed:
- ----- Method: InstallerMonticello class>>label (in category 'accessing') -----
- label
- ^ 'monticello'!

Item was removed:
- ----- Method: InstallerMonticello>>label (in category 'accessing') -----
- label
- ^ 'repository:''', mc description, ''''!

Item was removed:
- ----- Method: InstallerMonticello>>printConfigurationOn: (in category 'Installer-Core') -----
- printConfigurationOn: stream
- self project ifNil: [ ^ self ].
-
- stream
- nextPutAll: ' project:''';
- nextPutAll: self project;
- nextPut: $'!

Item was removed:
- ----- Method: InstallerSake class>>label (in category 'accessing') -----
- label
- ^ 'sake'!

Item was removed:
- ----- Method: InstallerSqueakMap class>>label (in category 'accessing') -----
- label
- ^ 'squeakmap'!

Item was removed:
- ----- Method: InstallerUniverse class>>label (in category 'as yet unclassified') -----
- label
- ^ 'universe'!

Item was removed:
- ----- Method: InstallerUpdateStream class>>label (in category 'accessing') -----
- label
- ^ 'updatestream'!

Item was removed:
- ----- Method: InstallerUrl class>>label (in category 'accessing') -----
- label
- ^ 'url'!

Item was removed:
- ----- Method: InstallerUrl>>label (in category 'accessing') -----
- label
- ^ 'url:''', url, ''''!

Item was removed:
- ----- Method: InstallerWeb class>>label (in category 'accessing') -----
- label
- ^ 'web'!

Item was removed:
- ----- Method: InstallerWebSqueakMap class>>label (in category 'accessing') -----
- label
- ^ 'websqueammap'!

On 11 November 2013 21:59,  <[hidden email]> wrote:
If I understand correctly, this simply removes _all_ printing, so an
"i printString" (where i is an Installer) simply gives "an Installer"
(or "an InstallerMonticello"). That doesn't seem like much of an
improvement. The point of this implementation (spelling mistakes
aside) seems to be to provide something like the MCRepository classes
give - to give you a string that, when evaluated, gives you an
equivalent Installer. I rather like that behaviour. It seems
unfortunate to lose such a useful thing.

frank

Addition-by-subtraction.  These methods overload an already overloaded
selector (#label) for stuff that was never really used.  Sake?
Universes?  Cruft?  Mantis?  SqueakMap vs. WebSqueakMap (what is
that?)?  Even if they were, when would we need to evaluate an
Installer's storeString?  I'm not seeing the usefulness, I see weeds.

If I'm wrong about that, bring back the functionality by overriding
#storeOn: and change printOn: to call storeOn: rather than this
proliferation of methods.

On Tue, Nov 12, 2013 at 3:44 AM, Frank Shearar <[hidden email]> wrote: