Smalltalk › Squeak › Squeak - Dev

The Trunk: Installer-Core-tpr.388.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

11 messages Options

commits-2

The Trunk: Installer-Core-tpr.388.mcz

tim Rowledge uploaded a new version of Installer-Core to project The Trunk:
http://source.squeak.org/trunk/Installer-Core-tpr.388.mcz

==================== Summary ====================

Name: Installer-Core-tpr.388
Author: tpr
Time: 31 December 2013, 4:44:28.775 pm
UUID: c1f6039a-22f6-4024-97c4-0d5e7d6a53ac
Ancestors: Installer-Core-cmm.387

remove an unsent method as tagged by isThisEverCalled

=============== Diff against Installer-Core-cmm.387 ===============

Item was removed:
- ----- Method: Installer>>rememberAs: (in category 'custom names') -----
- rememberAs: symbol
- self isThisEverCalled.
- self class remembered at: symbol asSymbol put: self!

Tobias Pape

Re: The Trunk: Installer-Core-tpr.388.mcz

On 01.01.2014, at 00:44, [hidden email] wrote:

> tim Rowledge uploaded a new version of Installer-Core to project The Trunk:
> http://source.squeak.org/trunk/Installer-Core-tpr.388.mcz
>
> ==================== Summary ====================
>
> Name: Installer-Core-tpr.388
> Author: tpr
> Time: 31 December 2013, 4:44:28.775 pm
> UUID: c1f6039a-22f6-4024-97c4-0d5e7d6a53ac
> Ancestors: Installer-Core-cmm.387
>
> remove an unsent method as tagged by isThisEverCalled
>
> =============== Diff against Installer-Core-cmm.387 ===============
>
> Item was removed:
> - ----- Method: Installer>>rememberAs: (in category 'custom names') -----
> - rememberAs: symbol
> - self isThisEverCalled.
> - self class remembered at: symbol asSymbol put: self!

I believe it is unsent for a reason.
I think this is purely for the End-users who wants to
setup their own remembered Installer shortcuts.
I’d rather opt for a test than remove that.
Because if we remove #rememberAs, we certainly have to remove
the whole #remembered infrastructure.

Best
-Tobias

Frank Shearar-3

Re: The Trunk: Installer-Core-tpr.388.mcz

On 1 January 2014 11:44, Tobias Pape <[hidden email]> wrote:

>
> On 01.01.2014, at 00:44, [hidden email] wrote:
>
>> tim Rowledge uploaded a new version of Installer-Core to project The Trunk:
>> http://source.squeak.org/trunk/Installer-Core-tpr.388.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Installer-Core-tpr.388
>> Author: tpr
>> Time: 31 December 2013, 4:44:28.775 pm
>> UUID: c1f6039a-22f6-4024-97c4-0d5e7d6a53ac
>> Ancestors: Installer-Core-cmm.387
>>
>> remove an unsent method as tagged by isThisEverCalled
>>
>> =============== Diff against Installer-Core-cmm.387 ===============
>>
>> Item was removed:
>> - ----- Method: Installer>>rememberAs: (in category 'custom names') -----
>> - rememberAs: symbol
>> - self isThisEverCalled.
>> - self class remembered at: symbol asSymbol put: self!
>
>
> I believe it is unsent for a reason.
> I think this is purely for the End-users who wants to
> setup their own remembered Installer shortcuts.
> I’d rather opt for a test than remove that.
> Because if we remove #rememberAs, we certainly have to remove
> the whole #remembered infrastructure.

Yep. Installer is generally ropy: as long as you perform the correct
incantations it all works, but woe betide you swirl the chicken
anticlockwise, or you get complete gibberish for error messages. It
needs some serious love in helping the user figure out what she did
wrong..

frank

> Best
> -Tobias

timrowledge

Re: The Trunk: Installer-Core-tpr.388.mcz

>>>
>>> Item was removed:
>>> - ----- Method: Installer>>rememberAs: (in category 'custom names') -----
>>> - rememberAs: symbol
>>> - self isThisEverCalled.
>>> - self class remembered at: symbol asSymbol put: self!
>>
>>
>> I believe it is unsent for a reason.

Feel free to re-instate the method without the #isThisEverCalled if you consider it an important thing.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Oxymorons: Clearly misunderstood

Chris Muller-3

Re: The Trunk: Installer-Core-tpr.388.mcz

In reply to this post by Tobias Pape

When I look at the Remembered class-var and how its used, I see that
it's through a DNU hook on Installer class..? This makes me cringe
because Installer is already so hard to understand and this makes it
even worse..?

What you mean by "remembered Installer shortcuts"?

On Wed, Jan 1, 2014 at 5:44 AM, Tobias Pape <[hidden email]> wrote:

Tobias Pape

Re: The Trunk: Installer-Core-tpr.388.mcz

On 02.01.2014, at 16:28, Chris Muller <[hidden email]> wrote:

> When I look at the Remembered class-var and how its used, I see that
> it's through a DNU hook on Installer class..? This makes me cringe
> because Installer is already so hard to understand and this makes it
> even worse..?
>
> What you mean by "remembered Installer shortcuts"?

Like this:

Installer monticello
http: 'http://canary.netshed.de/ss/';
rememberAs: #canary.

Installer canary "=> an InstallerMonticello"

Best
-Tobias

signature.asc (1K) Download Attachment

Frank Shearar-3

Re: The Trunk: Installer-Core-tpr.388.mcz

In reply to this post by Chris Muller-3

On 2 January 2014 15:28, Chris Muller <[hidden email]> wrote:
> When I look at the Remembered class-var and how its used, I see that
> it's through a DNU hook on Installer class..? This makes me cringe
> because Installer is already so hard to understand and this makes it
> even worse..?

I'm looking for the "unsee" button myself:
http://this-plt-life.tumblr.com/post/36425235754/when-i-see-that-rubys-parser-is-10-000-lines-of-c

frank

> What you mean by "remembered Installer shortcuts"?
>
> On Wed, Jan 1, 2014 at 5:44 AM, Tobias Pape <[hidden email]> wrote:
>>
>> On 01.01.2014, at 00:44, [hidden email] wrote:
>>
>>> tim Rowledge uploaded a new version of Installer-Core to project The Trunk:
>>> http://source.squeak.org/trunk/Installer-Core-tpr.388.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Installer-Core-tpr.388
>>> Author: tpr
>>> Time: 31 December 2013, 4:44:28.775 pm
>>> UUID: c1f6039a-22f6-4024-97c4-0d5e7d6a53ac
>>> Ancestors: Installer-Core-cmm.387
>>>
>>> remove an unsent method as tagged by isThisEverCalled
>>>
>>> =============== Diff against Installer-Core-cmm.387 ===============
>>>
>>> Item was removed:
>>> - ----- Method: Installer>>rememberAs: (in category 'custom names') -----
>>> - rememberAs: symbol
>>> - self isThisEverCalled.
>>> - self class remembered at: symbol asSymbol put: self!
>>
>>
>> I believe it is unsent for a reason.
>> I think this is purely for the End-users who wants to
>> setup their own remembered Installer shortcuts.
>> I’d rather opt for a test than remove that.
>> Because if we remove #rememberAs, we certainly have to remove
>> the whole #remembered infrastructure.
>>
>> Best
>> -Tobias
>

timrowledge

Re: The Trunk: Installer-Core-tpr.388.mcz

On 02-01-2014, at 9:25 AM, Frank Shearar <[hidden email]> wrote:

> On 2 January 2014 15:28, Chris Muller <[hidden email]> wrote:
>> When I look at the Remembered class-var and how its used, I see that
>> it's through a DNU hook on Installer class..? This makes me cringe
>> because Installer is already so hard to understand and this makes it
>> even worse..?
>
> I'm looking for the "unsee" button myself:
> http://this-plt-life.tumblr.com/post/36425235754/when-i-see-that-rubys-parser-is-10-000-lines-of-c

Somebody please implement this button. Maybe then I can forget C++, java, COBOL, TECO…. the list goes on...

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
To succeed in politics, it is often necessary to rise above your principles.

Chris Muller-3

Re: The Trunk: Installer-Core-tpr.388.mcz

In reply to this post by commits-2

Does anyone know whether this is used by Metacello?

On Tue, Dec 31, 2013 at 6:44 PM, <[hidden email]> wrote:

Tobias Pape

Re: The Trunk: Installer-Core-tpr.388.mcz

On 07.01.2014, at 00:43, Chris Muller <[hidden email]> wrote:

> Does anyone know whether this is used by Metacello?

Metacello uses Gofer :)

Best
-Tobias

signature.asc (1K) Download Attachment

Chris Muller-4

Re: The Trunk: Installer-Core-tpr.388.mcz

Ok, I thought so. I had come across this MC version:

-------------------
Name: Installer-Core-fbs.385
Author: fbs
Time: 17 November 2013, 9:54:59.988 pm
UUID: 363eee87-69f1-664a-857c-0ba322add113
Ancestors: Installer-Core-cmm.384

I think this is a serious misuse of DNU, but this method is, in fact,
used: the #isThisEverCalled: pops up a self halt which breaks
Metacello.

While we should rewrite this to _not_ need the DNU, we need the
#isThisEverCalled: removed.
-----------------------

and it made me wonder if Metacello could arrive there, whether it
would be broken now..

On Mon, Jan 6, 2014 at 5:54 PM, Tobias Pape <[hidden email]> wrote:
>
> On 07.01.2014, at 00:43, Chris Muller <[hidden email]> wrote:
>
>> Does anyone know whether this is used by Metacello?
>
> Metacello uses Gofer :)
>
> Best
> -Tobias