The Trunk: Installer-Core-ul.421.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Installer-Core-ul.421.mcz

commits-2
Levente Uzonyi uploaded a new version of Installer-Core to project The Trunk:
http://source.squeak.org/trunk/Installer-Core-ul.421.mcz

==================== Summary ====================

Name: Installer-Core-ul.421
Author: ul
Time: 13 May 2018, 10:38:47.570893 pm
UUID: 5116baf0-5442-4586-87b5-ca08a9708de4
Ancestors: Installer-Core-mt.420

Updated the way #ensureRecentMetacello tests the network connection and ssl support:
- use github.com instead of google.de
- use HEAD instead of GET
- use #classNamed: to look up classes
- use symbols for class names, so these uses will appear along with real class references while browsing senders

=============== Diff against Installer-Core-mt.420 ===============

Item was changed:
  ----- Method: Installer class>>ensureRecentMetacello (in category 'scripts') -----
  ensureRecentMetacello
  "Copied and adapted from https://github.com/Metacello/metacello/blob/master/README.md"
 
+ | metacello |
+ ((Smalltalk classNamed: #WebClient)
+ ifNil: [ false ]
+ ifNotNil: [ :webClient |
+ [ (webClient httpHead: 'https://github.com') isSuccess ]
+ on: Error
+ do: [ false ] ])
+ ifFalse: [ ^self inform: 'Could not connect to "https://github.com".\\You need an internet connection and SSL support\to install (or update) Metacello.\\Please fix those issues and try again.' translated withCRs ].
- ([((Smalltalk classNamed: 'WebClient') httpGet: 'https://www.google.de') isSuccess] on: Error do: [:err | false])
- ifFalse: [^ self inform: 'Could not resolve "https://www.google.de".\\You need an internet connection and SSL support\to install (or update) Metacello.\\Please fix those issues and try again.' translated withCRs].
 
+ metacello := (Smalltalk classNamed: #Metacello) ifNil: [
- (Smalltalk hasClassNamed: 'Metacello') ifFalse: [
  "Get the Metacello configuration (for Squeak users)"
  Installer gemsource
+ project: 'metacello';
+ addPackage: 'ConfigurationOfMetacello';
+ install.
-    project: 'metacello';
-    addPackage: 'ConfigurationOfMetacello';
-    install.
 
  "Bootstrap Metacello Preview, using mcz files (#'previewBootstrap' symbolic version"
+ ((Smalltalk classNamed: #ConfigurationOfMetacello) project
+ version: #'previewBootstrap') load.
- ((Smalltalk at: #ConfigurationOfMetacello) project
-  version: #'previewBootstrap') load.
 
  "Load the Preview version of Metacello from GitHub"
+ (Smalltalk classNamed: #Metacello) new
+ configuration: 'MetacelloPreview';
+ version: #stable;
+ repository: 'github://Metacello/metacello:configuration';
+ load.
- (Smalltalk at: #Metacello) new
-  configuration: 'MetacelloPreview';
-  version: #stable;
-  repository: 'github://Metacello/metacello:configuration';
-  load].
 
+ Smalltalk classNamed: #Metacello ].
+
  "Now load latest version of Metacello"
+ metacello new
+ baseline: 'Metacello';
+ repository: 'github://Metacello/metacello:master/repository';
+ get.
+ metacello new
+ baseline: 'Metacello';
+ repository: 'github://Metacello/metacello:master/repository';
+ load.!
- (Smalltalk at: #Metacello) new
-  baseline: 'Metacello';
-  repository: 'github://Metacello/metacello:master/repository';
-  get.
- (Smalltalk at: #Metacello) new
-  baseline: 'Metacello';
-  repository: 'github://Metacello/metacello:master/repository';
-  load.!