The Trunk: Kernel-ar.335.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-ar.335.mcz

commits-2
Andreas Raab uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-ar.335.mcz

==================== Summary ====================

Name: Kernel-ar.335
Author: ar
Time: 22 December 2009, 1:07:25 am
UUID: a20c919d-6ba9-9c48-af9a-83f95181cfde
Ancestors: Kernel-ar.334

Convert those trailers!

=============== Diff against Kernel-ar.334 ===============

Item was changed:
  ----- Method: CompiledMethodTrailer class>>trailerClass (in category 'as yet unclassified') -----
  trailerClass
+ ^ CompiledMethodTrailer!
- ^ OldMethodTrailer!

Item was added:
+ ----- Method: CompiledMethodTrailer class>>initialize (in category 'as yet unclassified') -----
+ initialize
+ "CompiledMethodTrailer initialize"
+ self convertTrailers.!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-ar.335.mcz

Igor Stasenko
2009/12/22  <[hidden email]>:

> Andreas Raab uploaded a new version of Kernel to project The Trunk:
> http://source.squeak.org/trunk/Kernel-ar.335.mcz
>
> ==================== Summary ====================
>
> Name: Kernel-ar.335
> Author: ar
> Time: 22 December 2009, 1:07:25 am
> UUID: a20c919d-6ba9-9c48-af9a-83f95181cfde
> Ancestors: Kernel-ar.334
>
> Convert those trailers!
>

Woohooo!!! :)))

> =============== Diff against Kernel-ar.334 ===============
>
> Item was changed:
>  ----- Method: CompiledMethodTrailer class>>trailerClass (in category 'as yet unclassified') -----
>  trailerClass
> +       ^ CompiledMethodTrailer!
> -       ^ OldMethodTrailer!
>
> Item was added:
> + ----- Method: CompiledMethodTrailer class>>initialize (in category 'as yet unclassified') -----
> + initialize
> +       "CompiledMethodTrailer initialize"
> +       self convertTrailers.!
>
>
>



--
Best regards,
Igor Stasenko AKA sig.

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-ar.335.mcz

Andreas.Raab
Igor Stasenko wrote:

> 2009/12/22  <[hidden email]>:
>> Andreas Raab uploaded a new version of Kernel to project The Trunk:
>> http://source.squeak.org/trunk/Kernel-ar.335.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Kernel-ar.335
>> Author: ar
>> Time: 22 December 2009, 1:07:25 am
>> UUID: a20c919d-6ba9-9c48-af9a-83f95181cfde
>> Ancestors: Kernel-ar.334
>>
>> Convert those trailers!
>>
>
> Woohooo!!! :)))

Unfortunately, I'm having a bit of a problem here and will have to redo.
Anyone know if MC *ever* calls initialize twice on classes?

Cheers,
   - Andreas

>
>> =============== Diff against Kernel-ar.334 ===============
>>
>> Item was changed:
>>  ----- Method: CompiledMethodTrailer class>>trailerClass (in category 'as yet unclassified') -----
>>  trailerClass
>> +       ^ CompiledMethodTrailer!
>> -       ^ OldMethodTrailer!
>>
>> Item was added:
>> + ----- Method: CompiledMethodTrailer class>>initialize (in category 'as yet unclassified') -----
>> + initialize
>> +       "CompiledMethodTrailer initialize"
>> +       self convertTrailers.!
>>
>>
>>
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Re: The Trunk: Kernel-ar.335.mcz

Igor Stasenko
2009/12/22 Andreas Raab <[hidden email]>:

> Igor Stasenko wrote:
>>
>> 2009/12/22  <[hidden email]>:
>>>
>>> Andreas Raab uploaded a new version of Kernel to project The Trunk:
>>> http://source.squeak.org/trunk/Kernel-ar.335.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Kernel-ar.335
>>> Author: ar
>>> Time: 22 December 2009, 1:07:25 am
>>> UUID: a20c919d-6ba9-9c48-af9a-83f95181cfde
>>> Ancestors: Kernel-ar.334
>>>
>>> Convert those trailers!
>>>
>>
>> Woohooo!!! :)))
>
> Unfortunately, I'm having a bit of a problem here and will have to redo.
> Anyone know if MC *ever* calls initialize twice on classes?
>
you can change the code to check & not run conversion again in #initialize
if it alredy converted.
Then there will be no problem how many times it calls initialize.

> Cheers,
>  - Andreas
>
>>
>>> =============== Diff against Kernel-ar.334 ===============
>>>
>>> Item was changed:
>>>  ----- Method: CompiledMethodTrailer class>>trailerClass (in category 'as
>>> yet unclassified') -----
>>>  trailerClass
>>> +       ^ CompiledMethodTrailer!
>>> -       ^ OldMethodTrailer!
>>>
>>> Item was added:
>>> + ----- Method: CompiledMethodTrailer class>>initialize (in category 'as
>>> yet unclassified') -----
>>> + initialize
>>> +       "CompiledMethodTrailer initialize"
>>> +       self convertTrailers.!
>>>
>>>
>>>
>>
>>
>>
>
>
>



--
Best regards,
Igor Stasenko AKA sig.

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-ar.335.mcz

Andreas.Raab
Igor Stasenko wrote:
> 2009/12/22 Andreas Raab <[hidden email]>:
>> Unfortunately, I'm having a bit of a problem here and will have to redo.
>> Anyone know if MC *ever* calls initialize twice on classes?
>>
> you can change the code to check & not run conversion again in #initialize
> if it alredy converted.
> Then there will be no problem how many times it calls initialize.

Actually the problem was that running the convertion created the new
trailerClass method. Of course I tried this before committing and as a
result committed the wrong version. Lesson: Don't use 'self compile:' in
initializers. Class vars can be used to good effect here.

(source.squeak.org now seems to have to a grinding halt - I may have to
wait before I can commit the cleanup changes since I have another
appointment coming up rapidly)

Cheers,
   - Andreas