The Trunk: Kernel-ct.1278.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-ct.1278.mcz

commits-2
Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-ct.1278.mcz

==================== Summary ====================

Name: Kernel-ct.1278
Author: ct
Time: 1 November 2019, 7:18:08.038562 pm
UUID: 1b93aa78-abca-b441-b409-9b58f1b2d2bf
Ancestors: Kernel-nice.1277

Fix a bug in #valueSupplyingAnswers:. If the pattern is not a regex, a RegexSyntaxError may be raised.

"Now works:"
[self inform: 'Hello world']
        valueSupplyingAnswers: #(('*foo*' nil))

=============== Diff against Kernel-nice.1277 ===============

Item was changed:
  ----- Method: BlockClosure>>valueSupplyingAnswers: (in category 'evaluating') -----
  valueSupplyingAnswers: aListOfPairs
  "evaluate the block using a list of questions / answers that might be called upon to
  automatically respond to Object>>confirm: or FillInTheBlank requests"
 
  ^self
  on: ProvideAnswerNotification
  do: [ :notification |
  | caption |
  caption := notification messageText withSeparatorsCompacted. "to remove new lines"
  aListOfPairs
  detect:  [ :each |
  caption = each first
  or: [ (caption includesSubstring: each first caseSensitive: false)
  or: [ (each first match: caption)
  or: [ (caption respondsTo: #matchesRegex:)
+ and: [ [caption matchesRegex: each first] on: RegexSyntaxError do: [false] ] ] ] ] ]
- and: [ caption matchesRegex: each first ] ] ] ] ]
  ifFound: [ :answer | notification resume: answer second ]
  ifNone: [
  (ProvideAnswerNotification signal: notification messageText)
  ifNil: [ notification resume ]
  ifNotNil: [ :outerAnswer | notification resume: outerAnswer ] ] ]!