The Trunk: Kernel-eem.1265.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-eem.1265.mcz

commits-2
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1265.mcz

==================== Summary ====================

Name: Kernel-eem.1265
Author: eem
Time: 5 September 2019, 9:44:47.807982 am
UUID: 69e1a0f1-43f5-435e-999d-b8e81b52401a
Ancestors: Kernel-mt.1264

Fix a regression in COmpiledMethod>>messagesSequence caused by the method not having been correctly commented in the first place.

=============== Diff against Kernel-mt.1264 ===============

Item was added:
+ ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
+ messagesSequence
+ "Answer a sequence of all the message selectors sent by this method in the order
+ they are sent.  Unlike messages this may include duplicates."
+
+ ^Array streamContents:
+ [:str| | scanner |
+ scanner := InstructionStream on: self.
+ scanner scanFor:
+ [:x | | selectorOrSelf |
+ (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse:
+ [str nextPut: selectorOrSelf].
+ false "keep scanning"]]!

Item was removed:
- ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') -----
- messagesSequence
-
- self flag: #todo. "mt: Better change #messages to return an array instead of a set?"
- ^ self messages asArray!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-eem.1265.mcz

marcel.taeumel
Aha! :-) Thanks for pointing that out. ;-)

Best,
Marcel

Am 05.09.2019 18:45:01 schrieb [hidden email] <[hidden email]>:

Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1265.mcz

==================== Summary ====================

Name: Kernel-eem.1265
Author: eem
Time: 5 September 2019, 9:44:47.807982 am
UUID: 69e1a0f1-43f5-435e-999d-b8e81b52401a
Ancestors: Kernel-mt.1264

Fix a regression in COmpiledMethod>>messagesSequence caused by the method not having been correctly commented in the first place.

=============== Diff against Kernel-mt.1264 ===============

Item was added:
+ ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
+ messagesSequence
+ "Answer a sequence of all the message selectors sent by this method in the order
+ they are sent. Unlike messages this may include duplicates."
+
+ ^Array streamContents:
+ [:str| | scanner |
+ scanner := InstructionStream on: self.
+ scanner scanFor:
+ [:x | | selectorOrSelf |
+ (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse:
+ [str nextPut: selectorOrSelf].
+ false "keep scanning"]]!

Item was removed:
- ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') -----
- messagesSequence
-
- self flag: #todo. "mt: Better change #messages to return an array instead of a set?"
- ^ self messages asArray!




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-eem.1265.mcz

marcel.taeumel
Hi Eliot,

please take a look at Kernel-mt.1266 in the inbox:

Do you need #messagesSequence
   (a) to only scan that specific code object or
   (b) to you want it for a compiled method, traversing all embedded compiled blocks? (SistaV1)

Best,
Marcel

Am 06.09.2019 07:52:05 schrieb Marcel Taeumel <[hidden email]>:

Aha! :-) Thanks for pointing that out. ;-)

Best,
Marcel

Am 05.09.2019 18:45:01 schrieb [hidden email] <[hidden email]>:

Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1265.mcz

==================== Summary ====================

Name: Kernel-eem.1265
Author: eem
Time: 5 September 2019, 9:44:47.807982 am
UUID: 69e1a0f1-43f5-435e-999d-b8e81b52401a
Ancestors: Kernel-mt.1264

Fix a regression in COmpiledMethod>>messagesSequence caused by the method not having been correctly commented in the first place.

=============== Diff against Kernel-mt.1264 ===============

Item was added:
+ ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
+ messagesSequence
+ "Answer a sequence of all the message selectors sent by this method in the order
+ they are sent. Unlike messages this may include duplicates."
+
+ ^Array streamContents:
+ [:str| | scanner |
+ scanner := InstructionStream on: self.
+ scanner scanFor:
+ [:x | | selectorOrSelf |
+ (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse:
+ [str nextPut: selectorOrSelf].
+ false "keep scanning"]]!

Item was removed:
- ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') -----
- messagesSequence
-
- self flag: #todo. "mt: Better change #messages to return an array instead of a set?"
- ^ self messages asArray!