Smalltalk › Squeak › Squeak - Dev

The Trunk: Kernel-eem.1321.mcz

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
commits-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

The Trunk: Kernel-eem.1321.mcz

commits-2
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1321.mcz

==================== Summary ====================

Name: Kernel-eem.1321
Author: eem
Time: 15 April 2020, 4:07:36.59453 pm
UUID: 93f4b4c9-41ba-47f8-b220-72087fc41176
Ancestors: Kernel-eem.1319

Change a couple of CompiledCode methods to use selectorsDo:; messagesDo: should be deprecated at some point.

=============== Diff against Kernel-eem.1319 ===============

Item was changed:
  ----- Method: CompiledCode>>messages (in category 'scanning') -----
  messages
  "Answer a Set of all the message selectors sent by this method."
 
  | result |
  result := Set new.
+ self selectorsDo: [:selector | result add: selector].
- self messagesDo: [:selector | result add: selector].
  ^ result!

Item was changed:
  ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
  messagesSequence
  "Answer a sequence of all the message selectors sent by this method in the order they are sent. Unlike #messages this may include duplicates. Note that both the sources and the decompiled sources might suggest different results. The returned information reflect the actual bytecode."
 
  ^ Array streamContents: [:result |
+ self selectorsDo: [:selector | result nextPut: selector]]!
- self messagesDo: [:selector | result nextPut: selector]]!


Chris Muller-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Kernel-eem.1321.mcz

Chris Muller-3
Hm, now you've got two words to describe one thing ("message" and :"selector").  I like "selector", but don't you want to rename them all?


On Wed, Apr 15, 2020 at 6:07 PM <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1321.mcz

==================== Summary ====================

Name: Kernel-eem.1321
Author: eem
Time: 15 April 2020, 4:07:36.59453 pm
UUID: 93f4b4c9-41ba-47f8-b220-72087fc41176
Ancestors: Kernel-eem.1319

Change a couple of CompiledCode methods to use selectorsDo:; messagesDo: should be deprecated at some point.

=============== Diff against Kernel-eem.1319 ===============

Item was changed:
  ----- Method: CompiledCode>>messages (in category 'scanning') -----
  messages
        "Answer a Set of all the message selectors sent by this method."

        | result |
        result := Set new.
+       self selectorsDo: [:selector | result add: selector].
-       self messagesDo: [:selector | result add: selector].
        ^ result!

Item was changed:
  ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
  messagesSequence
        "Answer a sequence of all the message selectors sent by this method in the order they are sent. Unlike #messages this may include duplicates. Note that both the sources and the decompiled sources might suggest different results. The returned information reflect the actual bytecode."

        ^ Array streamContents: [:result |
+               self selectorsDo: [:selector | result nextPut: selector]]!
-               self messagesDo: [:selector | result nextPut: selector]]!
Chris Muller-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Kernel-eem.1321.mcz

Chris Muller-3
I suppose it does make more sense asking a CompiledCode about it's "messages", than its "selectors".  A strange subtlety..

On Thu, Apr 16, 2020 at 2:09 PM Chris Muller <[hidden email]> wrote:
Hm, now you've got two words to describe one thing ("message" and :"selector").  I like "selector", but don't you want to rename them all?


On Wed, Apr 15, 2020 at 6:07 PM <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1321.mcz

==================== Summary ====================

Name: Kernel-eem.1321
Author: eem
Time: 15 April 2020, 4:07:36.59453 pm
UUID: 93f4b4c9-41ba-47f8-b220-72087fc41176
Ancestors: Kernel-eem.1319

Change a couple of CompiledCode methods to use selectorsDo:; messagesDo: should be deprecated at some point.

=============== Diff against Kernel-eem.1319 ===============

Item was changed:
  ----- Method: CompiledCode>>messages (in category 'scanning') -----
  messages
        "Answer a Set of all the message selectors sent by this method."

        | result |
        result := Set new.
+       self selectorsDo: [:selector | result add: selector].
-       self messagesDo: [:selector | result add: selector].
        ^ result!

Item was changed:
  ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
  messagesSequence
        "Answer a sequence of all the message selectors sent by this method in the order they are sent. Unlike #messages this may include duplicates. Note that both the sources and the decompiled sources might suggest different results. The returned information reflect the actual bytecode."

        ^ Array streamContents: [:result |
+               self selectorsDo: [:selector | result nextPut: selector]]!
-               self messagesDo: [:selector | result nextPut: selector]]!
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: The Trunk: Kernel-eem.1321.mcz

marcel.taeumel
> I suppose it does make more sense asking a CompiledCode about it's "messages", than its "selectors".  A strange subtlety..

Hmm... what actually is a "message"? In this case, the term "selector" seems more appropriate because more technical. "Messages" need arguments? Or is that a "message send"? :-)

We have the following classes around the term "message":
- Message (for DNU)
- MessageSend (for callbacks)

I wouldn't associate those higher-level concepts with CompiledCode.

Best,
Marcel

Am 16.04.2020 22:30:28 schrieb Chris Muller <[hidden email]>:

I suppose it does make more sense asking a CompiledCode about it's "messages", than its "selectors".  A strange subtlety..

On Thu, Apr 16, 2020 at 2:09 PM Chris Muller <[hidden email]> wrote:
Hm, now you've got two words to describe one thing ("message" and :"selector").  I like "selector", but don't you want to rename them all?


On Wed, Apr 15, 2020 at 6:07 PM <[hidden email]> wrote:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1321.mcz

==================== Summary ====================

Name: Kernel-eem.1321
Author: eem
Time: 15 April 2020, 4:07:36.59453 pm
UUID: 93f4b4c9-41ba-47f8-b220-72087fc41176
Ancestors: Kernel-eem.1319

Change a couple of CompiledCode methods to use selectorsDo:; messagesDo: should be deprecated at some point.

=============== Diff against Kernel-eem.1319 ===============

Item was changed:
  ----- Method: CompiledCode>>messages (in category 'scanning') -----
  messages
        "Answer a Set of all the message selectors sent by this method."

        | result |
        result := Set new.
+       self selectorsDo: [:selector | result add: selector].
-       self messagesDo: [:selector | result add: selector].
        ^ result!

Item was changed:
  ----- Method: CompiledCode>>messagesSequence (in category 'scanning') -----
  messagesSequence
        "Answer a sequence of all the message selectors sent by this method in the order they are sent. Unlike #messages this may include duplicates. Note that both the sources and the decompiled sources might suggest different results. The returned information reflect the actual bytecode."

        ^ Array streamContents: [:result |
+               self selectorsDo: [:selector | result nextPut: selector]]!
-               self messagesDo: [:selector | result nextPut: selector]]!
Free forum by Nabble Edit this page