Smalltalk › Squeak › Squeak - Dev

The Trunk: Kernel-eem.1325.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

commits-2

The Trunk: Kernel-eem.1325.mcz

Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!

marcel.taeumel

Re: The Trunk: Kernel-eem.1325.mcz

Hi Eliot.

Now CompiledCodeInspectorTest >> #createObject is not working anymore. It does this:

[:arg | arg + 2] compiledBlock

... as a quick way to get a compiled-code object.

Best,

Marcel

Am 01.05.2020 19:38:40 schrieb [hidden email] <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!

marcel.taeumel

Re: The Trunk: Kernel-eem.1325.mcz

... would "[:arg | arg + 2] method" work instead of #compiledBlock? :-)

Best,

Marcel

Am 04.05.2020 11:07:02 schrieb Marcel Taeumel <[hidden email]>:
Hi Eliot.

Now CompiledCodeInspectorTest >> #createObject is not working anymore. It does this:

[:arg | arg + 2] compiledBlock

... as a quick way to get a compiled-code object.

Best,
Marcel

Am 01.05.2020 19:38:40 schrieb [hidden email] <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!

Eliot Miranda-2

Re: The Trunk: Kernel-eem.1325.mcz

In reply to this post by marcel.taeumel

Hi Marcel,

On May 4, 2020, at 2:07 AM, Marcel Taeumel <[hidden email]> wrote:

Hi Eliot.

Now CompiledCodeInspectorTest >> #createObject is not working anymore. It does this:

[:arg | arg + 2] compiledBlock

... as a quick way to get a compiled-code object.

I do apologize! I didn’t have it loaded when I checked for users of compiledBlock.

Just use method instead. I can reinstate compiledBlock if you’d like. I would rather not because, unlike method, t

it was the only implementor.

Best,
Marcel

Am 01.05.2020 19:38:40 schrieb [hidden email] <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!

Eliot Miranda-2

Re: The Trunk: Kernel-eem.1325.mcz

In reply to this post by marcel.taeumel

On May 4, 2020, at 2:10 AM, Marcel Taeumel <[hidden email]> wrote:

... would "[:arg | arg + 2] method" work instead of #compiledBlock? :-)

It would. And note that the selector is shared with context

[thisContext method] value

does what one expects...

Best,
Marcel

Am 04.05.2020 11:07:02 schrieb Marcel Taeumel <[hidden email]>:
Hi Eliot.

Now CompiledCodeInspectorTest >> #createObject is not working anymore. It does this:

[:arg | arg + 2] compiledBlock

... as a quick way to get a compiled-code object.

Best,
Marcel

Am 01.05.2020 19:38:40 schrieb [hidden email] <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!

marcel.taeumel

Re: The Trunk: Kernel-eem.1325.mcz

Hi Eliot,

no worries. That send is hidden in a string. :-) We'll use #method instead of #compiledBlock.

Best,

Marcel

Am 05.05.2020 20:00:24 schrieb Eliot Miranda <[hidden email]>:

On May 4, 2020, at 2:10 AM, Marcel Taeumel <[hidden email]> wrote:

... would "[:arg | arg + 2] method" work instead of #compiledBlock? :-)

It would. And note that the selector is shared with context
[thisContext method] value
does what one expects...

Best,
Marcel

Am 04.05.2020 11:07:02 schrieb Marcel Taeumel <[hidden email]>:
Hi Eliot.

Now CompiledCodeInspectorTest >> #createObject is not working anymore. It does this:

[:arg | arg + 2] compiledBlock

... as a quick way to get a compiled-code object.

Best,
Marcel

Am 01.05.2020 19:38:40 schrieb [hidden email] <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.1325.mcz

==================== Summary ====================

Name: Kernel-eem.1325
Author: eem
Time: 1 May 2020, 10:38:26.143286 am
UUID: fdfc5299-b643-4879-a7ca-716d825f6988
Ancestors: Kernel-eem.1324

Minor clean-up from the last commit. We don't really need compiledBlock[:], so do without.

=============== Diff against Kernel-eem.1324 ===============

Item was changed:
----- Method: FullBlockClosure>>= (in category 'comparing') -----
= aClosure
self == aClosure ifTrue: [^true].
aClosure class == self class ifFalse: [^false].
+ ^startpcOrMethod = aClosure method
+ and: [outerContext = aClosure outerContext or: [self isClean]]!
- startpcOrMethod = aClosure compiledBlock ifFalse: [^false].
- ^outerContext = aClosure outerContext or: [self isClean]!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock (in category 'accessing') -----
- compiledBlock
- "To be able to inherit from BlockClosure"
- ^ startpcOrMethod!

Item was removed:
- ----- Method: FullBlockClosure>>compiledBlock: (in category 'accessing') -----
- compiledBlock: aCompiledBlock
- "To be able to inherit from BlockClosure"
- startpcOrMethod := aCompiledBlock!