The Trunk: Kernel-eem.993.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-eem.993.mcz

commits-2
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.993.mcz

==================== Summary ====================

Name: Kernel-eem.993
Author: eem
Time: 18 February 2016, 1:37:19.052897 pm
UUID: a151e0db-6470-4e80-8ea8-3c1bbe9282b4
Ancestors: Kernel-cmm.992

Fix Process>>isSuspended.  Fix a comment typo in Process>>isTerminated.  Put all Process testing methods in their own category.

=============== Diff against Kernel-cmm.992 ===============

Item was changed:
+ ----- Method: Process>>isActiveProcess (in category 'testing') -----
- ----- Method: Process>>isActiveProcess (in category 'accessing') -----
  isActiveProcess
 
  ^ self == Processor activeProcess!

Item was changed:
+ ----- Method: Process>>isSuspended (in category 'testing') -----
- ----- Method: Process>>isSuspended (in category 'accessing') -----
  isSuspended
+ "A process is suspended if it is waiting on some list, other than the runnable process lists."
+ | myPriority |
+ "Grab my prioirty now.  Even though evaluation is strictly right-to-left, accessing Processor could involve a send."
+ myPriority := priority.
+ ^myList
+ ifNil: [false]
+ ifNotNil: [:list| list ~~ (Processor waitingProcessesAt: myPriority)]!
- ^myList isNil!

Item was changed:
+ ----- Method: Process>>isTerminated (in category 'testing') -----
- ----- Method: Process>>isTerminated (in category 'accessing') -----
  isTerminated
 
  self isActiveProcess ifTrue: [^ false].
  ^suspendedContext isNil
   or: ["If the suspendedContext is the bottomContext it is the block in Process>>newProcess.
+   If so, and the pc is greater than the startpc, the block has alrteady sent and returned
-   If so, and the pc is greater than the startpc, the bock has alrteady sent and returned
    from value and there is nothing more to do."
  suspendedContext isBottomContext
  and: [suspendedContext pc > suspendedContext startpc]]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-eem.993.mcz

Nicolas Cellier


2016-02-18 22:37 GMT+01:00 <[hidden email]>:
Eliot Miranda uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-eem.993.mcz

==================== Summary ====================

Name: Kernel-eem.993
Author: eem
Time: 18 February 2016, 1:37:19.052897 pm
UUID: a151e0db-6470-4e80-8ea8-3c1bbe9282b4
Ancestors: Kernel-cmm.992

Fix Process>>isSuspended.  Fix a comment typo in Process>>isTerminated.  Put all Process testing methods in their own category.

=============== Diff against Kernel-cmm.992 ===============

Item was changed:
+ ----- Method: Process>>isActiveProcess (in category 'testing') -----
- ----- Method: Process>>isActiveProcess (in category 'accessing') -----
  isActiveProcess

        ^ self == Processor activeProcess!

Item was changed:
+ ----- Method: Process>>isSuspended (in category 'testing') -----
- ----- Method: Process>>isSuspended (in category 'accessing') -----
  isSuspended
+       "A process is suspended if it is waiting on some list, other than the runnable process lists."
+       | myPriority |
+       "Grab my prioirty now.  Even though evaluation is strictly right-to-left, accessing Processor could involve a send."
+       myPriority := priority.
+       ^myList
+               ifNil: [false]
+               ifNotNil: [:list| list ~~ (Processor waitingProcessesAt: myPriority)]!
-       ^myList isNil!

Item was changed:
+ ----- Method: Process>>isTerminated (in category 'testing') -----
- ----- Method: Process>>isTerminated (in category 'accessing') -----
  isTerminated

        self isActiveProcess ifTrue: [^ false].
        ^suspendedContext isNil
          or: ["If the suspendedContext is the bottomContext it is the block in Process>>newProcess.
+                  If so, and the pc is greater than the startpc, the block has alrteady sent and returned
isn't the typo still there above-------------------------------------------------------------^
-                  If so, and the pc is greater than the startpc, the bock has alrteady sent and returned
                   from value and there is nothing more to do."
                suspendedContext isBottomContext
                and: [suspendedContext pc > suspendedContext startpc]]!