The Trunk: Kernel-laza.428.mcz

On Mon, 22 Mar 2010, [hidden email] wrote:

Alexander Lazarević uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-laza.428.mcz

==================== Summary ====================

Name: Kernel-laza.428
Author: laza
Time: 22 March 2010, 11:47:56.242 am
UUID: 5b1e683b-2d8c-4f21-b877-30e2426f1491
Ancestors: Kernel-ul.427

Order instance variables alphabetically

=============== Diff against Kernel-ul.427 ===============

Item was changed:
 ----- Method: Object>>longPrintOn:limitedTo:indent: (in category 'printing') -----
 longPrintOn: aStream limitedTo: sizeLimit indent: indent
       "Append to the argument, aStream, the names and values of all of the receiver's instance variables.  Limit is the length limit for each inst var."

+       self class allInstVarNames asSortedArray doWithIndex:
-       self class allInstVarNames doWithIndex:
               [:title :index |
               indent timesRepeat: [aStream tab].
               aStream nextPutAll: title;
                nextPut: $:;
                space;
                tab;
                nextPutAll:
                       ((self instVarAt: index) printStringLimitedTo: (sizeLimit -3 -title size max: 1));
                cr]!

This won't work, because only the names are changed the indices are the same, so #instVarAt: will give the wrong value. Also #asSortedArray should be deprecated IMHO.


Levente

Also, instance variable order is significant so in a debug method I'd rather prefer to not see it changed - what's your reasoning here?

On Mon, Mar 22, 2010 at 12:55:55PM +0100, Alexander Lazarevi?? wrote:
> On Mon, Mar 22, 2010 at 12:17, Bert Freudenberg <[hidden email]>wrote:
>
> > Also, instance variable order is significant so in a debug method I'd
> > rather prefer to not see it changed - what's your reasoning here?
> >
>
> Maybe I just can't see how it does help in a debugger to have the instance
> vars listed in the order they were defined. Usually I'm looking for names
> not slot indices? No?
>
> (Truly wondering!)

Usually yes, but not always. See senders of #instVarAt:. If you were
debugging any of those methods, you would want to see the variables
listed in the correct order.

Dave

On 22.03.2010, at 15:42, Alexander Lazarević wrote:
> So this is helpful in >1% of possible debugging sessions? Wouldn'tthe BasicInspector be sufficient for this?
>
> Alex

I simply prefer to see objects as the author intended. Typically, instance variables are grouped by function. The order is not random.

I feel the same about source code - I want to see it as it was written, not what some pretty printer makes of it.

The way source code looks tells me something about the author. Same for instance variable order.