The Trunk: Kernel-mt.1170.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-mt.1170.mcz

commits-2
Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-mt.1170.mcz

==================== Summary ====================

Name: Kernel-mt.1170
Author: mt
Time: 24 May 2018, 10:24:50.225621 am
UUID: 722cd140-f6f2-8642-be85-61be05c77c92
Ancestors: Kernel-mt.1169

Harmonize method reference and class references.

=============== Diff against Kernel-mt.1169 ===============

Item was removed:
- ----- Method: CompiledCode>>printSignatureOn: (in category 'printing') -----
- printSignatureOn: aStream
- "Print a string that can be used to access the currently installed method."
- aStream print: self methodClass;
- nextPutAll: '>>';
- nextPutAll: self selector storeString!

Item was added:
+ ----- Method: Object>>isClassReference (in category 'testing') -----
+ isClassReference
+
+ ^ false!

Item was added:
+ ----- Method: Object>>isReference (in category 'testing') -----
+ isReference
+
+ ^ self isClassReference or: [self isMethodReference]!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-mt.1170.mcz

Eliot Miranda-2
Hi Marcel,


    for me, isReference is far too general a selector for this.  Why not isCodeReference or isSmalltalkCodeReference?

On Thu, May 24, 2018 at 1:25 AM, <[hidden email]> wrote:
Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-mt.1170.mcz

==================== Summary ====================

Name: Kernel-mt.1170
Author: mt
Time: 24 May 2018, 10:24:50.225621 am
UUID: 722cd140-f6f2-8642-be85-61be05c77c92
Ancestors: Kernel-mt.1169

Harmonize method reference and class references.

=============== Diff against Kernel-mt.1169 ===============

Item was removed:
- ----- Method: CompiledCode>>printSignatureOn: (in category 'printing') -----
- printSignatureOn: aStream
-       "Print a string that can be used to access the currently installed method."
-       aStream print: self methodClass;
-                nextPutAll: '>>';
-                nextPutAll: self selector storeString!

Item was added:
+ ----- Method: Object>>isClassReference (in category 'testing') -----
+ isClassReference
+
+       ^ false!

Item was added:
+ ----- Method: Object>>isReference (in category 'testing') -----
+ isReference
+
+       ^ self isClassReference or: [self isMethodReference]!


_,,,^..^,,,_
best, Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-mt.1170.mcz

marcel.taeumel
Hi Eliot,

okay. Still, #asReference would be okay? Or would that be #asCodeReference, too?

Best,
Marcel

Am 24.05.2018 21:31:27 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,


    for me, isReference is far too general a selector for this.  Why not isCodeReference or isSmalltalkCodeReference?

On Thu, May 24, 2018 at 1:25 AM, <[hidden email]> wrote:
Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-mt.1170.mcz

==================== Summary ====================

Name: Kernel-mt.1170
Author: mt
Time: 24 May 2018, 10:24:50.225621 am
UUID: 722cd140-f6f2-8642-be85-61be05c77c92
Ancestors: Kernel-mt.1169

Harmonize method reference and class references.

=============== Diff against Kernel-mt.1169 ===============

Item was removed:
- ----- Method: CompiledCode>>printSignatureOn: (in category 'printing') -----
- printSignatureOn: aStream
-       "Print a string that can be used to access the currently installed method."
-       aStream print: self methodClass;
-                nextPutAll: '>>';
-                nextPutAll: self selector storeString!

Item was added:
+ ----- Method: Object>>isClassReference (in category 'testing') -----
+ isClassReference
+
+       ^ false!

Item was added:
+ ----- Method: Object>>isReference (in category 'testing') -----
+ isReference
+
+       ^ self isClassReference or: [self isMethodReference]!


_,,,^..^,,,_
best, Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-mt.1170.mcz

Eliot Miranda-2
Hi Marcel,

On Fri, May 25, 2018 at 12:24 AM, Marcel Taeumel <[hidden email]> wrote:
Hi Eliot,

okay. Still, #asReference would be okay? Or would that be #asCodeReference, too?

I'll leave that to you.  For me I would use asCodeReference, but it's less pressing because the receivers (methods and classes) arguably make the "Code" implicit.


Best,
Marcel

Am 24.05.2018 21:31:27 schrieb Eliot Miranda <[hidden email]>:

Hi Marcel,


    for me, isReference is far too general a selector for this.  Why not isCodeReference or isSmalltalkCodeReference?

On Thu, May 24, 2018 at 1:25 AM, <[hidden email]> wrote:
Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-mt.1170.mcz

==================== Summary ====================

Name: Kernel-mt.1170
Author: mt
Time: 24 May 2018, 10:24:50.225621 am
UUID: 722cd140-f6f2-8642-be85-61be05c77c92
Ancestors: Kernel-mt.1169

Harmonize method reference and class references.

=============== Diff against Kernel-mt.1169 ===============

Item was removed:
- ----- Method: CompiledCode>>printSignatureOn: (in category 'printing') -----
- printSignatureOn: aStream
-       "Print a string that can be used to access the currently installed method."
-       aStream print: self methodClass;
-                nextPutAll: '>>';
-                nextPutAll: self selector storeString!

Item was added:
+ ----- Method: Object>>isClassReference (in category 'testing') -----
+ isClassReference
+
+       ^ false!

Item was added:
+ ----- Method: Object>>isReference (in category 'testing') -----
+ isReference
+
+       ^ self isClassReference or: [self isMethodReference]!


_,,,^..^,,,_
best, Eliot






--
_,,,^..^,,,_
best, Eliot


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Kernel-mt.1170.mcz

Chris Muller-3
In reply to this post by Eliot Miranda-2
I agree with Eliot, "Reference" can mean all sorts of things, so it's
very plausible that an application might implement
Object>>#isReference for its own purposes.  We should take care
to not let the class library accidentally crowd out the namespace.



On Thu, May 24, 2018 at 2:31 PM, Eliot Miranda <[hidden email]> wrote:

> Hi Marcel,
>
>
>     for me, isReference is far too general a selector for this.  Why not
> isCodeReference or isSmalltalkCodeReference?
>
> On Thu, May 24, 2018 at 1:25 AM, <[hidden email]> wrote:
>>
>> Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
>> http://source.squeak.org/trunk/Kernel-mt.1170.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Kernel-mt.1170
>> Author: mt
>> Time: 24 May 2018, 10:24:50.225621 am
>> UUID: 722cd140-f6f2-8642-be85-61be05c77c92
>> Ancestors: Kernel-mt.1169
>>
>> Harmonize method reference and class references.
>>
>> =============== Diff against Kernel-mt.1169 ===============
>>
>> Item was removed:
>> - ----- Method: CompiledCode>>printSignatureOn: (in category 'printing')
>> -----
>> - printSignatureOn: aStream
>> -       "Print a string that can be used to access the currently installed
>> method."
>> -       aStream print: self methodClass;
>> -                nextPutAll: '>>';
>> -                nextPutAll: self selector storeString!
>>
>> Item was added:
>> + ----- Method: Object>>isClassReference (in category 'testing') -----
>> + isClassReference
>> +
>> +       ^ false!
>>
>> Item was added:
>> + ----- Method: Object>>isReference (in category 'testing') -----
>> + isReference
>> +
>> +       ^ self isClassReference or: [self isMethodReference]!
>
>
>
> _,,,^..^,,,_
> best, Eliot
>
>
>