The Trunk: Kernel-mt.1283.mcz

Am 07.12.2019 00:06:37 schrieb Thiede, Christoph <[hidden email]>:

Just curious: #matchesRegex: is defined in Regex-Core as well as RegexSyntaxError.

What are your goals to make changes like this?

In general, wouldn't generic error handling like this increase the risk of suppressing unexpected errors? :-)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Mittwoch, 27. November 2019 10:25:56
An: [hidden email]; [hidden email]
Betreff: [squeak-dev] The Trunk: Kernel-mt.1283.mcz

 

Marcel Taeumel uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-mt.1283.mcz

==================== Summary ====================

Name: Kernel-mt.1283
Author: mt
Time: 27 November 2019, 10:25:51.203363 am
UUID: 04694a24-76a1-a941-b664-645ffc7f27e6
Ancestors: Kernel-nice.1282

Removes Kernel -> Regex dependency.

=============== Diff against Kernel-nice.1282 ===============

Item was changed:
  ----- Method: BlockClosure>>valueSupplyingAnswers: (in category 'evaluating') -----
  valueSupplyingAnswers: aListOfPairs
         "evaluate the block using a list of questions / answers that might be called upon to
         automatically respond to Object>>confirm: or FillInTheBlank requests"
 
         ^self
                 on: ProvideAnswerNotification
                 do: [ :notification |
                         | caption |
                         caption := notification messageText withSeparatorsCompacted. "to remove new lines"
                         aListOfPairs
                                 detect:  [ :each |
                                         caption = each first
                                                 or: [ (caption includesSubstring: each first caseSensitive: false)
                                                 or: [ (each first match: caption)
                                                 or: [ (caption respondsTo: #matchesRegex:)
+                                                        and: [ [caption matchesRegex: each first] on: Error do: [false] ] ] ] ] ]
-                                                        and: [ [caption matchesRegex: each first] on: RegexSyntaxError do: [false] ] ] ] ] ]
                                 ifFound: [ :answer | notification resume: answer second ]
                                 ifNone: [
                                         (ProvideAnswerNotification signal: notification messageText)
                                                 ifNil: [ notification resume ]
                                                 ifNotNil: [ :outerAnswer | notification resume: outerAnswer ] ] ]!

Thanks for the explanation :)

Logging uncritical errors instead of displaying them to the user? This does not sound like the loveable and always improvable system I have always known ;-)

If we decided to do something like this, I would rather suggest to raise a kind of warning that can be suppressed by uninterested users.

And just by the way, wouldn't the following be a valid refactoring? I cannot observe any difference :)

Best,

Christoph