The Trunk: Kernel-nice.1291.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Kernel-nice.1291.mcz

commits-2
Nicolas Cellier uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-nice.1291.mcz

==================== Summary ====================

Name: Kernel-nice.1291
Author: nice
Time: 26 December 2019, 6:56:30.382504 pm
UUID: ba77885c-3a21-4d74-a5a4-ef2c3572e192
Ancestors: Kernel-mt.1290

Make AssertionFailure an Error rather than a Halt.

This change is necessary for at least running the SUnit tests suite, otherwise the DecompilerTests hangs in a debugger...

There was a consensus on this decision in squeak-dev thread last november, so let's just do it:
[squeak-dev] Squeak's AssertionFailure vs. SUnit's TestFailure
http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-November/205039.html

For now, keep it resumable. I don't know if reasonable, but like that, AssertionFailure behavior should be mostly unchanged.

=============== Diff against Kernel-mt.1290 ===============

Item was changed:
+ Error subclass: #AssertionFailure
- Halt subclass: #AssertionFailure
  instanceVariableNames: ''
  classVariableNames: ''
  poolDictionaries: ''
  category: 'Kernel-Exceptions'!
 
  !AssertionFailure commentStamp: 'gh 5/2/2002 20:29' prior: 0!
  AsssertionFailure is the exception signaled from Object>>assert: when the assertion block evaluates to false.!

Item was added:
+ ----- Method: AssertionFailure>>isResumable (in category 'priv handling') -----
+ isResumable
+ ^ true!