Nicolas Cellier uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-nice.409.mcz==================== Summary ====================
Name: Kernel-nice.409
Author: nice
Time: 25 February 2010, 11:53:34.677 pm
UUID: b2b17afb-4018-414e-9deb-0ed629e8c9db
Ancestors: Kernel-nice.408
Cuis 2.2 Semaphore comments
=============== Diff against Kernel-nice.408 ===============
Item was changed:
----- Method: Semaphore>>critical:ifLocked: (in category 'mutual exclusion') -----
critical: mutuallyExcludedBlock ifLocked: alternativeBlock
"Evaluate mutuallyExcludedBlock only if the receiver is not currently in
the process of running the critical: message. If the receiver is, evaluate
mutuallyExcludedBlock after the other critical: message is finished."
+
+ "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only."
excessSignals == 0 ifTrue:[
"If we come here, then the semaphore was locked when the test executed.
Evaluate the alternative block and answer its result."
^alternativeBlock value
].
^self critical: mutuallyExcludedBlock!
Item was changed:
----- Method: Semaphore>>critical: (in category 'mutual exclusion') -----
+ critical: mutuallyExcludedBlock
- critical: mutuallyExcludedBlock
"Evaluate mutuallyExcludedBlock only if the receiver is not currently in
the process of running the critical: message. If the receiver is, evaluate
mutuallyExcludedBlock after the other critical: message is finished."
+
| caught |
+ "We need to catch eventual interruptions very carefully.
+ The naive approach of just doing, e.g.,:
+ self wait.
+ aBlock ensure:[self signal].
+ will fail if the active process gets terminated while in the wait.
+ However, the equally naive:
+ [self wait.
+ aBlock value] ensure:[self signal].
+ will fail too, since the active process may get interrupted while
+ entering the ensured block and leave the semaphore signaled twice.
+ To avoid both problems we make use of the fact that interrupts only
+ occur on sends (or backward jumps) and use an assignment (bytecode)
+ right before we go into the wait primitive (which is not a real send and
+ therefore not interruptable either)."
+
caught := false.
^[
caught := true.
self wait.
mutuallyExcludedBlock value
+ ] ensure: [ caught ifTrue: [self signal] ]
- ] ensure: [caught ifTrue: [self signal]]
!
Locked
